Add @temporalio/client to server-external-packages #58573
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamnafets
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
timneutkens
approved these changes
Nov 17, 2023
1 task
kdy1
approved these changes
Jan 29, 2024
|
Hey @iamnafets it seems your branch doesn't allow maintainers to push to it, which means I can't update it to ensure the tests can run correctly. Could you:
|
|
@iamnafets It looks like this fell through the cracks. Is this something that still needs to be added? |
Yes! |
ijjk
reviewed
Apr 23, 2024
| @@ -11,6 +11,7 @@ | |||
| "@react-pdf/renderer", | |||
| "@sentry/profiling-node", | |||
| "@swc/core", | |||
| "@temporalio/client", | |||
There was a problem hiding this comment.
This needs to be added in https://github.com/vercel/next.js/blob/canary/docs/02-app/02-api-reference/05-next-config-js/serverComponentsExternalPackages.mdx as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@temporalio/client uses reflection on constructor names and thus breaks. In temporalio/sdk-typescript#1279 they insist that the package should be configured as external to avoid these types of breakages.
Why?
Without this the package is broken in a very non-obvious way.
How?
By adding @temporalio/client to server-external-packages.json.