Consolidate manifest writing for Turbopack in a single function #59663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
feedthejim,
ztanner,
wyattjoh and
a team
as code owners
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
timneutkens
commented
Dec 15, 2023
| @@ -552,7 +552,7 @@ async function startWatcher(opts: SetupOpts) { | |||
| hmrBuilding = true | |||
| } | |||
| hmrPayloads.set(`${key}:${id}`, payload) | |||
| hmrEventHappend = true | |||
| hmrEventHappened = true | |||
There was a problem hiding this comment.
Noticed a typo here, corrected it.
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
feedthejim
reviewed
Dec 15, 2023
| @@ -1041,6 +1041,18 @@ async function startWatcher(opts: SetupOpts) { | |||
| ) | |||
| } | |||
|
|
|||
| async function writeManifests(): Promise<void> { | |||
feedthejim
approved these changes
Dec 15, 2023
timneutkens
commented
Dec 15, 2023
| @@ -1166,6 +1178,8 @@ async function startWatcher(opts: SetupOpts) { | |||
| 'edge' | |||
| ) | |||
| await loadMiddlewareManifest('instrumentation', 'instrumentation') | |||
| await writeManifests() | |||
There was a problem hiding this comment.
Noticed this bug where it didn't write the manifest with instrumentation
gnoff
approved these changes
Dec 15, 2023
Comment on lines
+1045
to
+1053
| await writeBuildManifest(opts.fsChecker.rewrites) | ||
| await writeAppBuildManifest() | ||
| await writePagesManifest() | ||
| await writeAppPathsManifest() | ||
| await writeMiddlewareManifest() | ||
| await writeActionManifest() | ||
| await writeFontManifest() | ||
| await writeLoadableManifest() | ||
| await writeFallbackBuildManifest() |
There was a problem hiding this comment.
do we want to parallelize these? I have not idea if they have side effects so maybe not safe but seemingly the io parts could be done in parallel if they do not interact
There was a problem hiding this comment.
Overall we'll likely want to make these sync fs actually, but kept it as-is for now, can optimize later 👍
timneutkens
deleted the
12-15-Consolidate_manifest_writing_for_Turbopack_in_a_single_function
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I'm working on consolidating a bunch of the file writing related pieces in the Turbopack handling in the dev server so that it can be abstracted out as it's needed for
next buildtoo.These changes make sure that there is a single
writeManifests()instead of picking specific manifests to write.We can optimize this later but for now the overhead of writing them to disk separately is negligible.
Closes NEXT-1884