docs: improve docs around geolocation and IP headers #59719
Merged
+267
−186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerob
requested review from
manovotny and
StephDietz
and removed request for
a team
ijjk
added
area: documentation
created-by: Next.js Docs team
This was referenced Dec 17, 2023
delbaoliveira
requested changes
Dec 18, 2023
docs/02-app/01-building-your-application/01-routing/11-middleware.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
delbaoliveira
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from #47793, I made some improvements around the geolocation docs. Specifically around
request.ip,request.geo, and how to access these values. I noticed there was a bit of a divergence, as some of theNextRequestandNextResponsedocs were split out for the App Router section, but not all.This PR finishes that swing by removing the previous catch-all for
next/serverin the Pages Router docs and splits them into individual docs pages.Wrote a lil' thread about this: https://twitter.com/leeerob/status/1736543599339172121