Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade with-algolia-react-instantsearch example to latest major version and use app router #59961

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Upgrade with-algolia-react-instantsearch example to latest major version and use app router #59961

merged 3 commits into from
Dec 27, 2023

Conversation

dhayab
Copy link
Contributor

@dhayab dhayab commented Dec 27, 2023

This PR upgrades the Algolia React InstantSearch example, to allow users to quickly set up an up to date project using:

  • the latest major version of React InstantSearch
  • a router mechanism that doesn't conflict with Next.js' own router
  • a file structure relying on the App router instead of the Pages router

This is a replacement for #49939.

@dhayab dhayab requested review from a team as code owners December 27, 2023 11:03
@dhayab dhayab requested review from timeyoutakeit and delbaoliveira and removed request for a team December 27, 2023 11:03
@ijjk ijjk added the examples Issue/PR related to examples label Dec 27, 2023

import Search from '../components/Search'

export const dynamic = 'force-dynamic'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be needed for all search use cases, but it is necessary when users implement personalized search.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that? How is this library doing data fetching?

@ijjk
Copy link
Member

ijjk commented Dec 27, 2023

Allow CI Workflow Run

  • approve CI run for commit: d7eb087

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk
Copy link
Member

ijjk commented Dec 27, 2023

Allow CI Workflow Run

  • approve CI run for commit: d7eb087

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Dec 27, 2023

Allow CI Workflow Run

  • approve CI run for commit: d7eb087

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@leerob leerob merged commit 2c811af into vercel:canary Dec 27, 2023
32 checks passed
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
…t major version and use app router (vercel#59961)

Co-authored-by: Lee Robinson <me@leerob.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants