Use Object.assign instead of object spread for serverless loader #6056
+6
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav-is
approved these changes
Jan 14, 2019
timneutkens
added a commit
to timneutkens/next.js
that referenced
this pull request
Jan 17, 2019
…cel#6056) Fixes vercel/now-builders#168 For some reason with a certain mix of deps `...` is not supported in webpack's parsing. By default it is supported as all our tests passed before and we have deployed Next.js apps on v2 already.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/zeit/now-builders/issues/168
For some reason with a certain mix of deps
...is not supported in webpack's parsing.By default it is supported as all our tests passed before and we have deployed Next.js apps on v2 already.