New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation page on video optimization #60574

Merged

StephDietz merged 62 commits into canary from video-optimization-docs

Jan 19, 2024

Collaborator

StephDietz commented Jan 12, 2024 •

edited

I've added a new page to the Next.js docs about optimizing videos. It covers:

the native video and iframe tag
displaying externally hosted videos (i.e. from youtube)
self hosting strategies and best practices
Video optimization techniques


          add video optimiztion documentation

2217f88

ijjk added area: documentation Font (next/font) created-by: Next.js DevEx team labels

Member

ijjk commented Jan 12, 2024 •

edited by leerob

Allow CI Workflow Run

approve CI run for commit: 2217f88

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Member

ijjk commented Jan 12, 2024 •

edited

Allow CI Workflow Run

approve CI run for commit: 8653e0b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

StephDietz added 2 commits

January 12, 2024 11:55


          edits

2bc886f


          edit

5b3c8de

StephDietz marked this pull request as ready for review

January 12, 2024 18:03

StephDietz requested review from a team, timneutkens, ijjk, shuding, huozhi, feedthejim, ztanner and wyattjoh as code owners

January 12, 2024 18:03

StephDietz requested review from ismaelrumzan and delbaoliveira and removed request for a team

January 12, 2024 18:03

leerob reviewed

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

leerob reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

StephDietz and others added 7 commits

January 16, 2024 10:24


          revert setting.json

12f5704


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

8cff0f2

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

5d58064

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

bfc73a3

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

bdd269c

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

391dbcf

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

6b6b007

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>

manovotny reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

manovotny reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

manovotny reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

manovotny reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

manovotny reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

manovotny reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

manovotny reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

manovotny reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

manovotny reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

StephDietz and others added 3 commits

January 18, 2024 11:40


          michael feedback

dfbf08b


          Merge branch 'canary' into video-optimization-docs

aae705e


          Merge branch 'canary' into video-optimization-docs

2e15094

leerob reviewed

View reviewed changes

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved

balazsorban44 mentioned this pull request

chore: fix core team members #60900

Merged

StephDietz and others added 7 commits

January 19, 2024 12:10


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

1d193a2

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

1046f6c

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

529e0ce

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Update docs/02-app/01-building-your-application/06-optimizing/02-vide…

c9431ea

…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>


          Merge branch 'canary' into video-optimization-docs

8653e0b

StephDietz requested a review from leerob

January 19, 2024 18:17

samcx pushed a commit that referenced this pull request


          chore: fix core team members (#60900)

6217e3f

### What?

Removing an outdated entry, and fixing the casing of another so Workflow
runs are auto-approved.

### Why?

#60574 fails the CI Workflow Run,
because of a mismatch in GitHub actor and the actual username set in
`labeler.json`


[Ref](https://github.com/vercel/nextjs-hive-docker/blob/c26bc3f26520b41986a0f9467fdc2529f705d81f/validate-job.js#L39-L42),
[Slack
thread](https://vercel.slack.com/archives/C03S9JCH2Q5/p1705684536884389?thread_ts=1705436555.494229&cid=C03S9JCH2Q5)

Closes NEXT-2172


          Merge branch 'canary' into video-optimization-docs

fd2963e

StephDietz merged commit 4a74492 into canary

34 checks passed

StephDietz deleted the video-optimization-docs branch

January 19, 2024 19:09

Contributor

AhmedBaset commented Jan 19, 2024

Since the next line starts with (spaces), the parser considers it as multi-line item and wrap the title in a new line

This code block has no left padding

vordgi mentioned this pull request

Remove obsolete ("remove after next minor") #60930

Open

github-actions bot added the locked label

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

heff heff left review comments

manovotny manovotny left review comments

jlubawy jlubawy left review comments

cjpillsbury cjpillsbury left review comments

delbaoliveira delbaoliveira approved these changes

timneutkens Awaiting requested review from timneutkens

ijjk Awaiting requested review from ijjk

shuding Awaiting requested review from shuding

huozhi Awaiting requested review from huozhi

feedthejim Awaiting requested review from feedthejim

ztanner Awaiting requested review from ztanner

wyattjoh Awaiting requested review from wyattjoh

ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan is a code owner automatically assigned from vercel/devex

leerob Awaiting requested review from leerob