Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with-mux-video: move to app router and update packages #62297

Merged
merged 20 commits into from Mar 7, 2024

Conversation

decepulis
Copy link
Contributor

App Router

Moves the with-mux-video example to idiomatic App Router, with goodies like

  • server component data fetching
  • server actions
  • layouts
  • route groups
  • loading UI

Mux Dependencies

  • @mux/mux-node 7 -> 8
  • @mux/mux-player-react 1 -> 2
  • @mux/upchunk + custom UI -> @mux/mux-uploader

In other news...

  • Fleshed out the README
  • Updated imagery
  • Moved from styled jsx to tailwind and lightly updated styles

Contributor Checklist

@decepulis decepulis requested review from ismaelrumzan and molebox and removed request for a team February 20, 2024 18:35
@ijjk ijjk added the examples Issue/PR related to examples label Feb 20, 2024
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx enabled auto-merge (squash) March 7, 2024 22:05
@samcx samcx merged commit eace44d into vercel:canary Mar 7, 2024
30 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants