chore(logging): Disable info logging of critters in production #62776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low configuration of log level
jonluca
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
|
@ijjk @timneutkens this is a small change but one that would be a great quality of life for us (and anyone that uses tailwind + SSR + nextjs) to clean up our production logging. Would appreciate a review, or any comments |
timneutkens
approved these changes
Apr 17, 2024
|
Looks good to me to land 👍 |
|
Probably important to know: that experimental flag was discontinued and is no longer being worked on, it'll likely be removed in the near future. |
|
Thanks! Really? That flag is what enables SSR to work properly for tailwind apps in pages mode. You get a flash of unstyled content otherwise. Is there a preferred way of solving that? I opened this discussion #62777 to ask if there was some way of doing this in userland pre response but I don't think there is. |
ijjk
approved these changes
Apr 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critters uses the
infologLevel by default. This means that when you enable the experimentaloptimizeCssproperty, your production logs will be polluted with their logsThis sets the log level to warn by default in production, and allows configuration via an environment variable