New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next): next.config.ts
#63051
Open
devjiwonchoi
wants to merge
166
commits into
vercel:canary
Choose a base branch
from
devjiwonchoi:next-config-ts-esm
base: canary
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(next): next.config.ts
#63051
+601
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: vercel#57656 (comment) Co-authored-by: Donny/강동윤 <kdy1997.dev@gmail.com>
Co-authored-by: rodrigo <falsepopsky@protonmail.com>
Co-authored-by: Sukka <isukkaw@gmail.com>
@ijjk Understood. Can I have a day for the last try? 😊 Edit: All tests pass, successful w/o bundling, will work on refactor & reducing fs operations! |
devjiwonchoi
commented
Apr 25, 2024
devjiwonchoi
commented
Apr 25, 2024
AhmedBaset
reviewed
Apr 25, 2024
Co-authored-by: Ahmed Abdelbaset <A7med3bdulBaset@gmail.com>
@ijjk Thank you for waiting! Current change meets the major expectations we discussed before:
|
ijjk
reviewed
Apr 26, 2024
Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI approved
Approve running CI for fork
create-next-app
Related to our CLI tool for quickly starting a new Next.js application.
Documentation
Related to Next.js' official documentation.
tests
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR initiated support of
next.config.ts
.Follow ups:
Why?
This PR can resolve the two main needs:
type
instead of JSDoc.x-ref: #5318 #35969 #44632 #50121 #50126
How?
Goals
Used
require.extensions
hooks to transpile the imported files on the fly.To reduce I/O operation on disk, used custom
module.exports
to require directly from a transpiled code string.Expected
as default
Importing Files
node_modules
JSON
Extensions
.ts
.cts
.mts
.cjs
.mjs
.js
(both ESM and CJS w/o extra change)