Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(turbopack): Support proxy for next/font #63309

Closed
wants to merge 9 commits into from
Closed

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 15, 2024

What?

Pass proxy configuration down to the fetch function.

Why?

It's required to support proxy for next/font

How?

Closes PACK-2448

@kdy1 kdy1 self-assigned this Mar 15, 2024
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Mar 15, 2024
@ijjk
Copy link
Member

ijjk commented Mar 15, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/pack-2448 Change
buildDuration 13.8s 13.8s N/A
buildDurationCached 7.4s 6.3s N/A
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 397ms 398ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/pack-2448 Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 243 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/pack-2448 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/pack-2448 Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/pack-2448 Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/pack-2448 Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/pack-2448 Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/pack-2448 Change
middleware-b..fest.js gzip 625 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/pack-2448 Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97 kB 97 kB
app-page-tur..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 51 kB 51 kB
Overall change 945 kB 945 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/pack-2448 Change
0.pack gzip 1.58 MB 1.58 MB ⚠️ +174 B
index.pack gzip 106 kB 106 kB N/A
Overall change 1.58 MB 1.58 MB ⚠️ +174 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: eb4202c

@ijjk
Copy link
Member

ijjk commented Mar 15, 2024

Failing test suites

Commit: eb4202c

TURBOPACK=1 pnpm test-dev test/e2e/prerender.test.ts (turbopack)

  • Prerender > should handle fallback only page correctly HTML
Expand output

● Prerender › should handle fallback only page correctly HTML

expect(received).toContain(expected) // indexOf

Expected substring: "hi fallback"
Received string:    "Post: first/post"

  849 |
  850 |       const text = await browser.elementByCss('p').text()
> 851 |       expect(text).toContain('hi fallback')
      |                    ^
  852 |
  853 |       // wait for fallback data to load
  854 |       await check(() => browser.elementByCss('p').text(), /Post/)

  at Object.toContain (e2e/prerender.test.ts:851:20)

Read more about building and testing Next.js in contributing.md.

@kdy1
Copy link
Member Author

kdy1 commented Apr 1, 2024

It seems like webpack version is using something other than CONNECT method for request.

[/Users/kdy1/projects/reqwest/src/connect.rs:377] &proxy_dst = http://localhost:58584/
[/Users/kdy1/projects/reqwest/src/connect.rs:774]
[/Users/kdy1/projects/reqwest/src/connect.rs:794]
[/Users/kdy1/projects/reqwest/src/connect.rs:800]
[/Users/kdy1/projects/reqwest/src/connect.rs:806]
[/Users/kdy1/projects/reqwest/src/connect.rs:810] n = 0
[turbo/crates/turbo-tasks-fetch/src/lib.rs:109] &error = reqwest::Error {
    kind: Request,
    url: Url {
        scheme: "https",
        cannot_be_a_base: false,
        username: "",
        password: None,
    host: Some(
            Domain(
                "fonts.googleapis.com",
            ),
        ),
        port: None,
        path: "/css2",
    query: Some(
            "family=Oswald:wght@200..700&display=swap",
        ),
        fragment: None,
    },
    source: Error {
        kind: Connect,
source: Some(
            "unexpected eof while tunneling",
        ),
    },
}

Comment on lines +816 to +822
let proxy_option = match std::env::var("http_proxy") {
Ok(proxy) => Vc::cell(Some(ProxyConfig::Http(proxy))),
Err(_) => match std::env::var("https_proxy") {
Ok(proxy) => Vc::cell(Some(ProxyConfig::Https(proxy))),
Err(_) => Vc::cell(None),
},
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break persistent caching since the env var might change between runs.
Use turbo-tasks-env to read env vars.

@kdy1
Copy link
Member Author

kdy1 commented May 17, 2024

Closing in favor of #65870

@kdy1 kdy1 closed this May 17, 2024
@kdy1 kdy1 deleted the kdy1/pack-2448 branch May 17, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the turbopack team tests Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants