Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update swc_core to v0.90.30 #63790

Merged
merged 10 commits into from
Apr 11, 2024
Merged

build: Update swc_core to v0.90.30 #63790

merged 10 commits into from
Apr 11, 2024

Conversation

@kdy1 kdy1 self-assigned this Mar 28, 2024
@kdy1 kdy1 requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners March 28, 2024 02:39
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Mar 28, 2024
@kdy1 kdy1 marked this pull request as draft March 28, 2024 05:52
@kdy1 kdy1 changed the title build: Update swc_core to v0.90.26 build: Update swc_core to v0.90.27 Apr 5, 2024
@kdy1 kdy1 force-pushed the kdy1/swc-core-0-90-10 branch 2 times, most recently from c7776b7 to 4d4b237 Compare April 5, 2024 02:07
@kdy1 kdy1 changed the title build: Update swc_core to v0.90.27 build: Update swc_core to v0.90.29 Apr 9, 2024
@ijjk
Copy link
Member

ijjk commented Apr 9, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-10 Change
buildDuration 15.8s 15.9s N/A
buildDurationCached 8.7s 7.4s N/A
nodeModulesSize 199 MB 199 MB
nextStartRea..uration (ms) 427ms 424ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-10 Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.1 kB 5.1 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-10 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-10 Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.63 kB 6.63 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-10 Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-10 Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-10 Change
edge-ssr.js gzip 95.6 kB 95.6 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-10 Change
middleware-b..fest.js gzip 623 B 625 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 839 B 839 B
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-10 Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97.4 kB 97.4 kB
app-page-tur..prod.js gzip 99.1 kB 99.1 kB
app-page-tur..prod.js gzip 93.4 kB 93.4 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.9 kB 91.9 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.3 kB 51.3 kB
Overall change 948 kB 948 kB
build cache
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-10 Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 107 kB 106 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: b6c3d64

@ijjk
Copy link
Member

ijjk commented Apr 9, 2024

Failing test suites

Commit: 606e4b3

pnpm test test/integration/link-ref/test/index.test.js

  • Invalid hrefs > production mode > should preload with child ref with React.createRef
Expand output

● Invalid hrefs › production mode › should preload with child ref with React.createRef

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  45 |     }
  46 |   }
> 47 |   expect(found).toBe(true)
     |                 ^
  48 |   await browser.close()
  49 | }
  50 |

  at toBe (integration/link-ref/test/index.test.js:47:17)
  at Object.<anonymous> (integration/link-ref/test/index.test.js:106:9)

Read more about building and testing Next.js in contributing.md.

@kdy1 kdy1 changed the title build: Update swc_core to v0.90.29 build: Update swc_core to v0.90.30 Apr 10, 2024
kdy1 added a commit to vercel/turbo that referenced this pull request Apr 10, 2024
### Description

Update SWC crates.


1. To keep in sync
2. Prepare usage of source map range mappings.
getsentry/rust-sourcemap#77


### Testing Instructions

See next.js counterpart.

vercel/next.js#63790

Closes PACK-2861
@kdy1 kdy1 marked this pull request as ready for review April 10, 2024 23:50
@kdy1 kdy1 requested review from a team, feedthejim, ztanner and wyattjoh as code owners April 10, 2024 23:50
@kdy1 kdy1 enabled auto-merge (squash) April 10, 2024 23:50
@kdy1 kdy1 merged commit 02dd1e5 into canary Apr 11, 2024
76 of 81 checks passed
@kdy1 kdy1 deleted the kdy1/swc-core-0-90-10 branch April 11, 2024 00:09
sokra added a commit that referenced this pull request Apr 11, 2024
sokra added a commit that referenced this pull request Apr 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants