BREAKING CHANGE: remove deprecated analyticsId from config, and the corresponding performance-relayer files and tests

[feugy]

🤔 What's in there?

We've deprecated config's analyticsId in 14.1.1 almost 3 months ago.
Users can opt in fot @vercel/speed-insights, or use useReportWebVitals to report to any provider they'd like.

This PR:

• removes analyticsId key from configuration
• stops setting __NEXT_PUBLIC_ANALYTICS_ID env variable when the key was present
• stops injecting performance-relayer file, when the variable is set
• cleans up related test code.

[ijjk]

Failing test suites

Commit: 1ebeb4a

pnpm test-dev test/e2e/app-dir/navigation/navigation.test.ts

• app dir - navigation > navigating to dynamic params & changing the casing > should load the page correctly

Expand output

● app dir - navigation › navigating to dynamic params & changing the casing › should load the page correctly

expect(received).toContain(expected) // indexOf

Expected substring: "[paramB] page"
Received string:    "/paramA/paramB
/paramA/noParam"

  894 |
  895 |         await retry(async () => {
> 896 |           expect(await browser.elementByCss('body').text()).toContain(
      |                                                             ^
  897 |             '[paramB] page'
  898 |           )
  899 |         })

  at toContain (e2e/app-dir/navigation/navigation.test.ts:896:61)
  at retry (lib/next-test-utils.ts:730:14)
  at Object.<anonymous> (e2e/app-dir/navigation/navigation.test.ts:895:9)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	feugy/next.js damien/aly-1257-remove-speed-insights-from-nextjs	Change
buildDuration	17.5s	17.6s	N/A
buildDurationCached	9.6s	8.1s	N/A
nodeModulesSize	199 MB	199 MB	N/A
nextStartRea..uration (ms)	449ms	465ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	feugy/next.js damien/aly-1257-remove-speed-insights-from-nextjs	Change
2453-HASH.js gzip	31.4 kB	31.4 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	✓
8299-HASH.js gzip	5.1 kB	5.1 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	242 B	242 B	✓
main-HASH.js gzip	32.2 kB	29.6 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	99.3 kB	99.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	feugy/next.js damien/aly-1257-remove-speed-insights-from-nextjs	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	feugy/next.js damien/aly-1257-remove-speed-insights-from-nextjs	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.27 kB	4.27 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.63 kB	6.63 kB	✓

Client Build Manifests

	vercel/next.js canary	feugy/next.js damien/aly-1257-remove-speed-insights-from-nextjs	Change
_buildManifest.js gzip	483 B	485 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	feugy/next.js damien/aly-1257-remove-speed-insights-from-nextjs	Change
index.html gzip	530 B	528 B	N/A
link.html gzip	542 B	541 B	N/A
withRouter.html gzip	525 B	523 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	feugy/next.js damien/aly-1257-remove-speed-insights-from-nextjs	Change
edge-ssr.js gzip	95.6 kB	95.6 kB	N/A
page.js gzip	3.06 kB	3.05 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	feugy/next.js damien/aly-1257-remove-speed-insights-from-nextjs	Change
middleware-b..fest.js gzip	625 B	624 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	839 B	839 B	✓

Next Runtimes

	vercel/next.js canary	feugy/next.js damien/aly-1257-remove-speed-insights-from-nextjs	Change
app-page-exp...dev.js gzip	171 kB	171 kB	✓
app-page-exp..prod.js gzip	97.4 kB	97.4 kB	✓
app-page-tur..prod.js gzip	99.2 kB	99.2 kB	✓
app-page-tur..prod.js gzip	93.4 kB	93.4 kB	✓
app-page.run...dev.js gzip	144 kB	144 kB	✓
app-page.run..prod.js gzip	91.9 kB	91.9 kB	✓
app-route-ex...dev.js gzip	21.4 kB	21.4 kB	✓
app-route-ex..prod.js gzip	15.2 kB	15.2 kB	✓
app-route-tu..prod.js gzip	15.2 kB	15.2 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route.ru...dev.js gzip	21.1 kB	21.1 kB	✓
app-route.ru..prod.js gzip	14.9 kB	14.9 kB	✓
pages-api-tu..prod.js gzip	9.55 kB	9.55 kB	✓
pages-api.ru...dev.js gzip	9.82 kB	9.82 kB	✓
pages-api.ru..prod.js gzip	9.55 kB	9.55 kB	✓
pages-turbo...prod.js gzip	22.5 kB	22.5 kB	✓
pages.runtim...dev.js gzip	23.1 kB	23.1 kB	✓
pages.runtim..prod.js gzip	22.5 kB	22.5 kB	✓
server.runti..prod.js gzip	51.3 kB	51.3 kB	✓
Overall change	948 kB	948 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	feugy/next.js damien/aly-1257-remove-speed-insights-from-nextjs	Change
0.pack gzip	1.58 MB	1.58 MB	⚠️ +447 B
index.pack gzip	107 kB	107 kB	⚠️ +200 B
Overall change	1.69 MB	1.69 MB	⚠️ +647 B

Diff details

Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 2453-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: 1ebeb4a

[philwolstenholme]

Our CSP will be happy about this change 😁 (no more auto-injected script from the Vercel third-party origin that we no longer allow in the CSP since we switched to the first-party @vercel/speed-insights package!