forward missing server actions to valid worker if one exists

[ztanner]

What

When submitting a server action on a page that doesn't import the action handler, a "Failed to find server action" error is thrown, even if there's a valid handler for it elsewhere.

Why

Workers for a particular server action ID are keyed by their page entrypoints, and the client router invokes the current page when triggering a server action, since it assumes it's available on the current page. If an action is invoked after the router has moved away from a page that can handle the action, then the action wouldn't run and an error would be thrown in the server console.

How

We try to find a valid worker to forward the action to, if one exists. Otherwise it'll fallback to the usual error handling. This also adds a header to opt out of rendering the flight tree, as if the action calls a revalidate API, then it'll return a React tree corresponding with the wrong page.

Fixes #61918
Fixes #63915

Closes NEXT-2489

[ztanner]

• forward missing server actions to valid worker if one exists #64227 👈
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ztanner and the rest of your teammates on Graphite

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 04-08-forward_missing_server_actions_to_valid_worker_if_one_exists	Change
buildDuration	14.1s	13.9s	N/A
buildDurationCached	7.5s	6.2s	N/A
nodeModulesSize	199 MB	199 MB	⚠️ +183 kB
nextStartRea..uration (ms)	403ms	401ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 04-08-forward_missing_server_actions_to_valid_worker_if_one_exists	Change
2453-HASH.js gzip	31.4 kB	31.4 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	✓
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	242 B	243 B	N/A
main-HASH.js gzip	32.2 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	99 kB	99 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 04-08-forward_missing_server_actions_to_valid_worker_if_one_exists	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 04-08-forward_missing_server_actions_to_valid_worker_if_one_exists	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.21 kB	4.21 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.57 kB	6.57 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 04-08-forward_missing_server_actions_to_valid_worker_if_one_exists	Change
_buildManifest.js gzip	481 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 04-08-forward_missing_server_actions_to_valid_worker_if_one_exists	Change
index.html gzip	529 B	528 B	N/A
link.html gzip	541 B	541 B	✓
withRouter.html gzip	524 B	522 B	N/A
Overall change	541 B	541 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 04-08-forward_missing_server_actions_to_valid_worker_if_one_exists	Change
edge-ssr.js gzip	95.4 kB	95.4 kB	N/A
page.js gzip	3.06 kB	3.06 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 04-08-forward_missing_server_actions_to_valid_worker_if_one_exists	Change
middleware-b..fest.js gzip	627 B	626 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 04-08-forward_missing_server_actions_to_valid_worker_if_one_exists	Change
app-page-exp...dev.js gzip	170 kB	170 kB	⚠️ +321 B
app-page-exp..prod.js gzip	97 kB	97.3 kB	⚠️ +321 B
app-page-tur..prod.js gzip	98.8 kB	99.1 kB	⚠️ +323 B
app-page-tur..prod.js gzip	93 kB	93.3 kB	⚠️ +314 B
app-page.run...dev.js gzip	144 kB	144 kB	⚠️ +327 B
app-page.run..prod.js gzip	91.5 kB	91.8 kB	⚠️ +321 B
app-route-ex...dev.js gzip	21.4 kB	21.4 kB	✓
app-route-ex..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route.ru...dev.js gzip	21.1 kB	21.1 kB	✓
app-route.ru..prod.js gzip	14.9 kB	14.9 kB	✓
pages-api-tu..prod.js gzip	9.55 kB	9.55 kB	✓
pages-api.ru...dev.js gzip	9.82 kB	9.82 kB	✓
pages-api.ru..prod.js gzip	9.55 kB	9.55 kB	✓
pages-turbo...prod.js gzip	22.5 kB	22.5 kB	✓
pages.runtim...dev.js gzip	23.1 kB	23.1 kB	✓
pages.runtim..prod.js gzip	22.4 kB	22.4 kB	✓
server.runti..prod.js gzip	51.1 kB	51.1 kB	N/A
Overall change	894 kB	896 kB	⚠️ +1.93 kB

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 04-08-forward_missing_server_actions_to_valid_worker_if_one_exists	Change
0.pack gzip	1.59 MB	1.58 MB	N/A
index.pack gzip	106 kB	107 kB	⚠️ +304 B
Overall change	106 kB	107 kB	⚠️ +304 B

Diff details

Diff for middleware.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

failed to diff

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: fa4144a

[ijjk]

Tests Passed

[shuding]

Looks great and the comments make it very clear, thanks!