Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): blog-starter <Link> href, remove redundant public folder #65025

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

symant233
Copy link
Contributor

Updating Examples (blog-starter)

  • Remove redundant public folder in src.
  • Fix <Link> href.

Why?

<Link as={`/posts/${slug}`} href="/posts/[slug]" aria-label={title}>

When deploy using static exports, href="/posts/[slug]" will result in a wrong request to /posts/[slug].txt.

@symant233 symant233 requested review from manovotny and leerob and removed request for a team April 25, 2024 04:43
@ijjk ijjk added the examples Issue/PR related to examples label Apr 25, 2024
@ijjk
Copy link
Member

ijjk commented Apr 25, 2024

Allow CI Workflow Run

  • approve CI run for commit: a861d1d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx enabled auto-merge (squash) April 25, 2024 18:39
@samcx samcx merged commit 9c5ac47 into vercel:canary Apr 25, 2024
33 checks passed
@symant233 symant233 deleted the dev branch April 26, 2024 05:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants