Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove ineffective webpack rules and unused app-page context modules" #65558

Merged
merged 1 commit into from May 9, 2024
Merged

Revert "Remove ineffective webpack rules and unused app-page context modules" #65558

merged 1 commit into from May 9, 2024
+44 −11

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 9, 2024

Reverts #65321

Missed covering api layer, got reported with below error. Revert it for now and will re-land it with more tests

../../node_modules/.pnpm/next@14.3.0-canary.51_@opentelemetry+api@1.7.0_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/client/components/navigation.js
02:23:13
Module not found: shared-runtime module app-router-context cannot be used in api layer
02:23:13
https://nextjs.org/docs/messages/module-not-found

@linear Linear
Copy link

linear bot commented May 9, 2024

Issue reopened: NEXT-3312 Remove ineffective webpack rules and unused app-page context modules

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 9, 2024
@huozhi huozhi requested a review from sokra May 9, 2024 07:43
@huozhi huozhi merged commit 9ee7d7f into canary May 9, 2024
63 of 77 checks passed
@huozhi huozhi deleted the revert-65321-refactor/remove-unused-logic branch May 9, 2024 07:45
huozhi added a commit that referenced this pull request May 13, 2024
@huozhi
Revert "Revert "Remove ineffective webpack rules and unused app-page …
837f7da 
…context modules" (#65558)"

This reverts commit 9ee7d7f.
@huozhi huozhi mentioned this pull request May 13, 2024
Merged
huozhi added a commit that referenced this pull request May 13, 2024
@huozhi
Reland Remove ineffective webpack rules and unused app-page context m…
186afe9 
…odules (#65694)

Reland #65321 

Added a test to make sure this change will not fail in `pages/api` like
the error mentioned in #65558
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
@huozhi @panteliselef
Reland Remove ineffective webpack rules and unused app-page context m…
1ed59be 
…odules (vercel#65694)

Reland vercel#65321 

Added a test to make sure this change will not fail in `pages/api` like
the error mentioned in vercel#65558
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

@sokra sokra Awaiting requested review from sokra

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huozhi @ijjk