Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont prefetch with debug mode #6895

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Dont prefetch with debug mode #6895

merged 3 commits into from
Apr 4, 2019

Conversation

dav-is
Copy link
Contributor

@dav-is dav-is commented Apr 4, 2019

When we are running in debug mode, we shouldn't prefetch pages

ijjk
ijjk previously approved these changes Apr 4, 2019
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary zeit/next.js dont-prefetch-experimental-debug Change
Build Duration 13.2s 12.6s -628ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +226 B
Total Bundle (main, webpack, commons) Size 208 kB 208 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.32 kB 1.32 kB ✓
Build Dir Size 345 kB 345 kB ✓
Click to expand serverless stats
zeit/next.js canary zeit/next.js dont-prefetch-experimental-debug Change
Build Duration 17s 16.5s -504ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +226 B
Total Bundle (main, webpack, commons) Size 208 kB 208 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 226 kB 226 kB ✓
Serverless pages/link gzip Size 59.1 kB 59.1 kB -4 B
Serverless pages/index Size 221 kB 221 kB ✓
Serverless pages/index gzip Size 58 kB 58 kB -2 B
Serverless pages/_error Size 222 kB 222 kB ✓
Serverless pages/_error gzip Size 57.9 kB 57.9 kB -2 B
Serverless pages/routerDirect Size 221 kB 221 kB ✓
Serverless pages/routerDirect gzip Size 58 kB 58 kB -2 B
Serverless pages/withRouter Size 221 kB 221 kB ✓
Serverless pages/withRouter gzip Size 58 kB 58 kB -4 B
Build Dir Size 1.33 MB 1.33 MB ✓

Timer
Timer requested changes Apr 4, 2019
View reviewed changes
packages/next/client/page-loader.js Outdated Show resolved Hide resolved
@Timer Timer dismissed ijjk’s stale review April 4, 2019 20:02

slack convo

@dav-is dav-is requested a review from Timer April 4, 2019 20:05
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary zeit/next.js dont-prefetch-experimental-debug Change
Build Duration 14.5s 13.4s -1.1s
node_modules Size 43.9 MB 43.9 MB -205 B
Total Bundle (main, webpack, commons) Size 208 kB 208 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.32 kB 1.32 kB ✓
Build Dir Size 345 kB 345 kB ✓
Click to expand serverless stats
zeit/next.js canary zeit/next.js dont-prefetch-experimental-debug Change
Build Duration 18.3s 17.9s -378ms
node_modules Size 43.9 MB 43.9 MB -205 B
Total Bundle (main, webpack, commons) Size 208 kB 208 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 226 kB 226 kB -92 B
Serverless pages/link gzip Size 59.2 kB 59.1 kB -99 B
Serverless pages/index Size 221 kB 221 kB -90 B
Serverless pages/index gzip Size 58 kB 58 kB -44 B
Serverless pages/_error Size 222 kB 222 kB -58 B
Serverless pages/_error gzip Size 58 kB 57.9 kB -77 B
Serverless pages/routerDirect Size 221 kB 221 kB -88 B
Serverless pages/routerDirect gzip Size 58 kB 58 kB -36 B
Serverless pages/withRouter Size 221 kB 221 kB -90 B
Serverless pages/withRouter gzip Size 58 kB 58 kB -48 B
Build Dir Size 1.33 MB 1.33 MB -418 B

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary zeit/next.js dont-prefetch-experimental-debug Change
Build Duration 14s 13.1s -917ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +226 B
Total Bundle (main, webpack, commons) Size 208 kB 208 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.32 kB 1.32 kB ✓
Build Dir Size 345 kB 345 kB ✓
Click to expand serverless stats
zeit/next.js canary zeit/next.js dont-prefetch-experimental-debug Change
Build Duration 18s 17.7s -317ms
node_modules Size 43.9 MB 43.9 MB ⚠️ +226 B
Total Bundle (main, webpack, commons) Size 208 kB 208 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 226 kB 226 kB ✓
Serverless pages/link gzip Size 59.2 kB 59.2 kB -2 B
Serverless pages/index Size 221 kB 221 kB ✓
Serverless pages/index gzip Size 58 kB 58 kB -4 B
Serverless pages/_error Size 222 kB 222 kB ✓
Serverless pages/_error gzip Size 58 kB 58 kB -2 B
Serverless pages/routerDirect Size 221 kB 221 kB ✓
Serverless pages/routerDirect gzip Size 58 kB 58 kB -4 B
Serverless pages/withRouter Size 221 kB 221 kB ✓
Serverless pages/withRouter gzip Size 58 kB 58 kB -3 B
Build Dir Size 1.33 MB 1.33 MB ✓

@dav-is dav-is merged commit 899f21f into canary Apr 4, 2019
@dav-is dav-is deleted the dont-prefetch-experimental-debug branch April 4, 2019 20:17
@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@leo leo leo approved these changes

@ijjk ijjk ijjk left review comments

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dav-is @Timer @leo @ijjk