Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use var as libraryTarget #6945

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Apr 8, 2019

By using var we opt-out of the LibraryTemplatePlugin. Considering we have our own loader for registering pages this makes sense.

https://github.com/webpack/webpack/blob/7ed1a8f/lib/WebpackOptionsApply.js#L196-L204

By using `var` we opt-out of the LibraryTemplatePlugin. Considering we have our own loader for registering pages this makes sense.
@timneutkens timneutkens changed the title Add babel-plugin-transform-async-to-promises Use var as libraryTarget Apr 8, 2019
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js fix/use-var-librarytarget Change
Build Duration 12.9s 12.3s -648ms
node_modules Size 44 MB 44 MB ⚠️ +24 B
Total Bundle (main, webpack, commons) Size 202 kB 202 kB
Total Bundle (main, webpack, commons) gzip Size 66.3 kB 66.3 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 8.85 kB 8.85 kB
Client _error gzip Size 3.31 kB 3.31 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.6 kB 24.6 kB
Client main gzip Size 8.03 kB 8.03 kB
Client commons Size 175 kB 175 kB
Client commons gzip Size 57 kB 57 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 340 kB 340 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js fix/use-var-librarytarget Change
Build Duration 16.7s 17s ⚠️ +321ms
node_modules Size 44 MB 44 MB ⚠️ +24 B
Total Bundle (main, webpack, commons) Size 202 kB 202 kB
Total Bundle (main, webpack, commons) gzip Size 66.3 kB 66.3 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 8.85 kB 8.85 kB
Client _error gzip Size 3.31 kB 3.31 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.6 kB 24.6 kB
Client main gzip Size 8.03 kB 8.03 kB
Client commons Size 175 kB 175 kB
Client commons gzip Size 57 kB 57 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 223 kB 223 kB
Serverless pages/link gzip Size 58.8 kB 58.8 kB ⚠️ +2 B
Serverless pages/index Size 218 kB 218 kB
Serverless pages/index gzip Size 57.6 kB 57.6 kB
Serverless pages/_error Size 220 kB 220 kB
Serverless pages/_error gzip Size 57.5 kB 57.5 kB ⚠️ +2 B
Serverless pages/routerDirect Size 219 kB 219 kB
Serverless pages/routerDirect gzip Size 57.6 kB 57.6 kB ⚠️ +1 B
Serverless pages/withRouter Size 219 kB 219 kB
Serverless pages/withRouter gzip Size 57.6 kB 57.6 kB ⚠️ +1 B
Build Dir Size 1.32 MB 1.32 MB

@timneutkens timneutkens merged commit da02f57 into vercel:canary Apr 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
@timneutkens timneutkens deleted the fix/use-var-librarytarget branch February 12, 2021 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant