Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decommission old flying shuttles #7299

Merged
merged 3 commits into from May 10, 2019
Merged

Decommission old flying shuttles #7299

merged 3 commits into from May 10, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented May 10, 2019

This pull request prunes the oldest flying shuttle once 4 are exceeded. The choice of 4 is arbitrary.

@Timer Timer changed the title Retire old flying shuttles Decommission old flying shuttles May 10, 2019
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js fs-prune Change
Build Duration 15.2s 14.8s -338ms
node_modules Size 40 MB 40 MB ⚠️ +2.93 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ⚠️ +1 B
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.11 kB 3.12 kB ⚠️ +1 B
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ⚠️ +1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 801 kB 801 kB ✓
Click to expand serverless stats
zeit/next.js canary Timer/next.js fs-prune Change
Build Duration 15.9s 16.2s ⚠️ +238ms
node_modules Size 40 MB 40 MB ⚠️ +2.93 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ⚠️ +1 B
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.11 kB 3.12 kB ⚠️ +1 B
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ⚠️ +1 B
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 342 kB 342 kB ✓
Serverless pages/link gzip Size 88.7 kB 88.7 kB ⚠️ +4 B
Serverless pages/index Size 333 kB 333 kB ✓
Serverless pages/index gzip Size 86.3 kB 86.3 kB ⚠️ +1 B
Serverless pages/_error Size 334 kB 334 kB ✓
Serverless pages/_error gzip Size 86.1 kB 86.1 kB ⚠️ +1 B
Serverless pages/routerDirect Size 333 kB 333 kB ✓
Serverless pages/routerDirect gzip Size 86.3 kB 86.3 kB ⚠️ +1 B
Serverless pages/withRouter Size 333 kB 333 kB ✓
Serverless pages/withRouter gzip Size 86.4 kB 86.4 kB ⚠️ +4 B
Build Dir Size 2.37 MB 2.37 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js fs-prune Change
Build Duration 16.4s 16.4s -15ms
node_modules Size 40 MB 40 MB ⚠️ +2.93 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ✓
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 801 kB 801 kB ✓
Click to expand serverless stats
zeit/next.js canary Timer/next.js fs-prune Change
Build Duration 17.6s 17.9s ⚠️ +270ms
node_modules Size 40 MB 40 MB ⚠️ +2.93 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ✓
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 342 kB 342 kB ✓
Serverless pages/link gzip Size 88.7 kB 88.7 kB ✓
Serverless pages/index Size 333 kB 333 kB ✓
Serverless pages/index gzip Size 86.3 kB 86.3 kB ✓
Serverless pages/_error Size 334 kB 334 kB ✓
Serverless pages/_error gzip Size 86.1 kB 86.1 kB ✓
Serverless pages/routerDirect Size 333 kB 333 kB ✓
Serverless pages/routerDirect gzip Size 86.3 kB 86.3 kB ⚠️ +1 B
Serverless pages/withRouter Size 333 kB 333 kB ✓
Serverless pages/withRouter gzip Size 86.4 kB 86.4 kB ⚠️ +1 B
Build Dir Size 2.37 MB 2.37 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js fs-prune Change
Build Duration 15.2s 15s -221ms
node_modules Size 40 MB 40 MB ⚠️ +2.93 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ✓
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 801 kB 801 kB ✓
Click to expand serverless stats
zeit/next.js canary Timer/next.js fs-prune Change
Build Duration 16.4s 16.7s ⚠️ +329ms
node_modules Size 40 MB 40 MB ⚠️ +2.93 kB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB ✓
Client _app Size 2.54 kB 2.54 kB ✓
Client _app gzip Size 1.05 kB 1.05 kB ✓
Client _error Size 8.19 kB 8.19 kB ✓
Client _error gzip Size 3.12 kB 3.12 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.83 kB 4.83 kB ✓
Client pages/link gzip Size 2.11 kB 2.11 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 23.3 kB 23.3 kB ✓
Client main gzip Size 7.63 kB 7.63 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.4 kB 59.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 342 kB 342 kB ✓
Serverless pages/link gzip Size 88.7 kB 88.7 kB -1 B
Serverless pages/index Size 333 kB 333 kB ✓
Serverless pages/index gzip Size 86.3 kB 86.3 kB -1 B
Serverless pages/_error Size 334 kB 334 kB ✓
Serverless pages/_error gzip Size 86.1 kB 86.1 kB ⚠️ +1 B
Serverless pages/routerDirect Size 333 kB 333 kB ✓
Serverless pages/routerDirect gzip Size 86.3 kB 86.3 kB ✓
Serverless pages/withRouter Size 333 kB 333 kB ✓
Serverless pages/withRouter gzip Size 86.4 kB 86.4 kB -2 B
Build Dir Size 2.37 MB 2.37 MB ✓

@Timer Timer merged commit f533c55 into vercel:canary May 10, 2019
@Timer Timer deleted the fs-prune branch May 10, 2019 15:38
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timer @ijjk