Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update handling of ref in next/link #8254

Merged
merged 2 commits into from Aug 8, 2019
Merged

Update handling of ref in next/link #8254

merged 2 commits into from Aug 8, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 5, 2019 •
edited

Continuation of #8007 This requires that functional components that are used as children of next/link are wrapped in React.forwardRef

Relevant links:
https://reactjs.org/docs/forwarding-refs.html#note-for-component-library-maintainers
facebook/react#13029 (comment)

Fixes: #7915
Fixes: #7852

@ijjk
Copy link
Member Author

ijjk commented Aug 5, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js link-ref-handling Change
Build Duration 13.4s 13.2s -173ms
node_modules Size 43.6 MB 43.6 MB ⚠️ +561 B
Total Bundle (main, webpack, commons) Size 206 kB 206 kB ✓
Total Bundle (main, webpack, commons) gzip Size 67.8 kB 67.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.22 kB 8.22 kB ✓
Client _error gzip Size 3.16 kB 3.16 kB ✓
Client pages/index Size 343 B 343 B ✓
Client pages/index gzip Size 246 B 246 B ✓
Client pages/link Size 4.08 kB 4.18 kB ⚠️ +104 B
Client pages/link gzip Size 1.8 kB 1.82 kB ⚠️ +26 B
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client main Size 15.4 kB 15.4 kB ✓
Client main gzip Size 5.35 kB 5.35 kB ✓
Client commons Size 188 kB 188 kB ✓
Client commons gzip Size 61.1 kB 61.1 kB ✓
Client webpack Size 1.53 kB 1.53 kB ✓
Client webpack gzip Size 778 B 778 B ✓
Base Rendered Size 1.35 kB 1.35 kB ✓
Build Dir Size 702 kB 703 kB ⚠️ +947 B
Click to expand serverless stats
zeit/next.js canary ijjk/next.js link-ref-handling Change
Build Duration 14.2s 14.2s -21ms
node_modules Size 43.6 MB 43.6 MB ⚠️ +561 B
Total Bundle (main, webpack, commons) Size 206 kB 206 kB ✓
Total Bundle (main, webpack, commons) gzip Size 67.8 kB 67.8 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.22 kB 8.22 kB ✓
Client _error gzip Size 3.16 kB 3.16 kB ✓
Client pages/index Size 343 B 343 B ✓
Client pages/index gzip Size 246 B 246 B ✓
Client pages/link Size 4.08 kB 4.18 kB ⚠️ +104 B
Client pages/link gzip Size 1.8 kB 1.82 kB ⚠️ +26 B
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client main Size 15.4 kB 15.4 kB ✓
Client main gzip Size 5.35 kB 5.35 kB ✓
Client commons Size 188 kB 188 kB ✓
Client commons gzip Size 61.1 kB 61.1 kB ✓
Client webpack Size 1.53 kB 1.53 kB ✓
Client webpack gzip Size 778 B 778 B ✓
Serverless pages/link Size 251 kB 251 kB ⚠️ +245 B
Serverless pages/link gzip Size 67.8 kB 67.9 kB ⚠️ +54 B
Serverless pages/index Size 244 kB 244 kB ✓
Serverless pages/index gzip Size 65.6 kB 65.6 kB -1 B
Serverless pages/_error Size 243 kB 243 kB ✓
Serverless pages/_error gzip Size 65.4 kB 65.4 kB -1 B
Serverless pages/routerDirect Size 244 kB 244 kB ✓
Serverless pages/routerDirect gzip Size 65.6 kB 65.6 kB ✓
Serverless pages/withRouter Size 244 kB 244 kB ✓
Serverless pages/withRouter gzip Size 65.7 kB 65.7 kB -1 B
Build Dir Size 1.89 MB 1.89 MB ⚠️ +947 B

@ijjk
Copy link
Member Author

ijjk commented Aug 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js link-ref-handling Change
Build Duration 24.5s 23.7s -798ms
node_modules Size 43.6 MB 43.6 MB ⚠️ +580 B
Total Bundle (main, webpack, commons) Size 206 kB 206 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ✓
Total Bundle (main, webpack, commons) Modern Size 181 kB 181 kB ✓
Total Bundle (main, webpack, commons) Modern gzip Size 59.9 kB 59.9 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _app Modern Size 1.83 kB 1.83 kB ✓
Client _app gzip Modern Size 890 B 890 B ✓
Client _error Size 8.22 kB 8.22 kB ✓
Client _error gzip Size 3.16 kB 3.16 kB ✓
Client _error Modern Size 5.85 kB 5.85 kB ✓
Client _error gzip Modern Size 2.33 kB 2.33 kB ✓
Client pages/index Size 343 B 343 B ✓
Client pages/index gzip Size 246 B 246 B ✓
Client pages/index Modern Size 319 B 319 B ✓
Client pages/index gzip Modern Size 254 B 254 B ✓
Client pages/link Size 4.08 kB 4.18 kB ⚠️ +104 B
Client pages/link gzip Size 1.8 kB 1.82 kB ⚠️ +26 B
Client pages/link Modern Size 3.7 kB 3.81 kB ⚠️ +113 B
Client pages/link gzip Modern Size 1.7 kB 1.72 kB ⚠️ +28 B
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/routerDirect Modern Size 411 B 411 B ✓
Client pages/routerDirect gzip Modern Size 314 B 314 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client pages/withRouter Modern Size 423 B 423 B ✓
Client pages/withRouter gzip Modern Size 309 B 309 B ✓
Client main Size 15.6 kB 15.6 kB ✓
Client main gzip Size 5.5 kB 5.5 kB ✓
Client main Modern Size 12.4 kB 12.4 kB ✓
Client main Modern gzip Size 4.78 kB 4.78 kB ✓
Client commons Size 188 kB 188 kB ✓
Client commons gzip Size 61.3 kB 61.3 kB ✓
Client commons Modern Size 169 kB 169 kB ✓
Client commons Modern gzip Size 55.1 kB 55.1 kB ✓
Client webpack Size 1.53 kB 1.53 kB ✓
Client webpack gzip Size 778 B 778 B ✓
Client webpack Modern Size 1.53 kB 1.53 kB ✓
Client webpack Modern gzip Size 785 B 785 B ✓
Base Rendered Size 2.76 kB 2.76 kB ✓
Build Dir Size 1.39 MB 1.39 MB ⚠️ +1.55 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js link-ref-handling Change
Build Duration 25.8s 25.1s -648ms
node_modules Size 43.6 MB 43.6 MB ⚠️ +580 B
Total Bundle (main, webpack, commons) Size 206 kB 206 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB -2 B
Total Bundle (main, webpack, commons) Modern Size 181 kB 181 kB ✓
Total Bundle (main, webpack, commons) Modern gzip Size 59.9 kB 59.9 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB -1 B
Client _app Modern Size 1.83 kB 1.83 kB ✓
Client _app gzip Modern Size 890 B 890 B ✓
Client _error Size 8.22 kB 8.22 kB ✓
Client _error gzip Size 3.16 kB 3.16 kB ✓
Client _error Modern Size 5.85 kB 5.85 kB ✓
Client _error gzip Modern Size 2.33 kB 2.33 kB ✓
Client pages/index Size 343 B 343 B ✓
Client pages/index gzip Size 246 B 246 B ✓
Client pages/index Modern Size 319 B 319 B ✓
Client pages/index gzip Modern Size 254 B 254 B ✓
Client pages/link Size 4.08 kB 4.18 kB ⚠️ +104 B
Client pages/link gzip Size 1.8 kB 1.82 kB ⚠️ +26 B
Client pages/link Modern Size 3.7 kB 3.81 kB ⚠️ +113 B
Client pages/link gzip Modern Size 1.7 kB 1.72 kB ⚠️ +27 B
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/routerDirect Modern Size 411 B 411 B ✓
Client pages/routerDirect gzip Modern Size 314 B 314 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 300 B -1 B
Client pages/withRouter Modern Size 423 B 423 B ✓
Client pages/withRouter gzip Modern Size 309 B 309 B ✓
Client main Size 15.6 kB 15.6 kB ✓
Client main gzip Size 5.5 kB 5.5 kB -1 B
Client main Modern Size 12.4 kB 12.4 kB ✓
Client main Modern gzip Size 4.78 kB 4.78 kB ✓
Client commons Size 188 kB 188 kB ✓
Client commons gzip Size 61.3 kB 61.3 kB ✓
Client commons Modern Size 169 kB 169 kB ✓
Client commons Modern gzip Size 55.1 kB 55.1 kB ✓
Client webpack Size 1.53 kB 1.53 kB ✓
Client webpack gzip Size 778 B 778 B ✓
Client webpack Modern Size 1.53 kB 1.53 kB ✓
Client webpack Modern gzip Size 785 B 785 B ✓
Serverless pages/link Size 255 kB 255 kB ⚠️ +245 B
Serverless pages/link gzip Size 68.6 kB 68.6 kB ⚠️ +52 B
Serverless pages/index Size 248 kB 248 kB ✓
Serverless pages/index gzip Size 66.4 kB 66.4 kB ✓
Serverless pages/_error Size 247 kB 247 kB ✓
Serverless pages/_error gzip Size 66.1 kB 66.1 kB ⚠️ +1 B
Serverless pages/routerDirect Size 248 kB 248 kB ✓
Serverless pages/routerDirect gzip Size 66.3 kB 66.3 kB ✓
Serverless pages/withRouter Size 248 kB 248 kB ✓
Serverless pages/withRouter gzip Size 66.4 kB 66.4 kB -1 B
Build Dir Size 2.6 MB 2.6 MB ⚠️ +1.55 kB

@ijjk ijjk merged commit a4889f9 into vercel:canary Aug 8, 2019
@ijjk ijjk deleted the link-ref-handling branch August 8, 2019 18:11
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ijjk @lfades