better type for AppTree in NextPageContext #8662

fwojciec · 2019-09-06T21:26:20Z

This is intended to fix #8656

ijjk

Hi, thanks for the PR! Could you update the test file here and update this one to be a tsx file? This should help ensure the type is correct this time

ijjk · 2019-09-06T21:33:24Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	21.9s	21.7s	-197ms
nodeModulesSize	42.4 MB	42.4 MB	⚠️ +122 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
2e64a46864d6..2b8407376.js	21.9 kB	N/A	N/A
2e64a46864d6..7376.js gzip	7.81 kB	N/A	N/A
916ed6d3b068..799a4e38e.js	43.1 kB	N/A	N/A
916ed6d3b068..e38e.js gzip	15.4 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
de58c015474e..799a4e38e.js	N/A	43.1 kB	N/A
de58c015474e..e38e.js gzip	N/A	15.4 kB	N/A
e61fad048350..2b8407376.js	N/A	21.9 kB	N/A
e61fad048350..7376.js gzip	N/A	7.81 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
916ed6d3b068..f0.module.js	45.5 kB	N/A	N/A
916ed6d3b068..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
de58c015474e..f0.module.js	N/A	45.5 kB	N/A
de58c015474e..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	fwojciec/next.js canary	Change
index.html	3.75 kB	3.75 kB	✓
index.html gzip	958 B	958 B	✓
link.html	3.79 kB	3.79 kB	✓
link.html gzip	967 B	966 B	-1 B
withRouter.html	3.8 kB	3.8 kB	✓
withRouter.html gzip	954 B	953 B	-1 B
Overall change	11.3 kB	11.3 kB	✓

Diffs

Diff for index.html

@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/index.module.js"
+        <link rel="preload" href="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/55317f6b3e301bd73aaef5b06fdbff7737515eec.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/23f1be7fe27a5dd05338e611d23133225223aab2.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/HDiFeohNyvgE9aSQPXM7C/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/R5vUi7V6t_-7cqbhO911b/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"HDiFeohNyvgE9aSQPXM7C"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"R5vUi7V6t_-7cqbhO911b"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/3733b32e93d29aeeb32950f5c46448523266ff4a.155621535702fe040780.js"
+        <script src="/_next/static/chunks/26c1c9cf38e85cfc85d31c710c883f4b8ab868cc.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/55317f6b3e301bd73aaef5b06fdbff7737515eec.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/23f1be7fe27a5dd05338e611d23133225223aab2.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/55317f6b3e301bd73aaef5b06fdbff7737515eec.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/23f1be7fe27a5dd05338e611d23133225223aab2.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/HDiFeohNyvgE9aSQPXM7C/_buildManifest.js"
+        <script src="/_next/static/R5vUi7V6t_-7cqbhO911b/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/HDiFeohNyvgE9aSQPXM7C/_buildManifest.module.js"
+        <script src="/_next/static/R5vUi7V6t_-7cqbhO911b/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for link.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/link.module.js"
+        <link rel="preload" href="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/55317f6b3e301bd73aaef5b06fdbff7737515eec.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/23f1be7fe27a5dd05338e611d23133225223aab2.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/HDiFeohNyvgE9aSQPXM7C/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/R5vUi7V6t_-7cqbhO911b/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"HDiFeohNyvgE9aSQPXM7C"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"R5vUi7V6t_-7cqbhO911b"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/3733b32e93d29aeeb32950f5c46448523266ff4a.155621535702fe040780.js"
+        <script src="/_next/static/chunks/26c1c9cf38e85cfc85d31c710c883f4b8ab868cc.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/55317f6b3e301bd73aaef5b06fdbff7737515eec.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/23f1be7fe27a5dd05338e611d23133225223aab2.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/55317f6b3e301bd73aaef5b06fdbff7737515eec.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/23f1be7fe27a5dd05338e611d23133225223aab2.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/HDiFeohNyvgE9aSQPXM7C/_buildManifest.js"
+        <script src="/_next/static/R5vUi7V6t_-7cqbhO911b/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/HDiFeohNyvgE9aSQPXM7C/_buildManifest.module.js"
+        <script src="/_next/static/R5vUi7V6t_-7cqbhO911b/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for withRouter.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/55317f6b3e301bd73aaef5b06fdbff7737515eec.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/23f1be7fe27a5dd05338e611d23133225223aab2.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/HDiFeohNyvgE9aSQPXM7C/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/R5vUi7V6t_-7cqbhO911b/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"HDiFeohNyvgE9aSQPXM7C"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"R5vUi7V6t_-7cqbhO911b"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/HDiFeohNyvgE9aSQPXM7C/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R5vUi7V6t_-7cqbhO911b/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/3733b32e93d29aeeb32950f5c46448523266ff4a.155621535702fe040780.js"
+        <script src="/_next/static/chunks/26c1c9cf38e85cfc85d31c710c883f4b8ab868cc.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/55317f6b3e301bd73aaef5b06fdbff7737515eec.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/23f1be7fe27a5dd05338e611d23133225223aab2.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/55317f6b3e301bd73aaef5b06fdbff7737515eec.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/23f1be7fe27a5dd05338e611d23133225223aab2.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/HDiFeohNyvgE9aSQPXM7C/_buildManifest.js"
+        <script src="/_next/static/R5vUi7V6t_-7cqbhO911b/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/HDiFeohNyvgE9aSQPXM7C/_buildManifest.module.js"
+        <script src="/_next/static/R5vUi7V6t_-7cqbhO911b/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	21.5s	21.1s	-326ms
nodeModulesSize	42.4 MB	42.4 MB	⚠️ +122 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
0a442af320fd..799a4e38e.js	43.1 kB	N/A	N/A
0a442af320fd..e38e.js gzip	15.4 kB	N/A	N/A
7350312e4c52..2b8407376.js	21.9 kB	N/A	N/A
7350312e4c52..7376.js gzip	7.81 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
f5783ef94262..2b8407376.js	N/A	21.9 kB	N/A
f5783ef94262..7376.js gzip	N/A	7.81 kB	N/A
fcd795dabc10..799a4e38e.js	N/A	43.1 kB	N/A
fcd795dabc10..e38e.js gzip	N/A	15.4 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
0a442af320fd..f0.module.js	45.5 kB	N/A	N/A
0a442af320fd..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
fcd795dabc10..f0.module.js	N/A	45.5 kB	N/A
fcd795dabc10..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	fwojciec/next.js canary	Change
_error.js	247 kB	247 kB	✓
_error.js gzip	66.2 kB	66.2 kB	⚠️ +3 B
hooks.html	3.86 kB	3.86 kB	✓
hooks.html gzip	986 B	983 B	-3 B
index.js	248 kB	248 kB	✓
index.js gzip	66.4 kB	66.5 kB	⚠️ +24 B
link.js	255 kB	255 kB	✓
link.js gzip	68.5 kB	68.6 kB	⚠️ +9 B
routerDirect.js	249 kB	249 kB	✓
routerDirect.js gzip	66.5 kB	66.5 kB	⚠️ +2 B
withRouter.js	249 kB	249 kB	✓
withRouter.js gzip	66.6 kB	66.6 kB	-55 B
Overall change	1.25 MB	1.25 MB	✓

ijjk · 2019-09-06T22:18:15Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	25.7s	24.5s	-1.2s
nodeModulesSize	42.4 MB	42.4 MB	⚠️ +122 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
7eacdf8dab5f..2b8407376.js	21.9 kB	N/A	N/A
7eacdf8dab5f..7376.js gzip	7.81 kB	N/A	N/A
d1872fc2fb3d..799a4e38e.js	43.1 kB	N/A	N/A
d1872fc2fb3d..e38e.js gzip	15.4 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
06ebe1a5e2b5..2b8407376.js	N/A	21.9 kB	N/A
06ebe1a5e2b5..7376.js gzip	N/A	7.81 kB	N/A
7d7c8e6f39d9..799a4e38e.js	N/A	43.1 kB	N/A
7d7c8e6f39d9..e38e.js gzip	N/A	15.4 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
d1872fc2fb3d..f0.module.js	45.5 kB	N/A	N/A
d1872fc2fb3d..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
7d7c8e6f39d9..f0.module.js	N/A	45.5 kB	N/A
7d7c8e6f39d9..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	fwojciec/next.js canary	Change
index.html	3.75 kB	3.75 kB	✓
index.html gzip	959 B	955 B	-4 B
link.html	3.79 kB	3.79 kB	✓
link.html gzip	968 B	965 B	-3 B
withRouter.html	3.8 kB	3.8 kB	✓
withRouter.html gzip	955 B	951 B	-4 B
Overall change	11.3 kB	11.3 kB	✓

Diffs

Diff for index.html

@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/index.module.js"
+        <link rel="preload" href="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/306f4055977da945c467d1bd5c3ede50520eefe3.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/e9664155e672e5b5ff55d1cbe5f0478f0329422f.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/Bz7s249ofd1HgNVIUDEUF/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/O8oj05_XBxXFDefr3kNSY/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"Bz7s249ofd1HgNVIUDEUF"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"O8oj05_XBxXFDefr3kNSY"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/881a2c2b9e2a0ac205625b9c075afcf988cdf418.155621535702fe040780.js"
+        <script src="/_next/static/chunks/659da2f99e474f98b60e03ccd42defd90d45d043.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/306f4055977da945c467d1bd5c3ede50520eefe3.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/e9664155e672e5b5ff55d1cbe5f0478f0329422f.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/306f4055977da945c467d1bd5c3ede50520eefe3.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/e9664155e672e5b5ff55d1cbe5f0478f0329422f.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/Bz7s249ofd1HgNVIUDEUF/_buildManifest.js"
+        <script src="/_next/static/O8oj05_XBxXFDefr3kNSY/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/Bz7s249ofd1HgNVIUDEUF/_buildManifest.module.js"
+        <script src="/_next/static/O8oj05_XBxXFDefr3kNSY/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for link.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/link.module.js"
+        <link rel="preload" href="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/306f4055977da945c467d1bd5c3ede50520eefe3.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/e9664155e672e5b5ff55d1cbe5f0478f0329422f.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/Bz7s249ofd1HgNVIUDEUF/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/O8oj05_XBxXFDefr3kNSY/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"Bz7s249ofd1HgNVIUDEUF"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"O8oj05_XBxXFDefr3kNSY"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/881a2c2b9e2a0ac205625b9c075afcf988cdf418.155621535702fe040780.js"
+        <script src="/_next/static/chunks/659da2f99e474f98b60e03ccd42defd90d45d043.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/306f4055977da945c467d1bd5c3ede50520eefe3.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/e9664155e672e5b5ff55d1cbe5f0478f0329422f.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/306f4055977da945c467d1bd5c3ede50520eefe3.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/e9664155e672e5b5ff55d1cbe5f0478f0329422f.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/Bz7s249ofd1HgNVIUDEUF/_buildManifest.js"
+        <script src="/_next/static/O8oj05_XBxXFDefr3kNSY/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/Bz7s249ofd1HgNVIUDEUF/_buildManifest.module.js"
+        <script src="/_next/static/O8oj05_XBxXFDefr3kNSY/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for withRouter.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/306f4055977da945c467d1bd5c3ede50520eefe3.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/e9664155e672e5b5ff55d1cbe5f0478f0329422f.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/Bz7s249ofd1HgNVIUDEUF/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/O8oj05_XBxXFDefr3kNSY/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"Bz7s249ofd1HgNVIUDEUF"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"O8oj05_XBxXFDefr3kNSY"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/Bz7s249ofd1HgNVIUDEUF/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/O8oj05_XBxXFDefr3kNSY/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/881a2c2b9e2a0ac205625b9c075afcf988cdf418.155621535702fe040780.js"
+        <script src="/_next/static/chunks/659da2f99e474f98b60e03ccd42defd90d45d043.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/306f4055977da945c467d1bd5c3ede50520eefe3.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/e9664155e672e5b5ff55d1cbe5f0478f0329422f.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/306f4055977da945c467d1bd5c3ede50520eefe3.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/e9664155e672e5b5ff55d1cbe5f0478f0329422f.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/Bz7s249ofd1HgNVIUDEUF/_buildManifest.js"
+        <script src="/_next/static/O8oj05_XBxXFDefr3kNSY/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/Bz7s249ofd1HgNVIUDEUF/_buildManifest.module.js"
+        <script src="/_next/static/O8oj05_XBxXFDefr3kNSY/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	25.5s	25.4s	-90ms
nodeModulesSize	42.4 MB	42.4 MB	⚠️ +122 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
603ad8b75df6..2b8407376.js	21.9 kB	N/A	N/A
603ad8b75df6..7376.js gzip	7.81 kB	N/A	N/A
b1aefd17bd04..799a4e38e.js	43.1 kB	N/A	N/A
b1aefd17bd04..e38e.js gzip	15.4 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
2a2eaf62b2e4..799a4e38e.js	N/A	43.1 kB	N/A
2a2eaf62b2e4..e38e.js gzip	N/A	15.4 kB	N/A
c20900210f26..2b8407376.js	N/A	21.9 kB	N/A
c20900210f26..7376.js gzip	N/A	7.81 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
b1aefd17bd04..f0.module.js	45.5 kB	N/A	N/A
b1aefd17bd04..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
2a2eaf62b2e4..f0.module.js	N/A	45.5 kB	N/A
2a2eaf62b2e4..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
_error.js	247 kB	247 kB	✓
_error.js gzip	66.1 kB	66.2 kB	⚠️ +45 B
hooks.html	3.86 kB	3.86 kB	✓
hooks.html gzip	984 B	987 B	⚠️ +3 B
index.js	248 kB	248 kB	-5 B
index.js gzip	66.5 kB	66.4 kB	-85 B
link.js	255 kB	255 kB	-5 B
link.js gzip	68.5 kB	68.5 kB	⚠️ +30 B
routerDirect.js	249 kB	249 kB	-5 B
routerDirect.js gzip	66.6 kB	66.5 kB	-126 B
withRouter.js	249 kB	249 kB	-5 B
withRouter.js gzip	66.5 kB	66.5 kB	⚠️ +41 B
Overall change	1.25 MB	1.25 MB	-20 B

fwojciec · 2019-09-06T22:18:45Z

Done. I only updated the second of the files. My understanding is that the first one only applies to the AppTree passed in the AppContextType and my PR only changes the type of AppTree in the NextPageContext.

If I'm misunderstanding something I'll be happy to make another change.

ijjk

We also want to update the first test file _app.tsx since the AppTree type should be the same in NextPageContext as AppContextType which means we should probably add another type AppTreeType and set it in both of those contexts so that it's the same

ijjk · 2019-09-08T07:48:06Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	23.9s	23.5s	-379ms
nodeModulesSize	42.4 MB	42.4 MB	-64 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
1b372afe8db2..799a4e38e.js	43.1 kB	N/A	N/A
1b372afe8db2..e38e.js gzip	15.4 kB	N/A	N/A
be88b3e6ff9c..2b8407376.js	21.9 kB	N/A	N/A
be88b3e6ff9c..7376.js gzip	7.81 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
1b12652fd126..799a4e38e.js	N/A	43.1 kB	N/A
1b12652fd126..e38e.js gzip	N/A	15.4 kB	N/A
bc451e768ead..2b8407376.js	N/A	21.9 kB	N/A
bc451e768ead..7376.js gzip	N/A	7.81 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
1b372afe8db2..f0.module.js	45.5 kB	N/A	N/A
1b372afe8db2..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
1b12652fd126..f0.module.js	N/A	45.5 kB	N/A
1b12652fd126..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	fwojciec/next.js canary	Change
index.html	3.75 kB	3.75 kB	✓
index.html gzip	958 B	959 B	⚠️ +1 B
link.html	3.79 kB	3.79 kB	✓
link.html gzip	967 B	968 B	⚠️ +1 B
withRouter.html	3.8 kB	3.8 kB	✓
withRouter.html gzip	955 B	954 B	-1 B
Overall change	11.3 kB	11.3 kB	✓

Diffs

Diff for index.html

@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/index.module.js"
+        <link rel="preload" href="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/88bafd921f69a81d84eb0cfb38ffb059ec04ceba.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/761fc9822d59fcdc7ced234e3b98c350c8489ee0.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/-iddH0P_-OzXyGx2r0m8i/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/R0gpYF34gO_xUd3wb0QyD/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"-iddH0P_-OzXyGx2r0m8i"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"R0gpYF34gO_xUd3wb0QyD"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/04d886413c5939ab37087303c65819a518c7ce6c.155621535702fe040780.js"
+        <script src="/_next/static/chunks/7ef2b6e8b9a6eed8179c922bc8923b49f9ebbe56.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/88bafd921f69a81d84eb0cfb38ffb059ec04ceba.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/761fc9822d59fcdc7ced234e3b98c350c8489ee0.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/88bafd921f69a81d84eb0cfb38ffb059ec04ceba.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/761fc9822d59fcdc7ced234e3b98c350c8489ee0.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/-iddH0P_-OzXyGx2r0m8i/_buildManifest.js"
+        <script src="/_next/static/R0gpYF34gO_xUd3wb0QyD/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/-iddH0P_-OzXyGx2r0m8i/_buildManifest.module.js"
+        <script src="/_next/static/R0gpYF34gO_xUd3wb0QyD/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for link.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/link.module.js"
+        <link rel="preload" href="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/88bafd921f69a81d84eb0cfb38ffb059ec04ceba.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/761fc9822d59fcdc7ced234e3b98c350c8489ee0.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/-iddH0P_-OzXyGx2r0m8i/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/R0gpYF34gO_xUd3wb0QyD/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"-iddH0P_-OzXyGx2r0m8i"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"R0gpYF34gO_xUd3wb0QyD"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/04d886413c5939ab37087303c65819a518c7ce6c.155621535702fe040780.js"
+        <script src="/_next/static/chunks/7ef2b6e8b9a6eed8179c922bc8923b49f9ebbe56.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/88bafd921f69a81d84eb0cfb38ffb059ec04ceba.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/761fc9822d59fcdc7ced234e3b98c350c8489ee0.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/88bafd921f69a81d84eb0cfb38ffb059ec04ceba.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/761fc9822d59fcdc7ced234e3b98c350c8489ee0.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/-iddH0P_-OzXyGx2r0m8i/_buildManifest.js"
+        <script src="/_next/static/R0gpYF34gO_xUd3wb0QyD/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/-iddH0P_-OzXyGx2r0m8i/_buildManifest.module.js"
+        <script src="/_next/static/R0gpYF34gO_xUd3wb0QyD/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for withRouter.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/88bafd921f69a81d84eb0cfb38ffb059ec04ceba.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/761fc9822d59fcdc7ced234e3b98c350c8489ee0.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/-iddH0P_-OzXyGx2r0m8i/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/R0gpYF34gO_xUd3wb0QyD/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"-iddH0P_-OzXyGx2r0m8i"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"R0gpYF34gO_xUd3wb0QyD"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/-iddH0P_-OzXyGx2r0m8i/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/R0gpYF34gO_xUd3wb0QyD/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/04d886413c5939ab37087303c65819a518c7ce6c.155621535702fe040780.js"
+        <script src="/_next/static/chunks/7ef2b6e8b9a6eed8179c922bc8923b49f9ebbe56.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/88bafd921f69a81d84eb0cfb38ffb059ec04ceba.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/761fc9822d59fcdc7ced234e3b98c350c8489ee0.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/88bafd921f69a81d84eb0cfb38ffb059ec04ceba.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/761fc9822d59fcdc7ced234e3b98c350c8489ee0.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/-iddH0P_-OzXyGx2r0m8i/_buildManifest.js"
+        <script src="/_next/static/R0gpYF34gO_xUd3wb0QyD/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/-iddH0P_-OzXyGx2r0m8i/_buildManifest.module.js"
+        <script src="/_next/static/R0gpYF34gO_xUd3wb0QyD/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	24.4s	23.5s	-879ms
nodeModulesSize	42.4 MB	42.4 MB	-64 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
5ac55496c4b0..799a4e38e.js	43.1 kB	N/A	N/A
5ac55496c4b0..e38e.js gzip	15.4 kB	N/A	N/A
bbc9356daa41..2b8407376.js	21.9 kB	N/A	N/A
bbc9356daa41..7376.js gzip	7.81 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
1b8d7e138df9..799a4e38e.js	N/A	43.1 kB	N/A
1b8d7e138df9..e38e.js gzip	N/A	15.4 kB	N/A
ccd15cddf713..2b8407376.js	N/A	21.9 kB	N/A
ccd15cddf713..7376.js gzip	N/A	7.81 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
5ac55496c4b0..f0.module.js	45.5 kB	N/A	N/A
5ac55496c4b0..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
1b8d7e138df9..f0.module.js	N/A	45.5 kB	N/A
1b8d7e138df9..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	fwojciec/next.js canary	Change
_error.js	247 kB	247 kB	✓
_error.js gzip	66.1 kB	66.3 kB	⚠️ +169 B
hooks.html	3.86 kB	3.86 kB	✓
hooks.html gzip	983 B	986 B	⚠️ +3 B
index.js	248 kB	248 kB	✓
index.js gzip	66.4 kB	66.5 kB	⚠️ +88 B
link.js	255 kB	255 kB	✓
link.js gzip	68.6 kB	68.6 kB	-23 B
routerDirect.js	249 kB	249 kB	✓
routerDirect.js gzip	66.5 kB	66.6 kB	⚠️ +52 B
withRouter.js	249 kB	249 kB	✓
withRouter.js gzip	66.6 kB	66.5 kB	-76 B
Overall change	1.25 MB	1.25 MB	✓

ijjk · 2019-09-08T07:51:27Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	23.3s	22.7s	-652ms
nodeModulesSize	42.4 MB	42.4 MB	-147 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
1246aa16ca0d..2b8407376.js	21.9 kB	N/A	N/A
1246aa16ca0d..7376.js gzip	7.81 kB	N/A	N/A
34994df4e82a..799a4e38e.js	43.1 kB	N/A	N/A
34994df4e82a..e38e.js gzip	15.4 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
b28b2ffdd535..799a4e38e.js	N/A	43.1 kB	N/A
b28b2ffdd535..e38e.js gzip	N/A	15.4 kB	N/A
d614994565f5..2b8407376.js	N/A	21.9 kB	N/A
d614994565f5..7376.js gzip	N/A	7.81 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
34994df4e82a..f0.module.js	45.5 kB	N/A	N/A
34994df4e82a..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
b28b2ffdd535..f0.module.js	N/A	45.5 kB	N/A
b28b2ffdd535..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	fwojciec/next.js canary	Change
index.html	3.75 kB	3.75 kB	✓
index.html gzip	958 B	959 B	⚠️ +1 B
link.html	3.79 kB	3.79 kB	✓
link.html gzip	966 B	968 B	⚠️ +2 B
withRouter.html	3.8 kB	3.8 kB	✓
withRouter.html gzip	954 B	954 B	✓
Overall change	11.3 kB	11.3 kB	✓

Diffs

Diff for main-HASH.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for main-HASH.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _app.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for _app.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {

Diff for _error.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {

Diff for hooks.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for link.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {

Diff for routerDirect.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {

Diff for withRouter.module.js

@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {

Diff for index.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/SqnwscHNThb4UFixV1z9A/pages/index.module.js"
+        <link rel="preload" href="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/SqnwscHNThb4UFixV1z9A/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-a6b94f6435d872347f43.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/ce8c7e9e966800abb54f0bebe095276c4a7292bd.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/535fd764b96f2a576f34bc0fa7f6c745202e80f8.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/SqnwscHNThb4UFixV1z9A/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/vN52YMC5t-IXdKEdYi5ls/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,40 +26,40 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"SqnwscHNThb4UFixV1z9A"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"vN52YMC5t-IXdKEdYi5ls"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
+        <script src="/_next/static/runtime/main-038a070063ee8517eb2a.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
+        <script src="/_next/static/runtime/main-a6b94f6435d872347f43.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/1f09e40adb47572d0b2afb578fe263538cfb27db.155621535702fe040780.js"
+        <script src="/_next/static/chunks/bd2240d62d4c93a2c4c607080f72082d335d9cfd.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ce8c7e9e966800abb54f0bebe095276c4a7292bd.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/535fd764b96f2a576f34bc0fa7f6c745202e80f8.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ce8c7e9e966800abb54f0bebe095276c4a7292bd.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/535fd764b96f2a576f34bc0fa7f6c745202e80f8.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/SqnwscHNThb4UFixV1z9A/_buildManifest.js"
+        <script src="/_next/static/vN52YMC5t-IXdKEdYi5ls/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/SqnwscHNThb4UFixV1z9A/_buildManifest.module.js"
+        <script src="/_next/static/vN52YMC5t-IXdKEdYi5ls/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for link.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/SqnwscHNThb4UFixV1z9A/pages/link.module.js"
+        <link rel="preload" href="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/SqnwscHNThb4UFixV1z9A/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/ce8c7e9e966800abb54f0bebe095276c4a7292bd.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/535fd764b96f2a576f34bc0fa7f6c745202e80f8.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-a6b94f6435d872347f43.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/SqnwscHNThb4UFixV1z9A/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/vN52YMC5t-IXdKEdYi5ls/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"SqnwscHNThb4UFixV1z9A"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"vN52YMC5t-IXdKEdYi5ls"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/1f09e40adb47572d0b2afb578fe263538cfb27db.155621535702fe040780.js"
+        <script src="/_next/static/chunks/bd2240d62d4c93a2c4c607080f72082d335d9cfd.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ce8c7e9e966800abb54f0bebe095276c4a7292bd.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/535fd764b96f2a576f34bc0fa7f6c745202e80f8.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ce8c7e9e966800abb54f0bebe095276c4a7292bd.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/535fd764b96f2a576f34bc0fa7f6c745202e80f8.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
+        <script src="/_next/static/runtime/main-038a070063ee8517eb2a.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
+        <script src="/_next/static/runtime/main-a6b94f6435d872347f43.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/SqnwscHNThb4UFixV1z9A/_buildManifest.js"
+        <script src="/_next/static/vN52YMC5t-IXdKEdYi5ls/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/SqnwscHNThb4UFixV1z9A/_buildManifest.module.js"
+        <script src="/_next/static/vN52YMC5t-IXdKEdYi5ls/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for withRouter.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/SqnwscHNThb4UFixV1z9A/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/SqnwscHNThb4UFixV1z9A/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/ce8c7e9e966800abb54f0bebe095276c4a7292bd.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/535fd764b96f2a576f34bc0fa7f6c745202e80f8.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-a6b94f6435d872347f43.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/SqnwscHNThb4UFixV1z9A/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/vN52YMC5t-IXdKEdYi5ls/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"SqnwscHNThb4UFixV1z9A"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"vN52YMC5t-IXdKEdYi5ls"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/SqnwscHNThb4UFixV1z9A/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/vN52YMC5t-IXdKEdYi5ls/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/1f09e40adb47572d0b2afb578fe263538cfb27db.155621535702fe040780.js"
+        <script src="/_next/static/chunks/bd2240d62d4c93a2c4c607080f72082d335d9cfd.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ce8c7e9e966800abb54f0bebe095276c4a7292bd.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/535fd764b96f2a576f34bc0fa7f6c745202e80f8.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ce8c7e9e966800abb54f0bebe095276c4a7292bd.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/535fd764b96f2a576f34bc0fa7f6c745202e80f8.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
+        <script src="/_next/static/runtime/main-038a070063ee8517eb2a.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
+        <script src="/_next/static/runtime/main-a6b94f6435d872347f43.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/SqnwscHNThb4UFixV1z9A/_buildManifest.js"
+        <script src="/_next/static/vN52YMC5t-IXdKEdYi5ls/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/SqnwscHNThb4UFixV1z9A/_buildManifest.module.js"
+        <script src="/_next/static/vN52YMC5t-IXdKEdYi5ls/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	23.2s	22.5s	-755ms
nodeModulesSize	42.4 MB	42.4 MB	-147 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
b8d74b8a55fd..799a4e38e.js	43.1 kB	N/A	N/A
b8d74b8a55fd..e38e.js gzip	15.4 kB	N/A	N/A
c9f734900b54..2b8407376.js	21.9 kB	N/A	N/A
c9f734900b54..7376.js gzip	7.81 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
0b2109bfb74d..2b8407376.js	N/A	21.9 kB	N/A
0b2109bfb74d..7376.js gzip	N/A	7.81 kB	N/A
b9b5f3561d10..799a4e38e.js	N/A	43.1 kB	N/A
b9b5f3561d10..e38e.js gzip	N/A	15.4 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
b8d74b8a55fd..f0.module.js	45.5 kB	N/A	N/A
b8d74b8a55fd..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
b9b5f3561d10..f0.module.js	N/A	45.5 kB	N/A
b9b5f3561d10..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	fwojciec/next.js canary	Change
_error.js	247 kB	247 kB	✓
_error.js gzip	66.2 kB	66.1 kB	-57 B
hooks.html	3.86 kB	3.86 kB	✓
hooks.html gzip	982 B	986 B	⚠️ +4 B
index.js	248 kB	248 kB	✓
index.js gzip	66.5 kB	66.5 kB	⚠️ +21 B
link.js	255 kB	255 kB	✓
link.js gzip	68.6 kB	68.5 kB	-44 B
routerDirect.js	249 kB	249 kB	✓
routerDirect.js gzip	66.6 kB	66.5 kB	-55 B
withRouter.js	249 kB	249 kB	✓
withRouter.js gzip	66.5 kB	66.6 kB	⚠️ +24 B
Overall change	1.25 MB	1.25 MB	✓

fwojciec · 2019-09-08T08:14:30Z

I'm assuming that AppTree is either created using the wrapApp function here or inline here. In both cases Component and router are added to the the wrapped component (i.e. AppTree), so it is safe not to require these props in AppTreeType.

I'm not completely sure what the types of props (P) and initial props (IP) should be... Props (P) should likely be any to make it possible for users to easily add their own props. Would there ever be a scenario where someone needs to override the getInitialProps of the AppTree component? I'm assuming not (thus IP is defined as {}) but this could be also changed to any to make the component more flexible in that regard.

Finally, the original typing also made pageProps (from AppInitialProps) a required prop. I've removed this as a requirement. pageProps can still be added of course, but it is no longer enforced. Is that a problem?

ijjk · 2019-09-08T11:05:20Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	24.4s	23.3s	-1.1s
nodeModulesSize	42.4 MB	42.4 MB	-171 B

Client Bundles (main, webpack, commons) Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	-1 B
main-HASH.js gzip	6.64 kB	6.64 kB	-1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
ae25ebb71f4e..2b8407376.js	21.9 kB	N/A	N/A
ae25ebb71f4e..7376.js gzip	7.81 kB	N/A	N/A
dd43008679c2..799a4e38e.js	43.1 kB	N/A	N/A
dd43008679c2..e38e.js gzip	15.4 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
4632867307bf..2b8407376.js	N/A	21.9 kB	N/A
4632867307bf..7376.js gzip	N/A	7.81 kB	N/A
5dc289331f77..799a4e38e.js	N/A	43.1 kB	N/A
5dc289331f77..e38e.js gzip	N/A	15.4 kB	N/A
Overall change	210 kB	210 kB	-1 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	-1 B
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
dd43008679c2..f0.module.js	45.5 kB	N/A	N/A
dd43008679c2..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
5dc289331f77..f0.module.js	N/A	45.5 kB	N/A
5dc289331f77..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	-1 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	⚠️ +1 B
routerDirect.js	433 B	434 B	⚠️ +1 B
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	⚠️ +1 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	840 B	-1 B
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	805 B	⚠️ +1 B
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	430 B	⚠️ +1 B
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	⚠️ +1 B

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	fwojciec/next.js canary	Change
index.html	3.75 kB	3.75 kB	✓
index.html gzip	959 B	959 B	✓
link.html	3.79 kB	3.79 kB	✓
link.html gzip	968 B	969 B	⚠️ +1 B
withRouter.html	3.8 kB	3.8 kB	✓
withRouter.html gzip	955 B	956 B	⚠️ +1 B
Overall change	11.3 kB	11.3 kB	✓

Diffs

Diff for index.html

@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/index.module.js"
+        <link rel="preload" href="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/0571ef01ec4ac34c8afc5f39384db60da93b1dc2.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/b23ecd86f7580041da671a3fd0e5928b5d6ae843.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/0qjCzquG9nhfoh63rxKOf/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/0eJ5w37JoIQYCwGD-bA-m/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"0qjCzquG9nhfoh63rxKOf"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"0eJ5w37JoIQYCwGD-bA-m"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/0c3e49ae225852a1e9e36903c1124249ebc0d11b.155621535702fe040780.js"
+        <script src="/_next/static/chunks/f460178d31bd3e0bb069cce18b74344e12bec098.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0571ef01ec4ac34c8afc5f39384db60da93b1dc2.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/b23ecd86f7580041da671a3fd0e5928b5d6ae843.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0571ef01ec4ac34c8afc5f39384db60da93b1dc2.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/b23ecd86f7580041da671a3fd0e5928b5d6ae843.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/0qjCzquG9nhfoh63rxKOf/_buildManifest.js"
+        <script src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/0qjCzquG9nhfoh63rxKOf/_buildManifest.module.js"
+        <script src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for link.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/link.module.js"
+        <link rel="preload" href="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/0571ef01ec4ac34c8afc5f39384db60da93b1dc2.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/b23ecd86f7580041da671a3fd0e5928b5d6ae843.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/0qjCzquG9nhfoh63rxKOf/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/0eJ5w37JoIQYCwGD-bA-m/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"0qjCzquG9nhfoh63rxKOf"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"0eJ5w37JoIQYCwGD-bA-m"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/0c3e49ae225852a1e9e36903c1124249ebc0d11b.155621535702fe040780.js"
+        <script src="/_next/static/chunks/f460178d31bd3e0bb069cce18b74344e12bec098.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0571ef01ec4ac34c8afc5f39384db60da93b1dc2.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/b23ecd86f7580041da671a3fd0e5928b5d6ae843.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0571ef01ec4ac34c8afc5f39384db60da93b1dc2.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/b23ecd86f7580041da671a3fd0e5928b5d6ae843.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/0qjCzquG9nhfoh63rxKOf/_buildManifest.js"
+        <script src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/0qjCzquG9nhfoh63rxKOf/_buildManifest.module.js"
+        <script src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for withRouter.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/0571ef01ec4ac34c8afc5f39384db60da93b1dc2.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/b23ecd86f7580041da671a3fd0e5928b5d6ae843.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/0qjCzquG9nhfoh63rxKOf/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/0eJ5w37JoIQYCwGD-bA-m/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"0qjCzquG9nhfoh63rxKOf"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"0eJ5w37JoIQYCwGD-bA-m"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/0qjCzquG9nhfoh63rxKOf/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/0c3e49ae225852a1e9e36903c1124249ebc0d11b.155621535702fe040780.js"
+        <script src="/_next/static/chunks/f460178d31bd3e0bb069cce18b74344e12bec098.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0571ef01ec4ac34c8afc5f39384db60da93b1dc2.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/b23ecd86f7580041da671a3fd0e5928b5d6ae843.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/0571ef01ec4ac34c8afc5f39384db60da93b1dc2.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/b23ecd86f7580041da671a3fd0e5928b5d6ae843.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/0qjCzquG9nhfoh63rxKOf/_buildManifest.js"
+        <script src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/0qjCzquG9nhfoh63rxKOf/_buildManifest.module.js"
+        <script src="/_next/static/0eJ5w37JoIQYCwGD-bA-m/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	24s	23.4s	-537ms
nodeModulesSize	42.4 MB	42.4 MB	-171 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
842e26da1bf8..799a4e38e.js	43.1 kB	N/A	N/A
842e26da1bf8..e38e.js gzip	15.4 kB	N/A	N/A
8795353e2ec0..2b8407376.js	21.9 kB	N/A	N/A
8795353e2ec0..7376.js gzip	7.81 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
13d618e6df7b..799a4e38e.js	N/A	43.1 kB	N/A
13d618e6df7b..e38e.js gzip	N/A	15.4 kB	N/A
81732df50193..2b8407376.js	N/A	21.9 kB	N/A
81732df50193..7376.js gzip	N/A	7.81 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
842e26da1bf8..f0.module.js	45.5 kB	N/A	N/A
842e26da1bf8..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
13d618e6df7b..f0.module.js	N/A	45.5 kB	N/A
13d618e6df7b..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	fwojciec/next.js canary	Change
_error.js	247 kB	247 kB	✓
_error.js gzip	66.1 kB	66.2 kB	⚠️ +25 B
hooks.html	3.86 kB	3.86 kB	✓
hooks.html gzip	983 B	986 B	⚠️ +3 B
index.js	248 kB	248 kB	✓
index.js gzip	66.4 kB	66.5 kB	⚠️ +81 B
link.js	255 kB	255 kB	✓
link.js gzip	68.6 kB	68.6 kB	⚠️ +12 B
routerDirect.js	249 kB	249 kB	✓
routerDirect.js gzip	66.5 kB	66.5 kB	⚠️ +8 B
withRouter.js	249 kB	249 kB	✓
withRouter.js gzip	66.6 kB	66.5 kB	-76 B
Overall change	1.25 MB	1.25 MB	✓

fwojciec · 2019-09-08T11:19:04Z

I've updated my suggestion for AppTree type:

The type should derive from React's ComponentType not Next's NextComponentType because I don't think that users should ever need to do anything with getInitialProps on the AppTree. When AppTree is used in _app.tsx the user has access to the actual App component if they need to do something in getInitialProps and when it is used in the getInitialProps method of a Page component the user has no access to the App context.
AppTreeType props should be the same as AppType props, but without component and router props for reasons described above. This effectively leaves them defined as AppInitialProps or {pageProps: any}. On reflection, it seems to me that pageProps should be a required prop - the AppTree is still based on the App component and as such it is passing pageProps down the tree, so the type of AppTree should reflect that. pageProps can always be defined as an empty object or can be used to add custom props to the tree.

ijjk · 2019-09-08T14:50:48Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	23.2s	24.7s	⚠️ +1.5s
nodeModulesSize	42.4 MB	42.4 MB	⚠️ +140 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4f208dcb127d..2b8407376.js	21.9 kB	N/A	N/A
4f208dcb127d..7376.js gzip	7.81 kB	N/A	N/A
7c0325a2e60e..799a4e38e.js	43.1 kB	N/A	N/A
7c0325a2e60e..e38e.js gzip	15.4 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
81c2f726a7c5..799a4e38e.js	N/A	43.1 kB	N/A
81c2f726a7c5..e38e.js gzip	N/A	15.4 kB	N/A
8efe7b044efa..2b8407376.js	N/A	21.9 kB	N/A
8efe7b044efa..7376.js gzip	N/A	7.81 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
7c0325a2e60e..f0.module.js	45.5 kB	N/A	N/A
7c0325a2e60e..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
81c2f726a7c5..f0.module.js	N/A	45.5 kB	N/A
81c2f726a7c5..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	fwojciec/next.js canary	Change
index.html	3.75 kB	3.75 kB	✓
index.html gzip	960 B	958 B	-2 B
link.html	3.79 kB	3.79 kB	✓
link.html gzip	968 B	967 B	-1 B
withRouter.html	3.8 kB	3.8 kB	✓
withRouter.html gzip	956 B	953 B	-3 B
Overall change	11.3 kB	11.3 kB	✓

Diffs

Diff for index.html

@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/index.module.js"
+        <link rel="preload" href="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/a585af4ec4f6b5b6941adf56b9ab442df6494eb5.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/0575a06e9d536a54bf46627ea059eb6998e2ff2c.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/J-_ry9FjhQbWIbrL9XZbS/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/gnLx7CuJmpCidfjdYQCQS/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"J-_ry9FjhQbWIbrL9XZbS"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"gnLx7CuJmpCidfjdYQCQS"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/5bed58f304b48af106a40b059b758dec93b5b8e4.155621535702fe040780.js"
+        <script src="/_next/static/chunks/a77f80ca5fa908b1e124f9a30c4c288c3d955692.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/a585af4ec4f6b5b6941adf56b9ab442df6494eb5.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/0575a06e9d536a54bf46627ea059eb6998e2ff2c.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/a585af4ec4f6b5b6941adf56b9ab442df6494eb5.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/0575a06e9d536a54bf46627ea059eb6998e2ff2c.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/_buildManifest.js"
+        <script src="/_next/static/gnLx7CuJmpCidfjdYQCQS/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/_buildManifest.module.js"
+        <script src="/_next/static/gnLx7CuJmpCidfjdYQCQS/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for link.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/link.module.js"
+        <link rel="preload" href="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/a585af4ec4f6b5b6941adf56b9ab442df6494eb5.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/0575a06e9d536a54bf46627ea059eb6998e2ff2c.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/J-_ry9FjhQbWIbrL9XZbS/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/gnLx7CuJmpCidfjdYQCQS/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"J-_ry9FjhQbWIbrL9XZbS"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"gnLx7CuJmpCidfjdYQCQS"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/5bed58f304b48af106a40b059b758dec93b5b8e4.155621535702fe040780.js"
+        <script src="/_next/static/chunks/a77f80ca5fa908b1e124f9a30c4c288c3d955692.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/a585af4ec4f6b5b6941adf56b9ab442df6494eb5.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/0575a06e9d536a54bf46627ea059eb6998e2ff2c.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/a585af4ec4f6b5b6941adf56b9ab442df6494eb5.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/0575a06e9d536a54bf46627ea059eb6998e2ff2c.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/_buildManifest.js"
+        <script src="/_next/static/gnLx7CuJmpCidfjdYQCQS/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/_buildManifest.module.js"
+        <script src="/_next/static/gnLx7CuJmpCidfjdYQCQS/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for withRouter.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/a585af4ec4f6b5b6941adf56b9ab442df6494eb5.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/0575a06e9d536a54bf46627ea059eb6998e2ff2c.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/J-_ry9FjhQbWIbrL9XZbS/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/gnLx7CuJmpCidfjdYQCQS/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"J-_ry9FjhQbWIbrL9XZbS"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"gnLx7CuJmpCidfjdYQCQS"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/gnLx7CuJmpCidfjdYQCQS/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/5bed58f304b48af106a40b059b758dec93b5b8e4.155621535702fe040780.js"
+        <script src="/_next/static/chunks/a77f80ca5fa908b1e124f9a30c4c288c3d955692.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/a585af4ec4f6b5b6941adf56b9ab442df6494eb5.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/0575a06e9d536a54bf46627ea059eb6998e2ff2c.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/a585af4ec4f6b5b6941adf56b9ab442df6494eb5.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/0575a06e9d536a54bf46627ea059eb6998e2ff2c.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/_buildManifest.js"
+        <script src="/_next/static/gnLx7CuJmpCidfjdYQCQS/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/J-_ry9FjhQbWIbrL9XZbS/_buildManifest.module.js"
+        <script src="/_next/static/gnLx7CuJmpCidfjdYQCQS/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	24s	24.3s	⚠️ +275ms
nodeModulesSize	42.4 MB	42.4 MB	⚠️ +140 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
cb0ae9aef8e7..2b8407376.js	21.9 kB	N/A	N/A
cb0ae9aef8e7..7376.js gzip	7.81 kB	N/A	N/A
dfa0c47bd175..799a4e38e.js	43.1 kB	N/A	N/A
dfa0c47bd175..e38e.js gzip	15.4 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
cfdfad546c5f..2b8407376.js	N/A	21.9 kB	N/A
cfdfad546c5f..7376.js gzip	N/A	7.81 kB	N/A
f5bf7fc853d4..799a4e38e.js	N/A	43.1 kB	N/A
f5bf7fc853d4..e38e.js gzip	N/A	15.4 kB	N/A
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
dfa0c47bd175..f0.module.js	45.5 kB	N/A	N/A
dfa0c47bd175..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
f5bf7fc853d4..f0.module.js	N/A	45.5 kB	N/A
f5bf7fc853d4..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	433 B	433 B	✓
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	✓

Client Pages Modern

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	841 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	804 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	429 B	✓
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	✓

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	fwojciec/next.js canary	Change
_error.js	247 kB	247 kB	✓
_error.js gzip	66.2 kB	66.2 kB	-57 B
hooks.html	3.86 kB	3.86 kB	✓
hooks.html gzip	985 B	981 B	-4 B
index.js	248 kB	248 kB	✓
index.js gzip	66.5 kB	66.5 kB	⚠️ +61 B
link.js	255 kB	255 kB	✓
link.js gzip	68.5 kB	68.5 kB	-7 B
routerDirect.js	249 kB	249 kB	✓
routerDirect.js gzip	66.5 kB	66.5 kB	-14 B
withRouter.js	249 kB	249 kB	✓
withRouter.js gzip	66.6 kB	66.6 kB	-33 B
Overall change	1.25 MB	1.25 MB	✓

packages/next/next-server/lib/utils.ts

test/integration/app-tree/pages/_app.tsx

ijjk

Looks good 👍 Thanks for the PR!

ijjk · 2019-09-09T16:11:37Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	24.6s	23.9s	-647ms
nodeModulesSize	42.4 MB	42.4 MB	⚠️ +201 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	⚠️ +1 B
main-HASH.js gzip	6.64 kB	6.64 kB	⚠️ +1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
79c6a3c4a1a6..799a4e38e.js	43.1 kB	N/A	N/A
79c6a3c4a1a6..e38e.js gzip	15.4 kB	N/A	N/A
96ea7ea89c79..2b8407376.js	21.9 kB	N/A	N/A
96ea7ea89c79..7376.js gzip	7.81 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
1e76bc7f0ae2..2b8407376.js	N/A	21.9 kB	N/A
1e76bc7f0ae2..7376.js gzip	N/A	7.81 kB	N/A
4e84eae558f2..799a4e38e.js	N/A	43.1 kB	N/A
4e84eae558f2..e38e.js gzip	N/A	15.4 kB	N/A
Overall change	210 kB	210 kB	⚠️ +1 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	⚠️ +1 B
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
79c6a3c4a1a6..f0.module.js	45.5 kB	N/A	N/A
79c6a3c4a1a6..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
4e84eae558f2..f0.module.js	N/A	45.5 kB	N/A
4e84eae558f2..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	⚠️ +1 B

Client Pages Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	-1 B
routerDirect.js	434 B	433 B	-1 B
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	-1 B

Client Pages Modern Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	840 B	841 B	⚠️ +1 B
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	805 B	804 B	-1 B
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	430 B	429 B	-1 B
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	-1 B

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	fwojciec/next.js canary	Change
index.html	3.75 kB	3.75 kB	✓
index.html gzip	960 B	961 B	⚠️ +1 B
link.html	3.79 kB	3.79 kB	✓
link.html gzip	969 B	969 B	✓
withRouter.html	3.8 kB	3.8 kB	✓
withRouter.html gzip	956 B	956 B	✓
Overall change	11.3 kB	11.3 kB	✓

Diffs

Diff for index.html

@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/index.module.js"
+        <link rel="preload" href="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/ca4ed4f5dcdb5b472bc880b1791b25b4bebe0b4e.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/f53ba811b7595714c66d239993e9369d1302d9a3.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/dbphoa9TPoR6usZ9ES63T/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/r3eeaah2SYutBfqHnsQM4/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"dbphoa9TPoR6usZ9ES63T"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"r3eeaah2SYutBfqHnsQM4"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/0bb1c413428a91a17c80fd46e4c5dbc94a1cdfab.155621535702fe040780.js"
+        <script src="/_next/static/chunks/40b042c27c01e68358eafab50a9539d70960230d.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ca4ed4f5dcdb5b472bc880b1791b25b4bebe0b4e.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/f53ba811b7595714c66d239993e9369d1302d9a3.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ca4ed4f5dcdb5b472bc880b1791b25b4bebe0b4e.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/f53ba811b7595714c66d239993e9369d1302d9a3.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/dbphoa9TPoR6usZ9ES63T/_buildManifest.js"
+        <script src="/_next/static/r3eeaah2SYutBfqHnsQM4/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/dbphoa9TPoR6usZ9ES63T/_buildManifest.module.js"
+        <script src="/_next/static/r3eeaah2SYutBfqHnsQM4/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for link.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/link.module.js"
+        <link rel="preload" href="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/ca4ed4f5dcdb5b472bc880b1791b25b4bebe0b4e.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/f53ba811b7595714c66d239993e9369d1302d9a3.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/dbphoa9TPoR6usZ9ES63T/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/r3eeaah2SYutBfqHnsQM4/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"dbphoa9TPoR6usZ9ES63T"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"r3eeaah2SYutBfqHnsQM4"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/0bb1c413428a91a17c80fd46e4c5dbc94a1cdfab.155621535702fe040780.js"
+        <script src="/_next/static/chunks/40b042c27c01e68358eafab50a9539d70960230d.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ca4ed4f5dcdb5b472bc880b1791b25b4bebe0b4e.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/f53ba811b7595714c66d239993e9369d1302d9a3.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ca4ed4f5dcdb5b472bc880b1791b25b4bebe0b4e.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/f53ba811b7595714c66d239993e9369d1302d9a3.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/dbphoa9TPoR6usZ9ES63T/_buildManifest.js"
+        <script src="/_next/static/r3eeaah2SYutBfqHnsQM4/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/dbphoa9TPoR6usZ9ES63T/_buildManifest.module.js"
+        <script src="/_next/static/r3eeaah2SYutBfqHnsQM4/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Diff for withRouter.html

@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/ca4ed4f5dcdb5b472bc880b1791b25b4bebe0b4e.85e4c18b9e4b400e5496.module.js"
+        <link rel="preload" href="/_next/static/chunks/f53ba811b7595714c66d239993e9369d1302d9a3.85e4c18b9e4b400e5496.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/dbphoa9TPoR6usZ9ES63T/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/r3eeaah2SYutBfqHnsQM4/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"dbphoa9TPoR6usZ9ES63T"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"r3eeaah2SYutBfqHnsQM4"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/dbphoa9TPoR6usZ9ES63T/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/r3eeaah2SYutBfqHnsQM4/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/0bb1c413428a91a17c80fd46e4c5dbc94a1cdfab.155621535702fe040780.js"
+        <script src="/_next/static/chunks/40b042c27c01e68358eafab50a9539d70960230d.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ca4ed4f5dcdb5b472bc880b1791b25b4bebe0b4e.b3f63bf01308f3d17f5c.js"
+        <script src="/_next/static/chunks/f53ba811b7595714c66d239993e9369d1302d9a3.b3f63bf01308f3d17f5c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/ca4ed4f5dcdb5b472bc880b1791b25b4bebe0b4e.85e4c18b9e4b400e5496.module.js"
+        <script src="/_next/static/chunks/f53ba811b7595714c66d239993e9369d1302d9a3.85e4c18b9e4b400e5496.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-26e9253859bbcb659328.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-e3367c6cc0a826287f74.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/dbphoa9TPoR6usZ9ES63T/_buildManifest.js"
+        <script src="/_next/static/r3eeaah2SYutBfqHnsQM4/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/dbphoa9TPoR6usZ9ES63T/_buildManifest.module.js"
+        <script src="/_next/static/r3eeaah2SYutBfqHnsQM4/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
buildDuration	24.9s	24s	-925ms
nodeModulesSize	42.4 MB	42.4 MB	⚠️ +201 B

Client Bundles (main, webpack, commons) Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	-1 B
main-HASH.js gzip	6.64 kB	6.64 kB	-1 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
7d49d328a130..799a4e38e.js	43.1 kB	N/A	N/A
7d49d328a130..e38e.js gzip	15.4 kB	N/A	N/A
c8be0b5e3163..2b8407376.js	21.9 kB	N/A	N/A
c8be0b5e3163..7376.js gzip	7.81 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
78a4da1684b6..799a4e38e.js	N/A	43.1 kB	N/A
78a4da1684b6..e38e.js gzip	N/A	15.4 kB	N/A
ae23dd475727..2b8407376.js	N/A	21.9 kB	N/A
ae23dd475727..7376.js gzip	N/A	7.81 kB	N/A
Overall change	210 kB	210 kB	-1 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	zeit/next.js canary	fwojciec/next.js canary	Change
main-HASH.module.js	16.6 kB	16.6 kB	-1 B
main-HASH.module.js gzip	6.38 kB	6.38 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
7d49d328a130..f0.module.js	45.5 kB	N/A	N/A
7d49d328a130..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
78a4da1684b6..f0.module.js	N/A	45.5 kB	N/A
78a4da1684b6..dule.js gzip	N/A	16.5 kB	N/A
Overall change	189 kB	189 kB	-1 B

Client Pages Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.js	1.83 kB	1.83 kB	✓
_app.js gzip	883 B	883 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.74 kB	4.74 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.81 kB	4.81 kB	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.49 kB	3.49 kB	⚠️ +1 B
routerDirect.js	433 B	434 B	⚠️ +1 B
routerDirect.js gzip	296 B	296 B	✓
withRouter.js	444 B	444 B	✓
withRouter.js gzip	294 B	294 B	✓
Overall change	36 kB	36 kB	⚠️ +1 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	fwojciec/next.js canary	Change
_app.module.js	1.73 kB	1.73 kB	✓
_app.module.js gzip	841 B	840 B	-1 B
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.6 kB	8.6 kB	✓
hooks.module.js	1.55 kB	1.55 kB	✓
hooks.module.js gzip	804 B	805 B	⚠️ +1 B
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	419 B	419 B	✓
routerDirect..dule.js gzip	294 B	294 B	✓
withRouter.module.js	429 B	430 B	⚠️ +1 B
withRouter.m..dule.js gzip	293 B	293 B	✓
Overall change	36.2 kB	36.2 kB	⚠️ +1 B

Client Build Manifests

	zeit/next.js canary	fwojciec/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	fwojciec/next.js canary	Change
_error.js	247 kB	247 kB	✓
_error.js gzip	66.2 kB	66.2 kB	-17 B
hooks.html	3.86 kB	3.86 kB	✓
hooks.html gzip	984 B	985 B	⚠️ +1 B
index.js	248 kB	248 kB	✓
index.js gzip	66.5 kB	66.5 kB	⚠️ +5 B
link.js	255 kB	255 kB	✓
link.js gzip	68.5 kB	68.6 kB	⚠️ +64 B
routerDirect.js	249 kB	249 kB	✓
routerDirect.js gzip	66.5 kB	66.6 kB	⚠️ +42 B
withRouter.js	249 kB	249 kB	✓
withRouter.js gzip	66.6 kB	66.5 kB	-50 B
Overall change	1.25 MB	1.25 MB	✓

lfades

LGTM

better type for AppTree in NextPageContext

56d1262

fwojciec requested review from ijjk, lfades, Timer and timneutkens as code owners September 6, 2019 21:26

fwojciec mentioned this pull request Sep 6, 2019

Incorrect TS type of AppTree? #8656

Closed

ijjk requested changes Sep 6, 2019

View reviewed changes

updated tests

d20d65b

fwojciec requested a review from ijjk September 6, 2019 22:42

Timer added this to the 9.0.x milestone Sep 7, 2019

ijjk requested changes Sep 7, 2019

View reviewed changes

fwojciec added 2 commits September 8, 2019 09:39

new AppTreeType type and updated tests

654fc69

removed a commented out line

eda89fd

fwojciec requested a review from ijjk September 8, 2019 07:56

another take on the type of AppTree, with updated tests

3ccc87b

Merge branch 'canary' into canary

e7f41e9

Merge branch 'canary' into canary

fa5a9d6

ijjk reviewed Sep 9, 2019

View reviewed changes

packages/next/next-server/lib/utils.ts Outdated Show resolved Hide resolved

ijjk reviewed Sep 9, 2019

View reviewed changes

test/integration/app-tree/pages/_app.tsx Outdated Show resolved Hide resolved

fwojciec added 2 commits September 9, 2019 17:32

allow passing additional props to AppType

232e6e2

Merge branch 'canary' of https://github.com/fwojciec/next.js into canary

ffd3a62

fwojciec requested a review from ijjk September 9, 2019 15:35

ijjk added 2 commits September 9, 2019 11:01

Update suite name

261e0c5

Merge remote-tracking branch 'upstream/canary' into fwojciec-canary

efdb95a

ijjk approved these changes Sep 9, 2019

View reviewed changes

lfades approved these changes Sep 9, 2019

View reviewed changes

ijjk merged commit 92e26ce into vercel:canary Sep 9, 2019

Timer modified the milestones: 9.0.x, 9.0.6 Sep 9, 2019

This was referenced Sep 16, 2021

[Snyk] Fix for 1 vulnerabilities majacQ/next.js#273

Open

[Snyk] Fix for 1 vulnerabilities baby636/next.js#259

Open

github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

better type for AppTree in NextPageContext #8662

better type for AppTree in NextPageContext #8662

fwojciec commented Sep 6, 2019

ijjk left a comment

ijjk commented Sep 6, 2019

Diffs

ijjk commented Sep 6, 2019

Diffs

fwojciec commented Sep 6, 2019

ijjk left a comment

ijjk commented Sep 8, 2019

Diffs

ijjk commented Sep 8, 2019

Diffs

fwojciec commented Sep 8, 2019 •

edited

ijjk commented Sep 8, 2019

Diffs

fwojciec commented Sep 8, 2019

ijjk commented Sep 8, 2019

Diffs

ijjk left a comment

ijjk commented Sep 9, 2019

Diffs

lfades left a comment

better type for AppTree in NextPageContext #8662

better type for AppTree in NextPageContext #8662

Conversation

fwojciec commented Sep 6, 2019

ijjk left a comment

Choose a reason for hiding this comment

ijjk commented Sep 6, 2019

Stats from current PR

Diffs

ijjk commented Sep 6, 2019

Stats from current PR

Diffs

fwojciec commented Sep 6, 2019

ijjk left a comment

Choose a reason for hiding this comment

ijjk commented Sep 8, 2019

Stats from current PR

Diffs

ijjk commented Sep 8, 2019

Stats from current PR

Diffs

fwojciec commented Sep 8, 2019 • edited

ijjk commented Sep 8, 2019

Stats from current PR

Diffs

fwojciec commented Sep 8, 2019

ijjk commented Sep 8, 2019

Stats from current PR

Diffs

ijjk left a comment

Choose a reason for hiding this comment

ijjk commented Sep 9, 2019

Stats from current PR

Diffs

lfades left a comment

Choose a reason for hiding this comment

fwojciec commented Sep 8, 2019 •

edited