Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(api-routes): fix micro-cors example #9184

Merged
merged 2 commits into from Oct 23, 2019
Merged

docs(api-routes): fix micro-cors example #9184

merged 2 commits into from Oct 23, 2019

Conversation

midudev
Copy link
Contributor

@midudev midudev commented Oct 23, 2019

The correct option to use with micro-cors package is allowMethods instead allowedMethods. This PR fixes the example.

@midudev
Update README.md
6c03ff7 
The correct option to use with `micro-cors` package is `allowMethods` instead `allowedMethods`. This PR fixes the example.
@midudev midudev changed the title Update README.md Update README.md fixing micro-cors example Oct 23, 2019
Timer
Timer approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@Timer Timer added this to the 9.1.2 milestone Oct 23, 2019
@Timer Timer changed the base branch from master to canary October 23, 2019 21:13
@Timer Timer changed the title Update README.md fixing micro-cors example docs(api-routes): fix micro-cors example Oct 23, 2019
@Timer Timer merged commit 8227baf into vercel:canary Oct 23, 2019
@midudev midudev deleted the patch-1 branch October 23, 2019 21:15
This was referenced Nov 12, 2019
Merged
Open
Open
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@midudev @Timer