Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Legacy Code #9515

Merged
merged 2 commits into from Nov 25, 2019
Merged

Remove Legacy Code #9515

merged 2 commits into from Nov 25, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented Nov 25, 2019

The sprStatus module state is no longer used (and shouldn't be!). We can safely remove this code.

I also renamed the drop bundle identifier while I was here.

@Timer
Remove Legacy Code
c4fd12d 
The `sprStatus` module state is no longer used (and shouldn't be!). We can safely remove this code.

I also renamed the drop bundle identifier while I was here.
@Timer Timer added this to the 9.1.5 milestone Nov 25, 2019
@ijjk
Copy link
Member

ijjk commented Nov 25, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove-legacy Change
buildDuration 14.5s 14.4s -115ms
nodeModulesSize 48.3 MB 48.3 MB -431 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove-legacy Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.33 kB 6.33 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..ebc17c08d.js 19.8 kB 19.8 kB ✓
16b1a7225520..c08d.js gzip 7.35 kB 7.35 kB ✓
4952ddcd88e7..49d7903c2.js 9.6 kB 9.6 kB ✓
4952ddcd88e7..03c2.js gzip 3.76 kB 3.76 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..a824c82eb.js 28.3 kB 28.3 kB ✓
de003c3a9d30..82eb.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js 125 kB 125 kB ✓
framework.HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 213 kB 213 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove-legacy Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.3 kB 5.3 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..9a.module.js 21.3 kB 21.3 kB ✓
16b1a7225520..dule.js gzip 8.14 kB 8.14 kB ✓
4952ddcd88e7..cc.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.43 kB 4.43 kB ✓
de003c3a9d30..36.module.js 22.2 kB 22.2 kB ✓
de003c3a9d30..dule.js gzip 8.71 kB 8.71 kB ✓
framework.HASH.module.js 125 kB 125 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 196 kB 196 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove-legacy Change
polyfills-HASH.js 9.11 kB 9.11 kB ✓
polyfills-HASH.js gzip 3.11 kB 3.11 kB ✓
Overall change 9.11 kB 9.11 kB ✓
Client Pages
zeit/next.js canary Timer/next.js remove-legacy Change
_app.js 2.92 kB 2.92 kB ✓
_app.js gzip 1.32 kB 1.32 kB ✓
_error.js 13.2 kB 13.2 kB ✓
_error.js gzip 5.1 kB 5.1 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.76 kB 6.76 kB ✓
link.js gzip 2.88 kB 2.88 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 26 kB 26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js remove-legacy Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 677 B 677 B ✓
hooks.module.js gzip 384 B 384 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 19.3 kB 19.3 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove-legacy Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 201 B 201 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 208 B 208 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js remove-legacy Change
index.html 4.06 kB 4.06 kB ✓
index.html gzip 1.04 kB 1.04 kB ✓
link.html 4.58 kB 4.58 kB ✓
link.html gzip 1.12 kB 1.12 kB ✓
withRouter.html 4.59 kB 4.59 kB ✓
withRouter.html gzip 1.1 kB 1.1 kB ✓
Overall change 13.2 kB 13.2 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove-legacy Change
buildDuration 15.3s 14.8s -526ms
nodeModulesSize 48.3 MB 48.3 MB -431 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove-legacy Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.33 kB 6.33 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..ebc17c08d.js 19.8 kB 19.8 kB ✓
16b1a7225520..c08d.js gzip 7.35 kB 7.35 kB ✓
4952ddcd88e7..49d7903c2.js 9.6 kB 9.6 kB ✓
4952ddcd88e7..03c2.js gzip 3.76 kB 3.76 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..a824c82eb.js 28.3 kB 28.3 kB ✓
de003c3a9d30..82eb.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js 125 kB 125 kB ✓
framework.HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 213 kB 213 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove-legacy Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.3 kB 5.3 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..9a.module.js 21.3 kB 21.3 kB ✓
16b1a7225520..dule.js gzip 8.14 kB 8.14 kB ✓
4952ddcd88e7..cc.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.43 kB 4.43 kB ✓
de003c3a9d30..36.module.js 22.2 kB 22.2 kB ✓
de003c3a9d30..dule.js gzip 8.71 kB 8.71 kB ✓
framework.HASH.module.js 125 kB 125 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 196 kB 196 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove-legacy Change
polyfills-HASH.js 9.11 kB 9.11 kB ✓
polyfills-HASH.js gzip 3.11 kB 3.11 kB ✓
Overall change 9.11 kB 9.11 kB ✓
Client Pages
zeit/next.js canary Timer/next.js remove-legacy Change
_app.js 2.92 kB 2.92 kB ✓
_app.js gzip 1.32 kB 1.32 kB ✓
_error.js 13.2 kB 13.2 kB ✓
_error.js gzip 5.1 kB 5.1 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.76 kB 6.76 kB ✓
link.js gzip 2.88 kB 2.88 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 26 kB 26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js remove-legacy Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 677 B 677 B ✓
hooks.module.js gzip 384 B 384 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 19.3 kB 19.3 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove-legacy Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 201 B 201 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 208 B 208 B ✓
Overall change 495 B 495 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js remove-legacy Change
_error.js 255 kB 255 kB ✓
_error.js gzip 67.9 kB 67.9 kB ✓
hooks.html 4.19 kB 4.19 kB ✓
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js 256 kB 256 kB ✓
index.js gzip 68 kB 68 kB ✓
link.js 288 kB 288 kB ✓
link.js gzip 77.1 kB 77.1 kB ✓
routerDirect.js 281 kB 281 kB ✓
routerDirect.js gzip 75.1 kB 75.1 kB ✓
withRouter.js 281 kB 281 kB ✓
withRouter.js gzip 75.2 kB 75.2 kB ✓
Overall change 1.37 MB 1.37 MB ✓

Commit: c4fd12d

@ijjk
Copy link
Member

ijjk commented Nov 25, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove-legacy Change
buildDuration 12.7s 12.9s ⚠️ +274ms
nodeModulesSize 48.3 MB 48.3 MB -431 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove-legacy Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.33 kB 6.33 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..ebc17c08d.js 19.8 kB 19.8 kB ✓
16b1a7225520..c08d.js gzip 7.35 kB 7.35 kB ✓
4952ddcd88e7..49d7903c2.js 9.6 kB 9.6 kB ✓
4952ddcd88e7..03c2.js gzip 3.76 kB 3.76 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..a824c82eb.js 28.3 kB 28.3 kB ✓
de003c3a9d30..82eb.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js 125 kB 125 kB ✓
framework.HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 213 kB 213 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove-legacy Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.3 kB 5.3 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..9a.module.js 21.3 kB 21.3 kB ✓
16b1a7225520..dule.js gzip 8.14 kB 8.14 kB ✓
4952ddcd88e7..cc.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.43 kB 4.43 kB ✓
de003c3a9d30..36.module.js 22.2 kB 22.2 kB ✓
de003c3a9d30..dule.js gzip 8.71 kB 8.71 kB ✓
framework.HASH.module.js 125 kB 125 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 196 kB 196 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove-legacy Change
polyfills-HASH.js 9.11 kB 9.11 kB ✓
polyfills-HASH.js gzip 3.11 kB 3.11 kB ✓
Overall change 9.11 kB 9.11 kB ✓
Client Pages
zeit/next.js canary Timer/next.js remove-legacy Change
_app.js 2.92 kB 2.92 kB ✓
_app.js gzip 1.32 kB 1.32 kB ✓
_error.js 13.2 kB 13.2 kB ✓
_error.js gzip 5.1 kB 5.1 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.76 kB 6.76 kB ✓
link.js gzip 2.88 kB 2.88 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 26 kB 26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js remove-legacy Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 677 B 677 B ✓
hooks.module.js gzip 384 B 384 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 19.3 kB 19.3 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove-legacy Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 201 B 201 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 208 B 208 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js remove-legacy Change
index.html 4.06 kB 4.06 kB ✓
index.html gzip 1.04 kB 1.04 kB ✓
link.html 4.58 kB 4.58 kB ✓
link.html gzip 1.12 kB 1.12 kB ✓
withRouter.html 4.59 kB 4.59 kB ✓
withRouter.html gzip 1.1 kB 1.1 kB ✓
Overall change 13.2 kB 13.2 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove-legacy Change
buildDuration 12.9s 13s ⚠️ +85ms
nodeModulesSize 48.3 MB 48.3 MB -431 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove-legacy Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.33 kB 6.33 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..ebc17c08d.js 19.8 kB 19.8 kB ✓
16b1a7225520..c08d.js gzip 7.35 kB 7.35 kB ✓
4952ddcd88e7..49d7903c2.js 9.6 kB 9.6 kB ✓
4952ddcd88e7..03c2.js gzip 3.76 kB 3.76 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..a824c82eb.js 28.3 kB 28.3 kB ✓
de003c3a9d30..82eb.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js 125 kB 125 kB ✓
framework.HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 213 kB 213 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove-legacy Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.3 kB 5.3 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..9a.module.js 21.3 kB 21.3 kB ✓
16b1a7225520..dule.js gzip 8.14 kB 8.14 kB ✓
4952ddcd88e7..cc.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.43 kB 4.43 kB ✓
de003c3a9d30..36.module.js 22.2 kB 22.2 kB ✓
de003c3a9d30..dule.js gzip 8.71 kB 8.71 kB ✓
framework.HASH.module.js 125 kB 125 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 196 kB 196 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove-legacy Change
polyfills-HASH.js 9.11 kB 9.11 kB ✓
polyfills-HASH.js gzip 3.11 kB 3.11 kB ✓
Overall change 9.11 kB 9.11 kB ✓
Client Pages
zeit/next.js canary Timer/next.js remove-legacy Change
_app.js 2.92 kB 2.92 kB ✓
_app.js gzip 1.32 kB 1.32 kB ✓
_error.js 13.2 kB 13.2 kB ✓
_error.js gzip 5.1 kB 5.1 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.76 kB 6.76 kB ✓
link.js gzip 2.88 kB 2.88 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 26 kB 26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js remove-legacy Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 677 B 677 B ✓
hooks.module.js gzip 384 B 384 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 19.3 kB 19.3 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove-legacy Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 201 B 201 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 208 B 208 B ✓
Overall change 495 B 495 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js remove-legacy Change
_error.js 255 kB 255 kB ✓
_error.js gzip 67.9 kB 67.9 kB ✓
hooks.html 4.19 kB 4.19 kB ✓
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js 256 kB 256 kB ✓
index.js gzip 68 kB 68 kB ✓
link.js 288 kB 288 kB ✓
link.js gzip 77.1 kB 77.1 kB ✓
routerDirect.js 281 kB 281 kB ✓
routerDirect.js gzip 75.1 kB 75.1 kB ✓
withRouter.js 281 kB 281 kB ✓
withRouter.js gzip 75.2 kB 75.2 kB ✓
Overall change 1.37 MB 1.37 MB ✓

Commit: 0ac2e9a

@Timer Timer merged commit caa5347 into vercel:canary Nov 25, 2019
@Timer Timer deleted the remove-legacy branch November 25, 2019 19:32
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.1.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timer @ijjk