Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get(Static|Initial)Props re-running when updating query #9907

Merged
merged 5 commits into from
Jan 3, 2020
Merged

Fix get(Static|Initial)Props re-running when updating query #9907

merged 5 commits into from
Jan 3, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 2, 2020

This makes sure to use shallow: true when updating the query for static pages so that we don't re-call getInitialProps or getStaticProps. Also, adds a test to make sure we don't regress on this

Fixes: #9902

@ijjk ijjk added the Type: Bug label Jan 2, 2020
@ijjk ijjk added this to the 9.1.x milestone Jan 2, 2020
@ijjk
Copy link
Member Author

ijjk commented Jan 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
buildDuration 14.2s 14.4s ⚠️ +276ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +38 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.js gzip 6.44 kB 6.45 kB ⚠️ +8 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..6ef5.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 69.2 kB 69.2 kB ⚠️ +8 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.module.js gzip 5.42 kB 5.43 kB ⚠️ +8 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.6 kB 12.6 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 63.7 kB 63.7 kB ⚠️ +8 B
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js update/updating-query Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.93 kB 2.93 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.89 kB 9.89 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.49 kB 2.49 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.43 kB 7.43 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js update/updating-query Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
index.html gzip 1.04 kB 1.04 kB ⚠️ +1 B
link.html gzip 1.04 kB 1.04 kB ✓
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 3.12 kB 3.12 kB ⚠️ +1 B

Diffs

Diff for main-HASH.js 
@@ -584,6 +584,7 @@
                       // client-side hydration. Your app should _never_ use this property.
                       // It may change at any time without notice.
                       _h: 1,
+                      shallow: true,
                     }
                   )
                 }
Diff for main-HASH.module.js 
@@ -447,6 +447,7 @@
                 // client-side hydration. Your app should _never_ use this property.
                 // It may change at any time without notice.
                 _h: 1,
+                shallow: true,
               }
             )
           }
Diff for index.html 
@@ -27,7 +27,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -121,13 +121,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+      src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -168,13 +168,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+      src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+      src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
buildDuration 14.7s 14.7s -12ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +38 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.js gzip 6.44 kB 6.45 kB ⚠️ +8 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..6ef5.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 69.2 kB 69.2 kB ⚠️ +8 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.module.js gzip 5.42 kB 5.43 kB ⚠️ +8 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.6 kB 12.6 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 63.7 kB 63.7 kB ⚠️ +8 B
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js update/updating-query Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.93 kB 2.93 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.89 kB 9.89 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.49 kB 2.49 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.43 kB 7.43 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js update/updating-query Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
_error.js gzip 78.9 kB 78.9 kB ⚠️ +3 B
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js gzip 79.1 kB 79.1 kB ⚠️ +2 B
link.js gzip 81.3 kB 81.3 kB ⚠️ +3 B
routerDirect.js gzip 79.2 kB 79.2 kB ⚠️ +3 B
withRouter.js gzip 79.3 kB 79.3 kB ⚠️ +3 B
Overall change 399 kB 399 kB ⚠️ +14 B

Commit: 5822d27

@ijjk
Copy link
Member Author

ijjk commented Jan 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
buildDuration 13.4s 12.9s -474ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +38 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.js gzip 6.44 kB 6.45 kB ⚠️ +8 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..6ef5.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 69.2 kB 69.2 kB ⚠️ +8 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.module.js gzip 5.42 kB 5.43 kB ⚠️ +8 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.6 kB 12.6 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 63.7 kB 63.7 kB ⚠️ +8 B
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js update/updating-query Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.93 kB 2.93 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.89 kB 9.89 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.49 kB 2.49 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.43 kB 7.43 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js update/updating-query Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
index.html gzip 1.04 kB 1.04 kB ⚠️ +1 B
link.html gzip 1.04 kB 1.04 kB ✓
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 3.12 kB 3.12 kB ⚠️ +1 B

Diffs

Diff for main-HASH.js 
@@ -584,6 +584,7 @@
                       // client-side hydration. Your app should _never_ use this property.
                       // It may change at any time without notice.
                       _h: 1,
+                      shallow: true,
                     }
                   )
                 }
Diff for main-HASH.module.js 
@@ -447,6 +447,7 @@
                 // client-side hydration. Your app should _never_ use this property.
                 // It may change at any time without notice.
                 _h: 1,
+                shallow: true,
               }
             )
           }
Diff for index.html 
@@ -27,7 +27,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -121,13 +121,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+      src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -168,13 +168,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+      src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      href="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-6f2f4f6b75345eed99f5.js"
+      src="/_next/static/runtime/main-58009eb7bc610a20890d.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-db90a50fdfef4e28666f.module.js"
+      src="/_next/static/runtime/main-67f0a4b5c404ecc3ac54.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
buildDuration 13.6s 13.8s ⚠️ +174ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +38 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.js gzip 6.44 kB 6.45 kB ⚠️ +8 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..6ef5.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 69.2 kB 69.2 kB ⚠️ +8 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.module.js gzip 5.42 kB 5.43 kB ⚠️ +8 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.6 kB 12.6 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 63.7 kB 63.7 kB ⚠️ +8 B
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js update/updating-query Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.93 kB 2.93 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.89 kB 9.89 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.49 kB 2.49 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.43 kB 7.43 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js update/updating-query Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
_error.js gzip 78.9 kB 78.9 kB ⚠️ +3 B
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js gzip 79.1 kB 79.1 kB ⚠️ +2 B
link.js gzip 81.3 kB 81.3 kB ⚠️ +3 B
routerDirect.js gzip 79.2 kB 79.2 kB ⚠️ +3 B
withRouter.js gzip 79.3 kB 79.3 kB ⚠️ +3 B
Overall change 399 kB 399 kB ⚠️ +14 B

Commit: b1d12fd

@ijjk ijjk mentioned this pull request Jan 2, 2020
Merged
@Timer Timer modified the milestones: 9.1.x, 9.2.0 Jan 2, 2020
Timer
Timer requested changes Jan 2, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holding for 9.2

@ijjk
Copy link
Member Author

ijjk commented Jan 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
buildDuration 12.3s 12.2s -123ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +38 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.js gzip 6.43 kB 6.44 kB ⚠️ +8 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..6ef5.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 69.2 kB 69.2 kB ⚠️ +8 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.module.js gzip 5.41 kB 5.42 kB ⚠️ +8 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.6 kB 12.6 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 63.7 kB 63.7 kB ⚠️ +8 B
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js update/updating-query Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.93 kB 2.93 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.89 kB 9.89 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.49 kB 2.49 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.43 kB 7.43 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js update/updating-query Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
index.html gzip 1.04 kB 1.04 kB ✓
link.html gzip 1.04 kB 1.04 kB ⚠️ +1 B
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 3.11 kB 3.11 kB ⚠️ +1 B

Diffs

Diff for main-HASH.js 
@@ -584,6 +584,7 @@
                       // client-side hydration. Your app should _never_ use this property.
                       // It may change at any time without notice.
                       _h: 1,
+                      shallow: true,
                     }
                   )
                 }
Diff for main-HASH.module.js 
@@ -447,6 +447,7 @@
                 // client-side hydration. Your app should _never_ use this property.
                 // It may change at any time without notice.
                 _h: 1,
+                shallow: true,
               }
             )
           }
Diff for index.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+      src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -168,13 +168,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+      src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+      src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
buildDuration 12.7s 12.8s ⚠️ +79ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +38 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.js gzip 6.43 kB 6.44 kB ⚠️ +8 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..6ef5.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 69.2 kB 69.2 kB ⚠️ +8 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.module.js gzip 5.41 kB 5.42 kB ⚠️ +8 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.6 kB 12.6 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 63.7 kB 63.7 kB ⚠️ +8 B
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js update/updating-query Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.93 kB 2.93 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.89 kB 9.89 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.49 kB 2.49 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.43 kB 7.43 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js update/updating-query Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js update/updating-query Change
_error.js gzip 78.9 kB 78.9 kB -2 B
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js gzip 79.1 kB 79.1 kB -2 B
link.js gzip 81.3 kB 81.3 kB -1 B
routerDirect.js gzip 79.2 kB 79.2 kB -2 B
withRouter.js gzip 79.3 kB 79.3 kB -2 B
Overall change 399 kB 399 kB -9 B

Commit: c5e36fc

@ijjk
Copy link
Member Author

ijjk commented Jan 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
buildDuration 13.8s 13.7s -140ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +38 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.js gzip 6.43 kB 6.44 kB ⚠️ +8 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..6ef5.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 69.2 kB 69.2 kB ⚠️ +8 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.module.js gzip 5.41 kB 5.42 kB ⚠️ +8 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.6 kB 12.6 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 63.7 kB 63.7 kB ⚠️ +8 B
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js update/updating-query Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.93 kB 2.93 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.89 kB 9.89 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.49 kB 2.49 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.43 kB 7.43 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js update/updating-query Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
index.html gzip 1.04 kB 1.04 kB ✓
link.html gzip 1.04 kB 1.04 kB ⚠️ +1 B
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 3.11 kB 3.11 kB ⚠️ +1 B

Diffs

Diff for main-HASH.js 
@@ -584,6 +584,7 @@
                       // client-side hydration. Your app should _never_ use this property.
                       // It may change at any time without notice.
                       _h: 1,
+                      shallow: true,
                     }
                   )
                 }
Diff for main-HASH.module.js 
@@ -447,6 +447,7 @@
                 // client-side hydration. Your app should _never_ use this property.
                 // It may change at any time without notice.
                 _h: 1,
+                shallow: true,
               }
             )
           }
Diff for index.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+      src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -168,13 +168,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+      src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      href="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-b984e7fb60832e00613e.js"
+      src="/_next/static/runtime/main-263cdc7d791b720e46ce.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-6c919dd5a10cd6022375.module.js"
+      src="/_next/static/runtime/main-4b877ebd35489498520c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
buildDuration 14.8s 14.2s -533ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +38 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.js gzip 6.43 kB 6.44 kB ⚠️ +8 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..6ef5.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 69.2 kB 69.2 kB ⚠️ +8 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js update/updating-query Change
main-HASH.module.js gzip 5.41 kB 5.42 kB ⚠️ +8 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.6 kB 12.6 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 63.7 kB 63.7 kB ⚠️ +8 B
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js update/updating-query Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.93 kB 2.93 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.89 kB 9.89 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js update/updating-query Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.49 kB 2.49 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.43 kB 7.43 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js update/updating-query Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js update/updating-query Change
_error.js gzip 78.9 kB 78.9 kB -2 B
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js gzip 79.1 kB 79.1 kB -2 B
link.js gzip 81.3 kB 81.3 kB -1 B
routerDirect.js gzip 79.2 kB 79.2 kB -2 B
withRouter.js gzip 79.3 kB 79.3 kB -2 B
Overall change 399 kB 399 kB -9 B

Commit: 4bdcc62

@Timer Timer merged commit ae78e8f into vercel:canary Jan 3, 2020
@Timer Timer deleted the update/updating-query branch January 3, 2020 20:36
@snyk-bot snyk-bot mentioned this pull request Feb 11, 2020
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.2.0
Development

Successfully merging this pull request may close these issues.

Static Exported Dynamic Page is re-mounted (getInitialProps called twice)
2 participants
@ijjk @Timer