nodeFileTrace Chokes on @napi-rs Dependency usr/bin/ldd, Causing Build to Fail
#303
Comments
|
I suspect napi-rs is attempting to read that file which is why nft attempts to trace it. Without the repo with the input file and nft options, I can't know for sure. However, this isn't really a bug in nft. The warnings in the result from nft can be handled as you wish, and it seems svelte decided to throw. |
styfle
added a commit
that referenced
this issue
Aug 22, 2022
This PR changes the behavior of dependency tracing such that `fs.readFile('./file.js')` is no longer considered a `dependency` and it will not be traced. Instead, it is considered an `asset` the same way a `fs.readFile('./file.txt')` is. The `dependency` type will be reserved for `import` and `require` only.
- Fixes #303
- Related to vercel/customer-issues#608
Note that this could be considered a breaking change since #40 expected the `readFile()` config to be called for assets but it should only be called for dependencies.
In order to reduce the amount of breakage, `require.resolve()` was left as dependency instead of asset since its often passed to `child_process.spawn()` which needs the dependencies.
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of @sveltejs/adapter-vercel version 1.0.0-next.63, the build process employs the exported nodeFileTrace function from @vercel/nft to determine which modules throw errors, allowing the errors logged by the CLI to be displayed in a much cleaner manner.
Unfortunately, this causes the build to error out:
Per @Rich-Harris, this appears to possibly be an issue within the exported nodeFileTrace function in @vercel/nft as it appears to be attempting to parse
usr/bin/ldd: sveltejs/kit#5577 (comment)Link to the full initial issue w/ additional logs: sveltejs/kit#5577
Link to reproduction of issue: https://github.com/cryptodeal/adapter-vercel-build-error
The text was updated successfully, but these errors were encountered: