Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional items to shared cache #237

Merged
merged 7 commits into from
Oct 2, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 1, 2021

This ensures we leverage the shared cache when preforming expensive checks to provide better performance when tracing multiple files individually but sharing the same cache instead of tracing them in the same nodeFileTrace run.

In one test repo this brought tracing down from 130 seconds -> 25 seconds while tracing separately. which brings this much closer with the time it took when tracing all files in one nodeFileTrace run which was around 17 seconds.

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #237 (1826b9c) into main (e7fbbe1) will increase coverage by 0.94%.
The diff coverage is 88.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   80.30%   81.25%   +0.94%     
==========================================
  Files          13       13              
  Lines        1447     1472      +25     
  Branches      539      545       +6     
==========================================
+ Hits         1162     1196      +34     
+ Misses        113      109       -4     
+ Partials      172      167       -5     
Impacted Files Coverage Δ
src/utils/sharedlib-emit.ts 68.00% <75.00%> (+1.33%) ⬆️
src/resolve-dependency.ts 71.92% <87.50%> (+2.11%) ⬆️
src/node-file-trace.ts 86.75% <100.00%> (+5.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7fbbe1...1826b9c. Read the comment docs.

@ijjk ijjk marked this pull request as ready for review October 1, 2021 21:06
@ijjk ijjk requested a review from timneutkens October 1, 2021 21:06
src/node-file-trace.ts Outdated Show resolved Hide resolved
src/resolve-dependency.ts Outdated Show resolved Hide resolved
@ijjk ijjk added the automerge Automatically merge PR once checks pass label Oct 2, 2021
@kodiakhq kodiakhq bot merged commit dc1110c into main Oct 2, 2021
@kodiakhq kodiakhq bot deleted the add/additional-caching branch October 2, 2021 15:31
ijjk added a commit that referenced this pull request Oct 9, 2021
kodiakhq bot pushed a commit that referenced this pull request Oct 10, 2021
* Add failing test case for pnpm symlinks

* Revert "Add additional items to shared cache (#237)"

This reverts commit dc1110c.

* add caching emitDependency

* add missing awaits
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Oct 14, 2021
This updates to the latest version of `@vercel/nft` which includes better shared caching between runs. 

x-ref: vercel/nft#239
x-ref: vercel/nft#238
x-ref: vercel/nft#237
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
This updates to the latest version of `@vercel/nft` which includes better shared caching between runs. 

x-ref: vercel/nft#239
x-ref: vercel/nft#238
x-ref: vercel/nft#237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants