Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support import attributes #377

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Dec 11, 2023

The Import Attributes proposal is in Stage 3, so implementation is started. Currently, NFT bails on any file that includes import attributes, because Acorn can't parse them. That's because Acorn only supports Stage 4 proposals - but for import attributes, there's a plugin that this PR adds to NFT.

@Skn0tt
Copy link
Contributor Author

Skn0tt commented Dec 11, 2023

It seems like acorn-import-attributes doesn't support the assert { type: "json" } syntax, even though that's still part of the proposal. That's for a different PR, though.

Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ethan-Arrowood Ethan-Arrowood merged commit 22541e4 into vercel:main Dec 13, 2023
15 checks passed
Copy link

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

kodiakhq bot pushed a commit that referenced this pull request May 10, 2024
`acorn-import-attributes` [did not support import assertions
before](#377 (comment)),
but now it does!

This is important because `acorn` is failing to parse `runner.js` in
[this issue](vercel/vercel#11533) due to an
import assertion.
kodiakhq bot pushed a commit to X-oss-byte/Nextjs that referenced this pull request May 10, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@vercel/nft](https://togithub.com/vercel/nft) | [`0.26.5` -> `0.27.0`](https://renovatebot.com/diffs/npm/@vercel%2fnft/0.26.4/0.27.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vercel%2fnft/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vercel%2fnft/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vercel%2fnft/0.26.4/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vercel%2fnft/0.26.4/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>vercel/nft (@&#8203;vercel/nft)</summary>

### [`v0.27.0`](https://togithub.com/vercel/nft/releases/tag/0.27.0)

[Compare Source](https://togithub.com/vercel/nft/compare/0.26.5...0.27.0)

##### Features

-   support import assertions ([#&#8203;417](https://togithub.com/vercel/nft/issues/417)) ([ddc5cba](https://togithub.com/vercel/nft/commit/ddc5cbac2361f0b9c9a90e8f905ee53b9dfa7477)), closes [/github.com/vercel/nft/pull/377#issuecomment-1849719137](https://togithub.com//github.com/vercel/nft/pull/377/issues/issuecomment-1849719137)

### [`v0.26.5`](https://togithub.com/vercel/nft/releases/tag/0.26.5)

[Compare Source](https://togithub.com/vercel/nft/compare/0.26.4...0.26.5)

##### Bug Fixes

-   Add special case for Serial Port binary (.node) modules ([#&#8203;415](https://togithub.com/vercel/nft/issues/415)) ([e001d05](https://togithub.com/vercel/nft/commit/e001d0586804b696849c125dbeefe76ef5a71434))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
kodiakhq bot pushed a commit to X-oss-byte/Canary-nextjs that referenced this pull request May 13, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@vercel/nft](https://togithub.com/vercel/nft) | [`0.26.5` -> `0.27.0`](https://renovatebot.com/diffs/npm/@vercel%2fnft/0.26.5/0.27.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vercel%2fnft/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vercel%2fnft/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vercel%2fnft/0.26.5/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vercel%2fnft/0.26.5/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>vercel/nft (@&#8203;vercel/nft)</summary>

### [`v0.27.0`](https://togithub.com/vercel/nft/releases/tag/0.27.0)

[Compare Source](https://togithub.com/vercel/nft/compare/0.26.5...0.27.0)

##### Features

-   support import assertions ([#&#8203;417](https://togithub.com/vercel/nft/issues/417)) ([ddc5cba](https://togithub.com/vercel/nft/commit/ddc5cbac2361f0b9c9a90e8f905ee53b9dfa7477)), closes [/github.com/vercel/nft/pull/377#issuecomment-1849719137](https://togithub.com//github.com/vercel/nft/pull/377/issues/issuecomment-1849719137)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
kodiakhq bot pushed a commit to X-oss-byte/Nextjs that referenced this pull request May 24, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@vercel/nft](https://togithub.com/vercel/nft) | [`0.27.0` -> `0.27.1`](https://renovatebot.com/diffs/npm/@vercel%2fnft/0.26.4/0.27.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vercel%2fnft/0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vercel%2fnft/0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vercel%2fnft/0.26.4/0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vercel%2fnft/0.26.4/0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>vercel/nft (@&#8203;vercel/nft)</summary>

### [`v0.27.1`](https://togithub.com/vercel/nft/releases/tag/0.27.1)

[Compare Source](https://togithub.com/vercel/nft/compare/0.27.0...0.27.1)

##### Bug Fixes

-   node-gyp-build for `@datadog/pprof` ([#&#8203;419](https://togithub.com/vercel/nft/issues/419)) ([db6c65a](https://togithub.com/vercel/nft/commit/db6c65ab04d2ead35d1ca65a601b569b10ca2036))

### [`v0.27.0`](https://togithub.com/vercel/nft/releases/tag/0.27.0)

[Compare Source](https://togithub.com/vercel/nft/compare/0.26.5...0.27.0)

##### Features

-   support import assertions ([#&#8203;417](https://togithub.com/vercel/nft/issues/417)) ([ddc5cba](https://togithub.com/vercel/nft/commit/ddc5cbac2361f0b9c9a90e8f905ee53b9dfa7477)), closes [/github.com/vercel/nft/pull/377#issuecomment-1849719137](https://togithub.com//github.com/vercel/nft/pull/377/issues/issuecomment-1849719137)

### [`v0.26.5`](https://togithub.com/vercel/nft/releases/tag/0.26.5)

[Compare Source](https://togithub.com/vercel/nft/compare/0.26.4...0.26.5)

##### Bug Fixes

-   Add special case for Serial Port binary (.node) modules ([#&#8203;415](https://togithub.com/vercel/nft/issues/415)) ([e001d05](https://togithub.com/vercel/nft/commit/e001d0586804b696849c125dbeefe76ef5a71434))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
kodiakhq bot pushed a commit to X-oss-byte/Nextjs that referenced this pull request Jun 9, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@vercel/nft](https://togithub.com/vercel/nft) | [`0.27.1` -> `0.27.2`](https://renovatebot.com/diffs/npm/@vercel%2fnft/0.26.4/0.27.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vercel%2fnft/0.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vercel%2fnft/0.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vercel%2fnft/0.26.4/0.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vercel%2fnft/0.26.4/0.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>vercel/nft (@&#8203;vercel/nft)</summary>

### [`v0.27.2`](https://togithub.com/vercel/nft/releases/tag/0.27.2)

[Compare Source](https://togithub.com/vercel/nft/compare/0.27.1...0.27.2)

##### Bug Fixes

-   Support browser overrides in package.json ([#&#8203;424](https://togithub.com/vercel/nft/issues/424)) ([ff4341b](https://togithub.com/vercel/nft/commit/ff4341b9c65158bcd2d301f0281cf55d503c3b2b))

### [`v0.27.1`](https://togithub.com/vercel/nft/releases/tag/0.27.1)

[Compare Source](https://togithub.com/vercel/nft/compare/0.27.0...0.27.1)

##### Bug Fixes

-   node-gyp-build for `@datadog/pprof` ([#&#8203;419](https://togithub.com/vercel/nft/issues/419)) ([db6c65a](https://togithub.com/vercel/nft/commit/db6c65ab04d2ead35d1ca65a601b569b10ca2036))

### [`v0.27.0`](https://togithub.com/vercel/nft/releases/tag/0.27.0)

[Compare Source](https://togithub.com/vercel/nft/compare/0.26.5...0.27.0)

##### Features

-   support import assertions ([#&#8203;417](https://togithub.com/vercel/nft/issues/417)) ([ddc5cba](https://togithub.com/vercel/nft/commit/ddc5cbac2361f0b9c9a90e8f905ee53b9dfa7477)), closes [/github.com/vercel/nft/pull/377#issuecomment-1849719137](https://togithub.com//github.com/vercel/nft/pull/377/issues/issuecomment-1849719137)

### [`v0.26.5`](https://togithub.com/vercel/nft/releases/tag/0.26.5)

[Compare Source](https://togithub.com/vercel/nft/compare/0.26.4...0.26.5)

##### Bug Fixes

-   Add special case for Serial Port binary (.node) modules ([#&#8203;415](https://togithub.com/vercel/nft/issues/415)) ([e001d05](https://togithub.com/vercel/nft/commit/e001d0586804b696849c125dbeefe76ef5a71434))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants