-
Notifications
You must be signed in to change notification settings - Fork 1k
set up and run prettier #1076
set up and run prettier #1076
Conversation
I agree that we should use prettier. But we have to deal with ESLint first. |
We should firstly remove the eslint-klopov and use standard eslints |
I have opinions:
I'm fine with whatever order you prefer - Prettier first, then ESLint, or vice verse. |
I prefer the prettier defaults, but that's only because I don't care too much. What does everyone here think? Should we go with the default @leerob suggested? |
I'll fix/update the eslint configs as a follow up PR |
16df5b4
to
a1830c9
Compare
fix test switch to single quote and no semi colon
a1830c9
to
684e550
Compare
I've switched the prettier defaults to |
Think this one is good to merge |
I think after the prettier and eslint work is merged next steps I'd like to take are:
|
Do I need to turn off some of these checks? Which ones do we need? Just the top 3? |
@leerob I think I saw @robertsLando commend on another thread that those 3 are the only required ones at the moment |
Prettier has become the standard for JavaScript formatting. Adding it to the repo makes contribution and PR review easier.