Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

set up and run prettier #1076

Merged
merged 1 commit into from
Mar 25, 2021
Merged

set up and run prettier #1076

merged 1 commit into from
Mar 25, 2021

Conversation

hipstersmoothie
Copy link
Contributor

Prettier has become the standard for JavaScript formatting. Adding it to the repo makes contribution and PR review easier.

@jesec
Copy link
Contributor

jesec commented Mar 24, 2021

I agree that we should use prettier.

But we have to deal with ESLint first.

@robertsLando
Copy link
Contributor

We should firstly remove the eslint-klopov and use standard eslints

@leerob
Copy link
Member

leerob commented Mar 24, 2021

I have opinions:

  • Single quotes
  • No semicolons (can be persuaded)

I'm fine with whatever order you prefer - Prettier first, then ESLint, or vice verse.

@hipstersmoothie
Copy link
Contributor Author

I prefer the prettier defaults, but that's only because I don't care too much. What does everyone here think? Should we go with the default @leerob suggested?

@hipstersmoothie
Copy link
Contributor Author

I'll fix/update the eslint configs as a follow up PR

fix test

switch to single quote and no semi colon
@hipstersmoothie
Copy link
Contributor Author

I've switched the prettier defaults to singleQuote: true to match the format of the current code. Some tests actually have the semi baked in to some of the assertions.

@hipstersmoothie
Copy link
Contributor Author

hipstersmoothie commented Mar 24, 2021

Think this one is good to merge

@hipstersmoothie
Copy link
Contributor Author

I think after the prettier and eslint work is merged next steps I'd like to take are:

  1. TypeScript conversion
  2. Enforce jsDoc on all functions

@leerob
Copy link
Member

leerob commented Mar 24, 2021

Do I need to turn off some of these checks? Which ones do we need? Just the top 3?

@hipstersmoothie
Copy link
Contributor Author

@leerob I think I saw @robertsLando commend on another thread that those 3 are the only required ones at the moment

@leerob leerob merged commit ddf5217 into master Mar 25, 2021
@leerob leerob deleted the prettier branch March 25, 2021 00:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants