This repository has been archived by the owner on Jan 13, 2024. It is now read-only.
Upgrade eslint + move to eslint-config-airbnb-base #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
force-pushed
the
lint
branch
2 times, most recently
from
e76a8df
to
d1284a0
Compare
|
This can be updated now after Prettier has been merged! |
|
Nice job here 😄 🚀 |
robertsLando
suggested changes
Mar 25, 2021
hipstersmoothie
force-pushed
the
lint
branch
2 times, most recently
from
260f4b2
to
334eb94
Compare
|
I have addressed all code review comments 🚀 |
|
Assuming the tests pass, let's merge! |
|
Tests are so slow, takes around 20/30 minutes :( |
|
It's important they pass with a change this large 😄 |
|
Yeah my comment was not about don't wait but just that we should work on that, them should take less then 10 minutes to improve development |
|
Totally agree. Luckily, they passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to standardized tooling and configs. Turned off rules that clashed with how the code is currently written.
This PR should be merged after #1076