-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom entry.server
file in Vercel Vite Preset
#89
Support custom entry.server
file in Vercel Vite Preset
#89
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…1664-allow-for-custom-entryserver-file
Hi @TooTallNate - this is working for me, thanks for that. The only issue I encountered is that my index route (which is under the route _site._index.tsx) does not get compiled, resulting in a 404 error. |
@Gbuomprisco Could you share a repository demonstrating the 404 issue (ideally in a new issue)? |
It seems to work fine in a minimal starter but not with my (largeish) application :| I'll keep testing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test we can write for this?
Co-authored-by: Sean Massa <EndangeredMassa@gmail.com>
@EndangeredMassa Test will be added on the Remix builder side. |
…1664-allow-for-custom-entryserver-file
…' of github.com:vercel/remix into tootallnate/zero-1664-allow-for-custom-entryserver-file
Adds an e2e test fixture which tests that a custom `app/entry.server` file is supported. Related to: * vercel/remix#85 * vercel/remix#89
Allows for a custom
entry.server.jsx
/entery.server.tsx
file to exist in the project. The following heuristics are used to determine whether or not to copy in the Vercel-specificentry.server
file:entry.server
file, then we copy in the Vercel entry serverentry.server
file, then we hash the contents to try to determine if the file has been modified from a known default Remix template[1].@vercel/remix
is being used[1]: There is a script to generate the JSON file containing the sha256sums of the all Remix templates'
entry.server
contents throughout the Git history. For now, I just ran the script manually. In the future, we can set up a GH Action to automate updating the JSON file.To test this out
Install the
@vercel/remix
package from this URL: https://remix-git-tootallnate-zero-1664-allow-for-custom-entryse-6ab7cd.vercel.sh/vercel-remix.tgzYour customized
entry.server
file should be based on this starting point:After that you can deploy to Vercel as usual.