Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont overwrite entry.server in Vite preset #85

Closed
wants to merge 1 commit into from
Closed

Dont overwrite entry.server in Vite preset #85

wants to merge 1 commit into from

Conversation

augustskare
Copy link

Don't replace the entry.server file, only give the user a warning instead. By replacing the entry.server files it breaks integrations with tools like i18next where you want to set up the <I18nextProvider /> in the entry file.

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
remix ✅ Ready (Inspect) Visit Preview Mar 1, 2024 10:39am

@TooTallNate
Copy link
Member

Hi there. Thanks for bringing this up and showing the use case of when a modified entry.server file would be necessary.

It's kind of a tricky situation because the Remix templates now include a default entry.server file implementation, so there's no good indicator as to whether the app actually needs that file (because it has made modifications to it) vs. when they don't need it since it's just the default that was included with the template (in which case, Vercel should supply its version).

@augustskare
Copy link
Author

I get that this is tricky, I see that the documentation now mentions that you should delete your entry.server/client.

I would say that it's quite common to modify both entry.server and entry.client in Remix. Isn't it better to document what's needed in a custom entry.server/client? If your not going to allow this in vercelPreset I'm out of luck and can't deploy to Vercel?

@TooTallNate
Copy link
Member

Ya, I hear you. We're going to make sure your use case is supported. We're evaluating a couple options. Will report back soon.

@TooTallNate
Copy link
Member

Follow along in #89.

@TooTallNate TooTallNate closed this Mar 9, 2024
@augustskare augustskare deleted the feature/vite-entry-server branch March 9, 2024 13:17
kodiakhq bot pushed a commit to vercel/vercel that referenced this pull request Apr 10, 2024
Adds an e2e test fixture which tests that a custom `app/entry.server` file is supported.

Related to:

* vercel/remix#85
* vercel/remix#89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants