Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rel=noopener with fallback #20

Merged
merged 1 commit into from Sep 29, 2016
Merged

Conversation

mathiasbynens
Copy link
Contributor

This ensures that github.com can not mess with the list-powered HTML document in any way.

See https://mathiasbynens.github.io/rel-noopener/ for more information.

This ensures that github.com can not mess with the `list`-powered HTML document in any way.

See https://mathiasbynens.github.io/rel-noopener/ for more information.
@mathiasbynens
Copy link
Contributor Author

An alternate solution (that I’d personally prefer) is to just drop target=_blank instead.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, it's a valid thing 👍

@rauchg rauchg merged commit a5e5c7a into vercel:master Sep 29, 2016
@rauchg
Copy link
Member

rauchg commented Sep 29, 2016

On 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants