Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add cli unit tests #719

merged 10 commits into from Jul 18, 2022

tests: add cli unit tests #719

merged 10 commits into from Jul 18, 2022


Copy link

Related Issues

Closes #709. Supersedes #712.


This PR:

  • adds unit tests for the CLI.
  • adds vitest as a development dependency.
  • refactors some parts to make them easier to test:
    • ParsedEndpoint is now an object.
    • loadConfiguration returns Partial<Configuration instead of Configuration.

Copy link

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good 👍 Should we merge now or is there more you want to do here?

@leerob leerob merged commit 36d60e7 into vercel:main Jul 18, 2022
2 checks passed
Copy link
Contributor Author

I would like to achieve 100% coverage on these files at some point, but other than that I think these tests will help ensure the code works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Add unit tests with vitest
2 participants