Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve test coverage #2903

Merged
merged 2 commits into from
Feb 25, 2024
Merged

chore: Improve test coverage #2903

merged 2 commits into from
Feb 25, 2024

Conversation

shuding
Copy link
Member

@shuding shuding commented Feb 25, 2024

This PR improves the test coverage of SWR to make sure all lines are covered, including special cases that we can't test in the past.

CleanShot-2024-02-25-MX3GwMRb@2x

Main:

CleanShot-2024-02-25-GSyLr6pe@2x

Copy link

codesandbox-ci bot commented Feb 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@shuding shuding marked this pull request as ready for review February 25, 2024 19:07
@shuding shuding requested a review from huozhi as a code owner February 25, 2024 19:07
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/jest@29.5.12 Transitive: environment, filesystem, unsafe +49 5.58 MB types
npm/jest-environment-jsdom@29.7.0 Transitive: environment, eval, filesystem, network, shell, unsafe +110 13.6 MB simenb
npm/jest@29.7.0 Transitive: environment, eval, filesystem, network, shell, unsafe +278 22.8 MB simenb

🚮 Removed packages: npm/@types/jest@29.5.2, npm/jest-environment-jsdom@29.5.0, npm/jest@29.5.0

View full report↗︎

@huozhi huozhi merged commit b103154 into main Feb 25, 2024
8 checks passed
@huozhi huozhi deleted the shu/4air branch February 25, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants