-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: properly propigate internal errors (#8113)
### Description I believe this addresses JavaScriptBach's issue in #8088 We weren't properly propagating unrecoverable errors to `turbo`'s exit code. So things like writing a log file failing could cause a zero exit code even though `turbo` had a failure that left us in a bad state. This PR now propigates internal errors up to the `run` command so it will have a non-zero exit when these are encountered. ### Testing Instructions Force an internal failure like making a log file owned by root Before <img width="965" alt="Screenshot 2024-05-08 at 11 45 19 AM" src="https://github.com/vercel/turbo/assets/4131117/f148809a-7c25-47a3-8b92-f79e1ca27d01"> (Note exit code and the fact that run summary is displayed) After <img width="906" alt="Screenshot 2024-05-08 at 11 39 52 AM" src="https://github.com/vercel/turbo/assets/4131117/d0a0d41c-eda2-4f70-bacc-10cfecc85249"> (Note the non-zero exit code) Closes TURBO-3034
- Loading branch information
1 parent
3e00d0f
commit 2ce4f75
Showing
2 changed files
with
81 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters