fix: properly propigate internal errors #8113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
chris-olszewski
requested review from
arlyon,
codybrouwers and
gsoltis
and removed request for
codybrouwers
gsoltis
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I believe this addresses JavaScriptBach's issue in #8088
We weren't properly propagating unrecoverable errors to
turbo's exit code. So things like writing a log file failing could cause a zero exit code even thoughturbohad a failure that left us in a bad state. This PR now propigates internal errors up to theruncommand so it will have a non-zero exit when these are encountered.Testing Instructions
Force an internal failure like making a log file owned by root
Before
(Note exit code and the fact that run summary is displayed)
After
(Note the non-zero exit code)
Closes TURBO-3034