Skip to content

Commit

Permalink
chore(test): Remove single/double quotes in npm scripts in fixtures (#…
Browse files Browse the repository at this point in the history
…6459)

When running these tests in Windows, these single and double quotes get printed
whereas on Darwin/Linux, they do not. This bug is repoted in npm
npm/cli#6968. It would be possible to workaround
this by matching output in our prysk tests with regex and making the quotation
marks optional, but for most tests that is additional noise that we do not
need, so it is simpler to remove the quotes instead.
  • Loading branch information
mehulkar committed Nov 15, 2023
1 parent 39b0fd4 commit ee71477
Show file tree
Hide file tree
Showing 64 changed files with 301 additions and 301 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "my-app",
"scripts": {
"build": "echo 'building'",
"build": "echo building",
"maybefails": "exit 4"
},
"dependencies": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "util",
"scripts": {
"build": "echo 'building'",
"maybefails": "echo 'did not fail'"
"build": "echo building",
"maybefails": "echo didnotfail"
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "add-keys",
"scripts": {
"add-keys-task": "echo \"running add-keys-task\" > out/foo.min.txt",
"add-keys-underlying-task": "echo \"running add-keys-underlying-task\""
"add-keys-task": "echo running-add-keys-task > out/foo.min.txt",
"add-keys-underlying-task": "echo running-add-keys-underlying-task"
},
"dependencies": {
"blank-pkg": "*"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "add-tasks",
"scripts": {
"added-task": "echo \"running added-task\" > out/foo.min.txt"
"added-task": "echo running-added-task > out/foo.min.txt"
},
"dependencies": {
"blank-pkg": "*"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bad-json",
"scripts": {
"trailing-comma": "echo 'trailing-comma'"
"trailing-comma": "echo trailing-comma"
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "cached",
"scripts": {
"cached-task-1": "echo 'cached-task-1' > out/foo.min.txt",
"cached-task-2": "echo 'cached-task-2' > out/foo.min.txt",
"cached-task-3": "echo 'cached-task-3' > out/foo.min.txt"
"cached-task-1": "echo cached-task-1 > out/foo.min.txt",
"cached-task-2": "echo cached-task-2 > out/foo.min.txt",
"cached-task-3": "echo cached-task-3 > out/foo.min.txt"
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "config-change",
"scripts": {
"config-change-task": "echo 'config-change-task'"
"config-change-task": "echo config-change-task"
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cross-workspace",
"scripts": {
"cross-workspace-task": "echo \"cross-workspace-task\""
"cross-workspace-task": "echo cross-workspace-task"
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "invalid-config",
"scripts": {
"build": "echo 'build invalid-config' > out/foo.min.txt"
"build": "echo build-invalid-config > out/foo.min.txt"
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "missing-workspace-config",
"scripts": {
"missing-workspace-config-task": "echo \"running missing-workspace-config-task\" > out/foo.min.txt",
"missing-workspace-config-task-with-deps": "echo \"running missing-workspace-config-task-with-deps\" > out/foo.min.txt",
"missing-workspace-config-underlying-task": "echo \"running missing-workspace-config-underlying-task\"",
"cached-task-4": "echo 'cached-task-4' > out/foo.min.txt"
"missing-workspace-config-task": "echo running-missing-workspace-config-task > out/foo.min.txt",
"missing-workspace-config-task-with-deps": "echo running-missing-workspace-config-task-with-deps > out/foo.min.txt",
"missing-workspace-config-underlying-task": "echo running-missing-workspace-config-underlying-task",
"cached-task-4": "echo cached-task-4 > out/foo.min.txt"
},
"dependencies": {
"blank-pkg": "*"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "omit-keys",
"scripts": {
"omit-keys-task": "echo \"running omit-keys-task\" > out/foo.min.txt",
"omit-keys-task-with-deps": "echo \"running omit-keys-task-with-deps\" > out/foo.min.txt",
"omit-keys-underlying-task": "echo \"running omit-keys-underlying-task\""
"omit-keys-task": "echo running-omit-keys-task > out/foo.min.txt",
"omit-keys-task-with-deps": "echo running-omit-keys-task-with-deps > out/foo.min.txt",
"omit-keys-underlying-task": "echo running-omit-keys-underlying-task"
},
"devDependencies": {
"blank-pkg": "*"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "override-values",
"scripts": {
"override-values-task": "echo \"running override-values-task\" > lib/bar.min.txt",
"override-values-task-with-deps": "echo \"running override-values-task-with-deps\" > out/foo.min.txt",
"override-values-task-with-deps-2": "echo \"running override-values-task-with-deps-2\" > out/foo2.min.txt",
"override-values-underlying-task": "echo \"running override-values-underlying-task\""
"override-values-task": "echo running-override-values-task > lib/bar.min.txt",
"override-values-task-with-deps": "echo running-override-values-task-with-deps > out/foo.min.txt",
"override-values-task-with-deps-2": "echo running-override-values-task-with-deps-2 > out/foo2.min.txt",
"override-values-underlying-task": "echo running-override-values-underlying-task"
},
"dependencies": {
"blank-pkg": "*"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"name": "persistent",
"scripts": {
"persistent-task-1": "echo 'persistent-task-1'",
"persistent-task-2": "echo 'persistent-task-2'",
"persistent-task-3": "echo 'persistent-task-3'",
"persistent-task-4": "echo 'persistent-task-4'",
"persistent-task-1-parent": "echo 'persistent-task-1-parent'",
"persistent-task-2-parent": "echo 'persistent-task-2-parent'",
"persistent-task-3-parent": "echo 'persistent-task-3-parent'",
"persistent-task-4-parent": "echo 'persistent-task-4-parent'"
"persistent-task-1": "echo persistent-task-1",
"persistent-task-2": "echo persistent-task-2",
"persistent-task-3": "echo persistent-task-3",
"persistent-task-4": "echo persistent-task-4",
"persistent-task-1-parent": "echo persistent-task-1-parent",
"persistent-task-2-parent": "echo persistent-task-2-parent",
"persistent-task-3-parent": "echo persistent-task-3-parent",
"persistent-task-4-parent": "echo persistent-task-4-parent"
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "blank-pkg",
"scripts": {
"omit-keys-underlying-topo-task": "echo \"omit-keys-underlying-topo-task from blank-pkg\"",
"missing-workspace-config-underlying-topo-task": "echo \"missing-workspace-config-underlying-topo-task from blank-pkg\"",
"override-values-underlying-topo-task": "echo \"override-values-underlying-topo-task from blank-pkg\"",
"cross-workspace-underlying-task": "echo \"cross-workspace-underlying-task from blank-pkg\""
"omit-keys-underlying-topo-task": "echo omit-keys-underlying-topo-task from blank-pkg",
"missing-workspace-config-underlying-topo-task": "echo missing-workspace-config-underlying-topo-task from blank-pkg",
"override-values-underlying-topo-task": "echo override-values-underlying-topo-task from blank-pkg",
"cross-workspace-underlying-task": "echo cross-workspace-underlying-task from blank-pkg"
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "a",
"scripts": {
"build": "echo 'building'"
"build": "echo building"
},
"dependencies": {
"has-symbols": "^1.0.3"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "b",
"scripts": {
"build": "echo 'building'"
"build": "echo building"
},
"dependencies": {
"function-bind": "^1.1.1"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "my-app",
"scripts": {
"okay": "echo 'working'",
"okay2": "echo 'working'",
"okay": "echo working",
"okay2": "echo working",
"error": "exit 2"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"shared": "workspace:*"
},
"scripts": {
"new-task": "echo 'running new task'"
"new-task": "echo building"
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "app-a",
"scripts": {
"build": "echo 'build app-a'",
"builderror": "echo \"error builderror app-a!\" && exit 1",
"builderror2": "echo \"error builderror2 app-a!\" && exit 1",
"buildsuccess": "echo \"buildsuccess app-a!\""
"build": "echo build-app-a",
"builderror": "echo error-builderror-app-a && exit 1",
"builderror2": "echo error-builderror2-app-a && exit 1",
"buildsuccess": "echo buildsuccess-app-a"
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "my-pkg",
"scripts": {
"build": "echo 'building' > foo.txt",
"build": "echo building > foo.txt",
"test": "cat foo.txt"
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "workspace-a",
"scripts": {
"build": "echo 'build workspace-a'",
"generate": "echo 'generate workspace-a'"
"build": "echo build-workspace-a",
"generate": "echo generate-workspace-a"
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "workspace-b",
"scripts": {
"build": "echo 'build workspace-b'",
"generate": "echo 'generate workspace-b'"
"build": "echo build-workspace-b",
"generate": "echo generate-workspace-b"
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "my-app",
"scripts": {
"build": "echo 'building'"
"build": "echo building"
},
"dependencies": {
"util": "*"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "util",
"scripts": {
"build": "echo 'building'"
"build": "echo building"
}
}
12 changes: 6 additions & 6 deletions turborepo-tests/integration/tests/dry-json/monorepo.t
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ Setup
"taskId": "my-app#build",
"task": "build",
"package": "my-app",
"hash": "b42768856d16033a",
"hash": "f5b905676d8a275c",
"inputs": {
".env.local": "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391",
"package.json": "6bcf57fd6ff30d1a6f40ad8d8d08e8b940fc7e3b"
"package.json": "1746e0db2361085b5953a6a3beab08c24af5bc08"
},
"hashOfExternalDependencies": "459c029558afe716",
"cache": {
Expand All @@ -63,7 +63,7 @@ Setup
"status": "MISS",
"timeSaved": 0
},
"command": "echo 'building'",
"command": "echo building",
"cliArguments": [],
"outputs": [
"apple.json",
Expand Down Expand Up @@ -113,9 +113,9 @@ Setup
"taskId": "util#build",
"task": "build",
"package": "util",
"hash": "9b9969f14caa05a4",
"hash": "1ce33e04f265f95c",
"inputs": {
"package.json": "4d57bb28c9967640d812981198a743b3188f713e"
"package.json": "e755064fd7893809d10fc067bb409c7ae516327f"
},
"hashOfExternalDependencies": "459c029558afe716",
"cache": {
Expand All @@ -124,7 +124,7 @@ Setup
"status": "MISS",
"timeSaved": 0
},
"command": "echo 'building'",
"command": "echo building",
"cliArguments": [],
"outputs": null,
"excludedOutputs": null,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Setup
"rootKey": "HEY STELLLLLLLAAAAAAAAAAAAA",
"files": {
"package-lock.json": "1c117cce37347befafe3a9cba1b8a609b3600021",
"package.json": "c38e07c8d8d5f851dec8cdbc3d103deed82bc960"
"package.json": "5519edda652c463054307421a3c05ff49f080328"
},
"hashOfExternalDependencies": "",
"globalDotEnv": null,
Expand All @@ -34,11 +34,11 @@ Setup
{
"taskId": "build",
"task": "build",
"hash": "db9ab850083a69be",
"hash": "e46d6df5143cae99",
"inputs": {
".gitignore": "03b541460c1b836f96f9c0a941ceb48e91a9fd83",
"package-lock.json": "1c117cce37347befafe3a9cba1b8a609b3600021",
"package.json": "c38e07c8d8d5f851dec8cdbc3d103deed82bc960",
"package.json": "5519edda652c463054307421a3c05ff49f080328",
"somefile.txt": "45b983be36b73c0788dc9cbcb76cbb80fc7bb057"
},
"hashOfExternalDependencies": "",
Expand All @@ -48,7 +48,7 @@ Setup
"status": "MISS",
"timeSaved": 0
},
"command": "echo 'building' > foo.txt",
"command": "echo building > foo.txt",
"cliArguments": [],
"outputs": null,
"excludedOutputs": null,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Setup
"rootKey": "HEY STELLLLLLLAAAAAAAAAAAAA",
"files": {
"package-lock.json": "1c117cce37347befafe3a9cba1b8a609b3600021",
"package.json": "c38e07c8d8d5f851dec8cdbc3d103deed82bc960",
"package.json": "5519edda652c463054307421a3c05ff49f080328",
"somefile.txt": "45b983be36b73c0788dc9cbcb76cbb80fc7bb057"
},
"hashOfExternalDependencies": "",
Expand All @@ -33,11 +33,11 @@ Setup
{
"taskId": "build",
"task": "build",
"hash": "273cd179351c6ef3",
"hash": "f09bf783beacf5c9",
"inputs": {
".gitignore": "03b541460c1b836f96f9c0a941ceb48e91a9fd83",
"package-lock.json": "1c117cce37347befafe3a9cba1b8a609b3600021",
"package.json": "c38e07c8d8d5f851dec8cdbc3d103deed82bc960",
"package.json": "5519edda652c463054307421a3c05ff49f080328",
"somefile.txt": "45b983be36b73c0788dc9cbcb76cbb80fc7bb057",
"turbo.json": "bf9ddbce36808b6ea5a0ea2b7ceb400ee6c42c4c"
},
Expand All @@ -48,7 +48,7 @@ Setup
"status": "MISS",
"timeSaved": 0
},
"command": "echo 'building' > foo.txt",
"command": "echo building > foo.txt",
"cliArguments": [],
"outputs": [
"foo.txt"
Expand Down Expand Up @@ -89,11 +89,11 @@ Setup
{
"taskId": "test",
"task": "test",
"hash": "f21d7ac37c171ce7",
"hash": "8bfab5dc6b4ccb3b",
"inputs": {
".gitignore": "03b541460c1b836f96f9c0a941ceb48e91a9fd83",
"package-lock.json": "1c117cce37347befafe3a9cba1b8a609b3600021",
"package.json": "c38e07c8d8d5f851dec8cdbc3d103deed82bc960",
"package.json": "5519edda652c463054307421a3c05ff49f080328",
"somefile.txt": "45b983be36b73c0788dc9cbcb76cbb80fc7bb057",
"turbo.json": "bf9ddbce36808b6ea5a0ea2b7ceb400ee6c42c4c"
},
Expand Down
Loading

0 comments on commit ee71477

Please sign in to comment.