chore(test): Remove single/double quotes in npm scripts in fixtures #6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running these tests in Windows, these single and double quotes get printed whereas on Darwin/Linux, they do not. This bug is repoted in npm npm/cli#6968. It would be possible to workaround this by matching output in our prysk tests with regex and making the quotation marks optional, but for most tests that is additional noise that we do not need, so it is simpler to remove the quotes instead.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
gsoltis
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running these tests in Windows, these single and double quotes get printed
whereas on Darwin/Linux, they do not. This bug is repoted in npm
npm/cli#6968. It would be possible to workaround
this by matching output in our prysk tests with regex and making the quotation
marks optional, but for most tests that is additional noise that we do not
need, so it is simpler to remove the quotes instead.
The second commit does the same for basic_monorepo, but is more invasive so I wanted the option of reverting it if we don't want it.
This is extracted from #6279, because it's a large diff and I wanted to have a good commit explaining it.
Closes TURBO-1674