Warn on not-yet-supported module usage #2422

wbinnssmith · 2022-10-27T18:56:42Z

This implements warning on usage of unsupported modules or entire packages, on import.

To help pinpoint the import site, it would be nice to include the complete path of the file requesting the resolve, but at this point the context is the dirname of the requesting file. I imagine this logic could be lifted up, but it seems it would need to be handled across esm, commonjs, type, etc. This centralizes it. Lifted it up to where the complete request origin path is available.

Test Plan:

Given the source:

import og from "@vercel/og";
import font from "@next/font";
import head from "next/head";

Turbopack warns with:


  [resolve]
    /path/to/testapp/src/index.jsx
      Unsupported module
      The module next/head is not yet supported

      Unsupported module
      The package @next/font is not yet supported

      Unsupported module
      The package @vercel/og is not yet supported

vercel · 2022-10-27T18:56:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-basic-web	✅ Ready (Inspect)	Visit Preview		Oct 28, 2022 at 10:34PM (UTC)
examples-designsystem-docs	✅ Ready (Inspect)	Visit Preview		Oct 28, 2022 at 10:34PM (UTC)
examples-kitchensink-blog	✅ Ready (Inspect)	Visit Preview		Oct 28, 2022 at 10:34PM (UTC)
examples-native-web	✅ Ready (Inspect)	Visit Preview		Oct 28, 2022 at 10:34PM (UTC)
examples-svelte-web	✅ Ready (Inspect)	Visit Preview		Oct 28, 2022 at 10:34PM (UTC)
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Oct 28, 2022 at 10:34PM (UTC)

jridgewell · 2022-10-27T19:25:03Z

crates/turbopack-core/src/resolve/mod.rs

@@ -650,6 +661,37 @@ pub async fn resolve(
            )
        }
        Request::Module { module, path } => {
+            // Warn if the package is known not to be supported by Turbopack at the moment.
+            if UNSUPPORTED_PACKAGES.contains(module) {
+                UnsupportedModuleIssue {


Can we isolate the source position for this import? https://github.com/vercel/turbo/blob/wbinnssmith/warn-unsupported-modules/crates/turbopack-core/src/issue/mod.rs#L117-L122

Yeah, I'd really like that. Unfortunately even the context path isn't the importing file — it's the dirname (I imagine because this is the context necessary for resolution). I'm going to see if I can move issue creation closer to the import site, but this was the most centralized place for now. The context is now correct.

crates/turbopack-core/src/resolve/mod.rs

crates/turbopack/src/lib.rs

wbinnssmith requested review from sokra and alexkirsz October 27, 2022 18:56

wbinnssmith added the area: turbopack label Oct 27, 2022

jridgewell reviewed Oct 27, 2022

View reviewed changes

wbinnssmith marked this pull request as draft October 27, 2022 20:51

wbinnssmith force-pushed the wbinnssmith/warn-unsupported-modules branch from c01ad84 to 0083fde Compare October 27, 2022 22:07

vercel bot deployed to Preview – turbo-site October 27, 2022 22:08 View deployment

wbinnssmith marked this pull request as ready for review October 27, 2022 22:10

wbinnssmith force-pushed the wbinnssmith/warn-unsupported-modules branch from 0083fde to df376e5 Compare October 27, 2022 22:11

vercel bot deployed to Preview – turbo-site October 27, 2022 22:12 View deployment

jridgewell approved these changes Oct 27, 2022

View reviewed changes

jaredpalmer requested a review from a team as a code owner October 28, 2022 00:14

jaredpalmer requested changes Oct 28, 2022

View reviewed changes

crates/turbopack/src/lib.rs Outdated Show resolved Hide resolved

vercel bot deployed to Preview – turbo-site October 28, 2022 00:15 View deployment

ForsakenHarmony approved these changes Oct 28, 2022

View reviewed changes

wbinnssmith requested a review from jaredpalmer October 28, 2022 00:58

wbinnssmith force-pushed the wbinnssmith/warn-unsupported-modules branch from 8bd954c to f8c88f5 Compare October 28, 2022 00:59

Warn on not-yet-supported module usage

6d7b9f3

wbinnssmith force-pushed the wbinnssmith/warn-unsupported-modules branch from f8c88f5 to 6d7b9f3 Compare October 28, 2022 00:59

vercel bot deployed to Preview – turbo-site October 28, 2022 01:03 View deployment

Merge branch 'main' into wbinnssmith/warn-unsupported-modules

05c97a2

vercel bot deployed to Preview – examples-svelte-web October 28, 2022 22:33 View deployment

vercel bot deployed to Preview – examples-basic-web October 28, 2022 22:33 View deployment

vercel bot deployed to Preview – turbo-site October 28, 2022 22:33 View deployment

vercel bot deployed to Preview – examples-native-web October 28, 2022 22:34 View deployment

vercel bot deployed to Preview – examples-kitchensink-blog October 28, 2022 22:34 View deployment

vercel bot deployed to Preview – examples-designsystem-docs October 28, 2022 22:34 View deployment

jridgewell approved these changes Oct 29, 2022

View reviewed changes

jridgewell merged commit 7f6e4be into main Oct 29, 2022

jridgewell deleted the wbinnssmith/warn-unsupported-modules branch October 29, 2022 00:22

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024

Warn on not-yet-supported module usage (vercel/turborepo#2422)

700c2a5

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024

Warn on not-yet-supported module usage (vercel/turborepo#2422)

445106b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warn on not-yet-supported module usage #2422

Warn on not-yet-supported module usage #2422

wbinnssmith commented Oct 27, 2022 •

edited

Loading

vercel bot commented Oct 27, 2022 •

edited

Loading

jridgewell Oct 27, 2022

wbinnssmith Oct 27, 2022 •

edited

Loading

Warn on not-yet-supported module usage #2422

Warn on not-yet-supported module usage #2422

Conversation

wbinnssmith commented Oct 27, 2022 • edited Loading

vercel bot commented Oct 27, 2022 • edited Loading

jridgewell Oct 27, 2022

Choose a reason for hiding this comment

wbinnssmith Oct 27, 2022 • edited Loading

Choose a reason for hiding this comment

wbinnssmith commented Oct 27, 2022 •

edited

Loading

vercel bot commented Oct 27, 2022 •

edited

Loading

wbinnssmith Oct 27, 2022 •

edited

Loading