CLI papercuts #277
Merged
CLI papercuts #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/48wuHkbgzrZMKQq3diFtHmCtGvNQ |
sokra
added a commit
that referenced
this pull request
Oct 25, 2022
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
This: * Runs `npm install` in test directories to provide turbopack with modules necessary to bundle them. * Reuses test directories for iterations across the given benchmark. This prevents unnecessary file writing and `npm install` for each iteration, improving the times to run benchmarks. Currently cherry-picks #278 as it's necessary along with #277. Test Plan: Connected to the running devserver mid-test and confirmed no errors are thrown and the triangle is rendered correctly.
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
Co-authored-by: Nathan Hammond <nathan.hammond@vercel.com>
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…urbo#284) This: * Runs `npm install` in test directories to provide turbopack with modules necessary to bundle them. * Reuses test directories for iterations across the given benchmark. This prevents unnecessary file writing and `npm install` for each iteration, improving the times to run benchmarks. Currently cherry-picks vercel/turbo#278 as it's necessary along with vercel/turbo#277. Test Plan: Connected to the running devserver mid-test and confirmed no errors are thrown and the triangle is rendered correctly.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…urbo#284) This: * Runs `npm install` in test directories to provide turbopack with modules necessary to bundle them. * Reuses test directories for iterations across the given benchmark. This prevents unnecessary file writing and `npm install` for each iteration, improving the times to run benchmarks. Currently cherry-picks vercel/turbo#278 as it's necessary along with vercel/turbo#277. Test Plan: Connected to the running devserver mid-test and confirmed no errors are thrown and the triangle is rendered correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping this as a bandaid now so I can focus my attention on #218