set `__NEXT_STRICT_MODE` #2878

ForsakenHarmony · 2022-11-30T17:44:26Z

and __NEXT_STRICT_MODE_APP

vercel · 2022-11-30T17:44:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-nonmonorepo	🔄 Building (Inspect)			Dec 19, 2022 at 4:37PM (UTC)
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Dec 19, 2022 at 4:37PM (UTC)

6 Ignored Deployments

Name	Status	Updated
examples-basic-web	⬜️ Ignored (Inspect)	Dec 19, 2022 at 4:37PM (UTC)
examples-cra-web	⬜️ Ignored (Inspect)	Dec 19, 2022 at 4:37PM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)	Dec 19, 2022 at 4:37PM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Dec 19, 2022 at 4:37PM (UTC)
examples-native-web	⬜️ Ignored (Inspect)	Dec 19, 2022 at 4:37PM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)	Dec 19, 2022 at 4:37PM (UTC)

github-actions · 2022-11-30T17:53:22Z

🟢 CI successful 🟢

Thanks

crates/next-core/src/env.rs

github-actions · 2022-11-30T19:17:42Z

Benchmark for `80f9a6a`

Test	Base	PR	%	Significant %
bench_hydration/Turbopack RCC/1000 modules	4119.67ms ± 42.42ms	3924.21ms ± 54.41ms	-4.74%	-0.05%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	8610.20µs ± 57.95µs	8649.80µs ± 120.40µs	+0.46%
bench_hmr_to_commit/Turbopack RCC/1000 modules	8902.22µs ± 68.19µs	9012.68µs ± 43.86µs	+1.24%
bench_hmr_to_commit/Turbopack RSC/1000 modules	792.95ms ± 21.05ms	804.81ms ± 10.06ms	+1.50%
bench_hmr_to_commit/Turbopack SSR/1000 modules	8729.97µs ± 56.56µs	8682.06µs ± 39.56µs	-0.55%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7414.14µs ± 93.62µs	7704.71µs ± 166.81µs	+3.92%
bench_hmr_to_eval/Turbopack RCC/1000 modules	7638.21µs ± 60.03µs	7706.08µs ± 103.71µs	+0.89%
bench_hmr_to_eval/Turbopack SSR/1000 modules	7524.57µs ± 48.01µs	7542.34µs ± 75.99µs	+0.24%
bench_hydration/Turbopack RCC/1000 modules	4119.67ms ± 42.42ms	3924.21ms ± 54.41ms	-4.74%	-0.05%
bench_hydration/Turbopack RSC/1000 modules	2975.21ms ± 44.79ms	2869.52ms ± 27.49ms	-3.55%
bench_hydration/Turbopack SSR/1000 modules	3041.16ms ± 54.61ms	2908.35ms ± 24.79ms	-4.37%
bench_startup/Turbopack CSR/1000 modules	1627.52ms ± 6.05ms	1619.74ms ± 3.95ms	-0.48%
bench_startup/Turbopack RCC/1000 modules	2898.77ms ± 60.29ms	2978.57ms ± 82.90ms	+2.75%
bench_startup/Turbopack RSC/1000 modules	2480.13ms ± 43.78ms	2405.07ms ± 32.14ms	-3.03%
bench_startup/Turbopack SSR/1000 modules	2138.32ms ± 45.19ms	2089.56ms ± 24.17ms	-2.28%

ForsakenHarmony · 2022-12-19T15:46:07Z

Current dependencies on/for this PR:

main
- PR set __NEXT_STRICT_MODE #2878 👈

This comment was auto-generated by Graphite.

sokra · 2022-12-19T15:59:59Z

crates/next-core/src/env.rs

+        "__NEXT_IMAGE_OPTS".to_string() => serde_json::to_string(&image_config).unwrap(),
+    };
+
+    if config.react_strict_mode.unwrap_or(false) {


Suggested change

if config.react_strict_mode.unwrap_or(false) {

if next_config.react_strict_mode.unwrap_or(false) {

sokra · 2022-12-19T16:00:05Z

crates/next-core/src/env.rs

+        map.insert("__NEXT_STRICT_MODE".to_string(), "true".to_string());
+    }
+
+    if config.react_strict_mode.unwrap_or(true) {


Suggested change

if config.react_strict_mode.unwrap_or(true) {

if next_config.react_strict_mode.unwrap_or(true) {

ah yea, bad rebase

seems my brain is still not fully recovered

github-actions · 2022-12-19T17:51:11Z

Benchmark for `18976a6`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	7859.52µs ± 101.61µs	8233.62µs ± 157.88µs	+4.76%
bench_hmr_to_commit/Turbopack RCC/1000 modules	8861.83µs ± 81.50µs	8922.67µs ± 117.39µs	+0.69%
bench_hmr_to_commit/Turbopack RSC/1000 modules	801.51ms ± 15.17ms	806.27ms ± 14.53ms	+0.59%
bench_hmr_to_commit/Turbopack SSR/1000 modules	7895.58µs ± 97.24µs	7901.17µs ± 97.64µs	+0.07%
bench_hmr_to_eval/Turbopack CSR/1000 modules	6704.26µs ± 40.68µs	6812.48µs ± 51.96µs	+1.61%
bench_hmr_to_eval/Turbopack RCC/1000 modules	6753.77µs ± 64.82µs	6992.41µs ± 108.42µs	+3.53%
bench_hmr_to_eval/Turbopack SSR/1000 modules	6877.54µs ± 60.78µs	6716.79µs ± 52.40µs	-2.34%
bench_hydration/Turbopack RCC/1000 modules	3850.54ms ± 24.03ms	3832.12ms ± 34.74ms	-0.48%
bench_hydration/Turbopack RSC/1000 modules	2977.88ms ± 46.03ms	2933.22ms ± 33.97ms	-1.50%
bench_hydration/Turbopack SSR/1000 modules	3278.24ms ± 10.21ms	3239.98ms ± 20.16ms	-1.17%
bench_startup/Turbopack CSR/1000 modules	1768.87ms ± 6.18ms	1736.41ms ± 14.47ms	-1.84%
bench_startup/Turbopack RCC/1000 modules	3006.81ms ± 25.39ms	3042.37ms ± 14.56ms	+1.18%
bench_startup/Turbopack RSC/1000 modules	2578.48ms ± 43.00ms	2593.45ms ± 43.69ms	+0.58%
bench_startup/Turbopack SSR/1000 modules	2676.22ms ± 12.63ms	2671.71ms ± 12.91ms	-0.17%

Seems #2878 removed this accidentally

and `__NEXT_STRICT_MODE_APP`

Seems vercel/turbo#2878 removed this accidentally

and `__NEXT_STRICT_MODE_APP`

Seems vercel/turbo#2878 removed this accidentally

github-actions bot added the area: turbopack label Nov 30, 2022

ForsakenHarmony force-pushed the hrmny/web-212-set-next_strict_mode branch from 3332242 to 6ecbbfb Compare November 30, 2022 18:02

ForsakenHarmony mentioned this pull request Nov 30, 2022

pass reactStrictMode to turbopack vercel/next.js#43575

Closed

jridgewell reviewed Nov 30, 2022

View reviewed changes

crates/next-core/src/env.rs Outdated Show resolved Hide resolved

ForsakenHarmony force-pushed the hrmny/web-212-set-next_strict_mode branch from 6ecbbfb to e04d771 Compare December 19, 2022 15:45

vercel bot deployed to Preview – turbo-site December 19, 2022 15:46 View deployment

ForsakenHarmony marked this pull request as ready for review December 19, 2022 15:46

ForsakenHarmony requested a review from a team as a code owner December 19, 2022 15:46

sokra approved these changes Dec 19, 2022

View reviewed changes

set __NEXT_STRICT_MODE

23d5a1e

ForsakenHarmony force-pushed the hrmny/web-212-set-next_strict_mode branch from e04d771 to 23d5a1e Compare December 19, 2022 16:37

vercel bot deployed to Preview – turbo-site December 19, 2022 16:37 View deployment

ForsakenHarmony merged commit 812895c into main Dec 19, 2022

ForsakenHarmony deleted the hrmny/web-212-set-next_strict_mode branch December 19, 2022 17:43

jridgewell added a commit that referenced this pull request Dec 19, 2022

Add clap macros for is_next_dev_command

b2ec710

Seems #2878 removed this accidentally

jridgewell mentioned this pull request Dec 19, 2022

Add clap macros for is_next_dev_command #3073

Merged

ForsakenHarmony pushed a commit that referenced this pull request Dec 19, 2022

Add clap macros for is_next_dev_command (#3073)

ba3a171

Seems #2878 removed this accidentally

jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023

set __NEXT_STRICT_MODE (vercel/turbo#2878)

bf55b35

and `__NEXT_STRICT_MODE_APP`

jridgewell added a commit to vercel/next.js that referenced this pull request Mar 10, 2023

Add clap macros for is_next_dev_command (vercel/turbo#3073)

d78ad79

Seems vercel/turbo#2878 removed this accidentally

sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023

set __NEXT_STRICT_MODE (vercel/turbo#2878)

1a66a2a

and `__NEXT_STRICT_MODE_APP`

sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023

Add clap macros for is_next_dev_command (vercel/turbo#3073)

df7fa75

Seems vercel/turbo#2878 removed this accidentally

DuCanhGH mentioned this pull request Mar 15, 2023

Fix(typedRoutes): fixed files from directories other than pages and app getting into Route vercel/next.js#47184

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

set `__NEXT_STRICT_MODE` #2878

set `__NEXT_STRICT_MODE` #2878

ForsakenHarmony commented Nov 30, 2022 •

edited

vercel bot commented Nov 30, 2022 •

edited

github-actions bot commented Nov 30, 2022 •

edited

github-actions bot commented Nov 30, 2022

ForsakenHarmony commented Dec 19, 2022

sokra Dec 19, 2022

sokra Dec 19, 2022

ForsakenHarmony Dec 19, 2022 •

edited

github-actions bot commented Dec 19, 2022

	if config.react_strict_mode.unwrap_or(false) {
	if next_config.react_strict_mode.unwrap_or(false) {

	if config.react_strict_mode.unwrap_or(true) {
	if next_config.react_strict_mode.unwrap_or(true) {

set __NEXT_STRICT_MODE #2878

set __NEXT_STRICT_MODE #2878

Conversation

ForsakenHarmony commented Nov 30, 2022 • edited

vercel bot commented Nov 30, 2022 • edited

github-actions bot commented Nov 30, 2022 • edited

🟢 CI successful 🟢

github-actions bot commented Nov 30, 2022

Benchmark for 80f9a6a

ForsakenHarmony commented Dec 19, 2022

sokra Dec 19, 2022

Choose a reason for hiding this comment

sokra Dec 19, 2022

Choose a reason for hiding this comment

ForsakenHarmony Dec 19, 2022 • edited

Choose a reason for hiding this comment

github-actions bot commented Dec 19, 2022

Benchmark for 18976a6

set `__NEXT_STRICT_MODE` #2878

set `__NEXT_STRICT_MODE` #2878

ForsakenHarmony commented Nov 30, 2022 •

edited

vercel bot commented Nov 30, 2022 •

edited

github-actions bot commented Nov 30, 2022 •

edited

Benchmark for `80f9a6a`

ForsakenHarmony Dec 19, 2022 •

edited

Benchmark for `18976a6`