Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clap macros for is_next_dev_command #3073

Merged
merged 2 commits into from Dec 19, 2022
Merged

Add clap macros for is_next_dev_command #3073

merged 2 commits into from Dec 19, 2022

Conversation

jridgewell
Copy link
Contributor

Seems #2878 removed this accidentally

@jridgewell
Add clap macros for is_next_dev_command
b2ec710 
Seems #2878 removed this accidentally
@jridgewell jridgewell requested a review from a team as a code owner December 19, 2022 18:45
@jridgewell jridgewell added the pr: automerge Kodiak will merge these automatically after checks pass label Dec 19, 2022
@vercel
Copy link

vercel bot commented Dec 19, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-kitchensink-blog 🔄 Building (Inspect) Dec 19, 2022 at 6:46PM (UTC)
examples-svelte-web 🔄 Building (Inspect) Dec 19, 2022 at 6:46PM (UTC)
6 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Dec 19, 2022 at 6:46PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Dec 19, 2022 at 6:46PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Dec 19, 2022 at 6:46PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Dec 19, 2022 at 6:46PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Dec 19, 2022 at 6:46PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2022 at 6:46PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2022 •
edited

🟢 CI successful 🟢

Thanks

ForsakenHarmony
ForsakenHarmony approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@ForsakenHarmony ForsakenHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, was just trying to make these consistent

@ForsakenHarmony ForsakenHarmony merged commit ba3a171 into main Dec 19, 2022
@ForsakenHarmony ForsakenHarmony deleted the jrl-cargo-server branch December 19, 2022 19:28
@github-actions
Copy link
Contributor

Benchmark for 290854b

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8640.56µs ± 76.56µs 8687.08µs ± 65.65µs +0.54%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8857.09µs ± 61.10µs 8887.10µs ± 75.91µs +0.34%
bench_hmr_to_commit/Turbopack RSC/1000 modules 837.96ms ± 13.80ms 806.38ms ± 9.99ms -3.77%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8608.20µs ± 68.81µs 8603.35µs ± 69.32µs -0.06%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7619.10µs ± 58.73µs 7568.05µs ± 79.94µs -0.67%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7841.54µs ± 75.48µs 7714.73µs ± 69.67µs -1.62%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7583.35µs ± 37.96µs 7582.63µs ± 70.93µs -0.01%
bench_hydration/Turbopack RCC/1000 modules 3984.18ms ± 23.91ms 3942.53ms ± 32.06ms -1.05%
bench_hydration/Turbopack RSC/1000 modules 3131.46ms ± 42.28ms 3045.84ms ± 54.57ms -2.73%
bench_hydration/Turbopack SSR/1000 modules 3367.53ms ± 12.03ms 3312.84ms ± 32.95ms -1.62%
bench_startup/Turbopack CSR/1000 modules 1786.87ms ± 16.62ms 1819.43ms ± 3.77ms +1.82%
bench_startup/Turbopack RCC/1000 modules 3097.53ms ± 30.47ms 3090.42ms ± 22.05ms -0.23%
bench_startup/Turbopack RSC/1000 modules 2683.42ms ± 37.86ms 2710.61ms ± 47.18ms +1.01%
bench_startup/Turbopack SSR/1000 modules 2753.51ms ± 8.85ms 2730.14ms ± 12.22ms -0.85%

jridgewell added a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@jridgewell
Add clap macros for is_next_dev_command (vercel/turbo#3073)
d78ad79 
Seems vercel/turbo#2878 removed this accidentally
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@jridgewell
Add clap macros for is_next_dev_command (vercel/turbo#3073)
df7fa75 
Seems vercel/turbo#2878 removed this accidentally
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@kwonoj kwonoj Awaiting requested review from kwonoj

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jridgewell @sokra @ForsakenHarmony