Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrying when port already bound #3114

Merged
merged 1 commit into from Dec 21, 2022
Merged

Fix retrying when port already bound #3114

merged 1 commit into from Dec 21, 2022

Conversation

jridgewell
Copy link
Contributor

#3021 removed 1 level of error wrapping, and the unwrapping code was not updated to match.

@jridgewell jridgewell requested a review from a team as a code owner December 21, 2022 20:08
@vercel
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Dec 21, 2022 at 8:08PM (UTC)
7 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Dec 21, 2022 at 8:08PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Dec 21, 2022 at 8:08PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Dec 21, 2022 at 8:08PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Dec 21, 2022 at 8:08PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Dec 21, 2022 at 8:08PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Dec 21, 2022 at 8:08PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Dec 21, 2022 at 8:08PM (UTC)

@jridgewell
Copy link
Contributor Author

Manually verified, merging to unblock release.

@jridgewell jridgewell merged commit d5deace into main Dec 21, 2022
@jridgewell jridgewell deleted the jrl-retry-port branch December 21, 2022 20:15
@github-actions
Copy link
Contributor

Benchmark for e0fb040

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8477.73µs ± 58.49µs 8464.75µs ± 72.02µs -0.15%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8728.12µs ± 78.64µs 8824.11µs ± 80.23µs +1.10%
bench_hmr_to_commit/Turbopack RSC/1000 modules 486.41ms ± 2.66ms 494.31ms ± 1.64ms +1.62%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8461.18µs ± 81.95µs 8421.35µs ± 47.86µs -0.47%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7422.58µs ± 50.74µs 7410.05µs ± 67.49µs -0.17%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7544.28µs ± 97.78µs 7584.53µs ± 66.35µs +0.53%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7472.50µs ± 54.17µs 7465.11µs ± 58.05µs -0.10%
bench_hydration/Turbopack RCC/1000 modules 3410.49ms ± 10.47ms 3421.62ms ± 17.01ms +0.33%
bench_hydration/Turbopack RSC/1000 modules 2855.95ms ± 8.53ms 2866.90ms ± 9.74ms +0.38%
bench_hydration/Turbopack SSR/1000 modules 2669.20ms ± 9.29ms 2690.67ms ± 6.60ms +0.80%
bench_startup/Turbopack CSR/1000 modules 1672.89ms ± 5.25ms 1669.98ms ± 5.22ms -0.17%
bench_startup/Turbopack RCC/1000 modules 2568.57ms ± 8.59ms 2538.28ms ± 8.47ms -1.18%
bench_startup/Turbopack RSC/1000 modules 2430.16ms ± 6.90ms 2443.97ms ± 10.37ms +0.57%
bench_startup/Turbopack SSR/1000 modules 2076.56ms ± 5.38ms 2086.51ms ± 4.09ms +0.48%

@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants