Misc fixes to starting dev server #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
- The 10th attempt used to day "trying again" and then didn't try again because the iterator ended… - Swaps a nested `.map() == Some(bool)` for a `and_then` - Extracts into a helper function so code can early return without an Option<Result> wrapper.
jridgewell
force-pushed
the
jrl-dev_server-fixes
branch
from
f4e35b9
to
c135e88
Compare
🟢 CI successful 🟢Thanks |
Benchmark for 5f2629f
Click to view full benchmark
|
jridgewell
added
the
pr: automerge
Benchmark for 7925de8
Click to view full benchmark
|
Benchmark for 7b42a5b
Click to view full benchmark
|
alexkirsz
approved these changes
Dec 22, 2022
| /// Attempts to find an open port to bind. | ||
| fn find_port(&self, host: IpAddr, port: u16, max_attempts: u16) -> Result<DevServerBuilder> { | ||
| // max_attempts of 1 means we loop 0 times. | ||
| let max_attempts = max_attempts - 1; |
There was a problem hiding this comment.
Could this argument be "retry" instead? That way we avoid integer underflow altogether. In any case, the semantics of max_attempts = 0 are not very clear. You could also use https://doc.rust-lang.org/beta/std/num/struct.NonZeroU16.html.
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
- The 10th attempt used to day "trying again" and then didn't try again because the iterator ended… - Swaps a nested `.map() == Some(bool)` for a `and_then` - Extracts into a helper function so code can early return without an `Option<Result>` wrapper.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
- The 10th attempt used to day "trying again" and then didn't try again because the iterator ended… - Swaps a nested `.map() == Some(bool)` for a `and_then` - Extracts into a helper function so code can early return without an `Option<Result>` wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.map() == Some(bool)for aand_thenOption<Result>wrapper.