Allow CombinedContentSource to need data without locking up #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
Benchmark for 2ca490c
Click to view full benchmark
|
alexkirsz
approved these changes
Dec 22, 2022
|
|
||
| /// The paused state (partially processed path, content source, vary data) | ||
| /// of the internal content source which asked for vary data. | ||
| pending: Option<NeededData>, |
There was a problem hiding this comment.
Nit: Since we don't actually use pending.vary, this should be its own PausableCombinedContentSourcePendingState struct with only a path and a source.
That way, you would not need the fiddling below.
jridgewell
added
the
pr: automerge
Benchmark for afc9836Click to view benchmark
|
Benchmark for a9d1ec0
Click to view full benchmark
|
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…urbo#3124) Currently when an individual `ContentSource` inside a `CombinedContentSource` requests additional vary data, the combined source will treat that source as the winner of the query. But, sometimes the vary data is necessary to determine that the content is not found by this source. And if that's the case, we'll hit a 404 when we should actually keep iterating. This is exactly the case we're going to hit with redirect/rewrites. Redirects need to be the very first content source, and I also need query/header/cookie/hostname data in order to determine if a redirect applies. Without this, **every** request becomes a 404.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…urbo#3124) Currently when an individual `ContentSource` inside a `CombinedContentSource` requests additional vary data, the combined source will treat that source as the winner of the query. But, sometimes the vary data is necessary to determine that the content is not found by this source. And if that's the case, we'll hit a 404 when we should actually keep iterating. This is exactly the case we're going to hit with redirect/rewrites. Redirects need to be the very first content source, and I also need query/header/cookie/hostname data in order to determine if a redirect applies. Without this, **every** request becomes a 404.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when an individual
ContentSourceinside aCombinedContentSourcerequests additional vary data, the combined source will treat that source as the winner of the query. But, sometimes the vary data is necessary to determine that the content is not found by this source. And if that's the case, we'll hit a 404 when we should actually keep iterating.This is exactly the case we're going to hit with redirect/rewrites. Redirects need to be the very first content source, and I also need query/header/cookie/hostname data in order to determine if a redirect applies. Without this, every request becomes a 404.