Basic @next/font/google integration test #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
wbinnssmith
force-pushed
the
wbinnssmith/font-google-integration-tests
branch
from
1abb7f5
to
72328f9
Compare
wbinnssmith
force-pushed
the
wbinnssmith/font-google-integration-tests
branch
from
72328f9
to
2569879
Compare
wbinnssmith
commented
Jan 4, 2023
crates/next-dev/tests/integration.rs
Outdated
| if font_dir.exists() { | ||
| let server = create_font_server(&font_dir); | ||
| env::set_var( | ||
| "TURBOPACK_TEST_ONLY_GOOGLE_FONTS_STYLESHEET_URL", |
There was a problem hiding this comment.
I think this should be okay with the way cargo test/cargo nexttest run tests in parallel, with multiple threads but only one test running in serial within the thread (see unsetting this value below)
🟢 CI successful 🟢Thanks |
Benchmark for 32f99d1Click to view benchmark
|
wbinnssmith
commented
Jan 4, 2023
...t/font-google/basic/__google_fonts__/css2?family=Inter:ital,wght@0,100..900&display=optional
Outdated
Show resolved
Hide resolved
wbinnssmith
force-pushed
the
wbinnssmith/font-google-integration-tests
branch
from
2569879
to
dab5e26
Compare
Benchmark for 49633dc
Click to view full benchmark
|
wbinnssmith
force-pushed
the
wbinnssmith/font-google-integration-tests
branch
from
dab5e26
to
c4b4899
Compare
Benchmark for 690d299Click to view benchmark
|
sokra
requested changes
Jan 9, 2023
Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
wbinnssmith
force-pushed
the
wbinnssmith/font-google-integration-tests
branch
from
c4b4899
to
4fe7fcc
Compare
Benchmark for becd4c6
Click to view full benchmark
|
Benchmark for 7bc2b92
Click to view full benchmark
|
|
@alexkirsz it looks like this test caught a regression from #3184, which made the next-font transform no longer run. |
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
This: * Implements a basic http server to mock returning a stylesheet from the Google Fonts API (**Note**: This importantly does *not* mock returning the font resources themselves, which are currently loaded by the browser. We should implement something to do this when we implement caching arbitrary http resources traced from `url()` and this is no longer loaded by the test browser) * Adds an integration test that asserts the basic shape of the JS object returned by font functions * ~Adds an integration test that asserts the browser correctly loads a font for the ascii unicode range, along with the appropriate `font-display`, variant, etc.~ Unfortunately `document.fonts` is not reliable with different font-display loading patterns as any of them can fall back. As noted, this does not mock responses from Google for the font resources themselves, which are currently loaded by the test browser. This means that we'll be dependent on this external service for passing integration tests until we implement caching of `url()`s in Turbopack. We should monitor the reliability of this test.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
This: * Implements a basic http server to mock returning a stylesheet from the Google Fonts API (**Note**: This importantly does *not* mock returning the font resources themselves, which are currently loaded by the browser. We should implement something to do this when we implement caching arbitrary http resources traced from `url()` and this is no longer loaded by the test browser) * Adds an integration test that asserts the basic shape of the JS object returned by font functions * ~Adds an integration test that asserts the browser correctly loads a font for the ascii unicode range, along with the appropriate `font-display`, variant, etc.~ Unfortunately `document.fonts` is not reliable with different font-display loading patterns as any of them can fall back. As noted, this does not mock responses from Google for the font resources themselves, which are currently loaded by the test browser. This means that we'll be dependent on this external service for passing integration tests until we implement caching of `url()`s in Turbopack. We should monitor the reliability of this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
url()and this is no longer loaded by the test browser)Adds an integration test that asserts the browser correctly loads a font for the ascii unicode range, along with the appropriateUnfortunatelyfont-display, variant, etc.document.fontsis not reliable with different font-display loading patterns as any of them can fall back.As noted, this does not mock responses from Google for the font resources themselves, which are currently loaded by the test browser. This means that we'll be dependent on this external service for passing integration tests until we implement caching of
url()s in Turbopack. We should monitor the reliability of this test.