NodeProcessPool: implement debug mode for a single-process passing --inspect-brk #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
wbinnssmith
force-pushed
the
wbinnssmith/node-js-debug
branch
from
83cb44a
to
aa47636
Compare
🟢 CI successful 🟢Thanks |
jridgewell
approved these changes
Jan 19, 2023
wbinnssmith
added
the
pr: automerge
Benchmark for 02c5e1cClick to view benchmark
|
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…inspect-brk (vercel/turbo#3385) This implements a debug mode for spawning Node processes across multiple surfaces including `evaluate` and `get_renderer_pool`. It: * automatically limits concurrency to 1 process per pool * passes `--inspect-brk` to spawned Node process * sets the timeout to effectively-infinite duration Test Plan: set the value to true for the call to `get_renderer_pool` in render_static.rs and attached to a debuggable server renderer process.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…inspect-brk (vercel/turbo#3385) This implements a debug mode for spawning Node processes across multiple surfaces including `evaluate` and `get_renderer_pool`. It: * automatically limits concurrency to 1 process per pool * passes `--inspect-brk` to spawned Node process * sets the timeout to effectively-infinite duration Test Plan: set the value to true for the call to `get_renderer_pool` in render_static.rs and attached to a debuggable server renderer process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a debug mode for spawning Node processes across multiple surfaces including
evaluateandget_renderer_pool.It:
--inspect-brkto spawned Node processTest Plan: set the value to true for the call to
get_renderer_poolin render_static.rs and attached to a debuggable server renderer process.