Snapshot issues in next-dev-tests #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This: * Adds issue snapshot support to next-dev-tests. This will allow us to assert that certain issues are raised in tests that require next-dev. * Extracts common snapshot code into a new crates, `turbopack-test-utils`, which is shared between snapshot tests and next-dev-tests. * Implements an issue reporter that emits issues in a channel to the the integration test code, where they are snapshotted. * Fixes an issue where next-dev tests that were not Next.js apps would emit non-fatal issues for a missing `pages/` directory. Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
jridgewell
reviewed
Feb 13, 2023
Benchmark for 97d1b38
Click to view full benchmark
|
jridgewell
approved these changes
Feb 13, 2023
jridgewell
suggested changes
Feb 14, 2023
...issues/lint TP1004 fs.readFileSync(???__star__0__star__, "utf-8") is very dynamic-58d7af.txt
Outdated
Show resolved
Hide resolved
This reverts commit bc8845e.
…issues-next-dev-tests
Benchmark for e40ae05Click to view benchmark
|
…issues-next-dev-tests
Benchmark for 56ab7d9Click to view benchmark
|
Benchmark for ee092a6
Click to view full benchmark
|
Benchmark for 79950aeClick to view benchmark
|
…issues-next-dev-tests
Benchmark for 38b9cd0
Click to view full benchmark
|
wbinnssmith
added a commit
that referenced
this pull request
Feb 27, 2023
This implements webpack loader context api for `emitError` and `emitWarning`, each of which emit Turbopack issues at the appropriate error level. As with webpack’s implementation, `emitError` does _not_ cause builds to fail [0]. This uses next-dev issue snapshots (#3774) to test that issues are emitted. [0] https://webpack.js.org/api/loaders/#thisemiterror
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 1, 2023
# New Features - vercel/turbo#3930 # Misc Changes - vercel/turbo#3944 - vercel/turbo#3774
wbinnssmith
added a commit
that referenced
this pull request
Mar 2, 2023
This implements webpack loader context api for `emitError` and `emitWarning`, each of which emit Turbopack issues at the appropriate error level. As with webpack’s implementation, `emitError` does _not_ cause builds to fail [0]. This uses next-dev issue snapshots (#3774) to test that issues are emitted. [0] https://webpack.js.org/api/loaders/#thisemiterror --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
This: * Adds issue snapshot support to next-dev-tests. This will allow us to assert that certain issues are raised in tests that require next-dev. * Extracts common snapshot code into a new crates, `turbopack-test-utils`, which is shared between snapshot tests and next-dev-tests. * Implements an issue reporter that emits issues in a channel to the the integration test code, where they are snapshotted. * Fixes an issue where next-dev tests that were not Next.js apps would emit non-fatal issues for a missing `pages/` directory. Co-authored-by: Justin Ridgewell <justin@ridgewell.name> --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…o#3983) This implements webpack loader context api for `emitError` and `emitWarning`, each of which emit Turbopack issues at the appropriate error level. As with webpack’s implementation, `emitError` does _not_ cause builds to fail [0]. This uses next-dev issue snapshots (vercel/turbo#3774) to test that issues are emitted. [0] https://webpack.js.org/api/loaders/#thisemiterror --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
This: * Adds issue snapshot support to next-dev-tests. This will allow us to assert that certain issues are raised in tests that require next-dev. * Extracts common snapshot code into a new crates, `turbopack-test-utils`, which is shared between snapshot tests and next-dev-tests. * Implements an issue reporter that emits issues in a channel to the the integration test code, where they are snapshotted. * Fixes an issue where next-dev tests that were not Next.js apps would emit non-fatal issues for a missing `pages/` directory. Co-authored-by: Justin Ridgewell <justin@ridgewell.name> --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…o#3983) This implements webpack loader context api for `emitError` and `emitWarning`, each of which emit Turbopack issues at the appropriate error level. As with webpack’s implementation, `emitError` does _not_ cause builds to fail [0]. This uses next-dev issue snapshots (vercel/turbo#3774) to test that issues are emitted. [0] https://webpack.js.org/api/loaders/#thisemiterror --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
turbopack-test-utils, which is shared between snapshot tests and next-dev-tests.pages/directory.Co-authored-by: Justin Ridgewell justin@ridgewell.name