webpack loaders: implement emitError and emitWarning
#3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements webpack loader context api for `emitError` and `emitWarning`, each of which emit Turbopack issues at the appropriate error level. As with webpack’s implementation, `emitError` does _not_ cause builds to fail [0]. This uses next-dev issue snapshots (#3774) to test that issues are emitted. [0] https://webpack.js.org/api/loaders/#thisemiterror
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
Benchmark for 7c2ca83
Click to view full benchmark
|
jridgewell
reviewed
Feb 28, 2023
jridgewell
reviewed
Mar 2, 2023
| severity: severity, | ||
| error: { | ||
| name: error instanceof Error ? error.name : "Error", | ||
| message: error instanceof Error ? error.message : error, |
There was a problem hiding this comment.
Maybe this is the bug here?
Suggested change
| message: error instanceof Error ? error.message : error, | |
| message: error instanceof Error ? error.message : String(error), |
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Benchmark for 99e1e93
Click to view full benchmark
|
jridgewell
approved these changes
Mar 2, 2023
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…o#3983) This implements webpack loader context api for `emitError` and `emitWarning`, each of which emit Turbopack issues at the appropriate error level. As with webpack’s implementation, `emitError` does _not_ cause builds to fail [0]. This uses next-dev issue snapshots (vercel/turbo#3774) to test that issues are emitted. [0] https://webpack.js.org/api/loaders/#thisemiterror --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…o#3983) This implements webpack loader context api for `emitError` and `emitWarning`, each of which emit Turbopack issues at the appropriate error level. As with webpack’s implementation, `emitError` does _not_ cause builds to fail [0]. This uses next-dev issue snapshots (vercel/turbo#3774) to test that issues are emitted. [0] https://webpack.js.org/api/loaders/#thisemiterror --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements webpack loader context api for
emitErrorandemitWarning, each of which emit Turbopack issues at the appropriate error level. As with webpack’s implementation,emitErrordoes not cause builds to fail [0].This uses next-dev issue snapshots (#3774) to test that issues are emitted.
[0] https://webpack.js.org/api/loaders/#thisemiterror