Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Issue Reporters (#3707)" #3796

Merged
merged 1 commit into from Feb 14, 2023
Merged

Revert "Issue Reporters (#3707)" #3796

merged 1 commit into from Feb 14, 2023

Conversation

Brooooooklyn
Copy link
Contributor

This reverts commit dae3e21.

This commit makes the turbotrace hanging, x-ref: https://vercel.slack.com/archives/C02UJN0A1UL/p1676369060652879

@Brooooooklyn Brooooooklyn requested review from a team as code owners February 14, 2023 12:40
@vercel
Copy link

vercel bot commented Feb 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Feb 14, 2023 at 0:40AM (UTC)
9 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)

@Brooooooklyn Brooooooklyn added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 14, 2023
@Brooooooklyn Brooooooklyn merged commit 6d5fee7 into main Feb 14, 2023
@Brooooooklyn Brooooooklyn deleted the revert-issue-reporters branch February 14, 2023 12:53
@Brooooooklyn Brooooooklyn mentioned this pull request Feb 14, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Benchmark for 8cd83d6

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 10.22ms ± 0.09ms 10.10ms ± 0.06ms -1.23%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.03ms ± 0.17ms 12.13ms ± 0.25ms +0.88%
bench_hmr_to_commit/Turbopack RSC/1000 modules 531.07ms ± 1.83ms 531.02ms ± 2.93ms -0.01%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.36ms ± 0.09ms 10.36ms ± 0.07ms +0.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 9212.35µs ± 73.65µs 9161.02µs ± 80.88µs -0.56%
bench_hmr_to_eval/Turbopack RCC/1000 modules 10.98ms ± 0.12ms 11.35ms ± 0.12ms +3.38%
bench_hmr_to_eval/Turbopack SSR/1000 modules 9248.47µs ± 116.61µs 9222.98µs ± 112.38µs -0.28%
bench_hydration/Turbopack RCC/1000 modules 4378.97ms ± 14.31ms 4370.51ms ± 14.66ms -0.19%
bench_hydration/Turbopack RSC/1000 modules 3964.58ms ± 18.96ms 3952.12ms ± 10.63ms -0.31%
bench_hydration/Turbopack SSR/1000 modules 3845.18ms ± 18.40ms 3837.72ms ± 21.54ms -0.19%
bench_startup/Turbopack CSR/1000 modules 2892.65ms ± 13.52ms 2862.14ms ± 19.85ms -1.05%
bench_startup/Turbopack RCC/1000 modules 2658.12ms ± 8.31ms 2650.91ms ± 9.36ms -0.27%
bench_startup/Turbopack RSC/1000 modules 2580.76ms ± 10.66ms 2552.77ms ± 12.29ms -1.08%
bench_startup/Turbopack SSR/1000 modules 2205.64ms ± 3.70ms 2200.47ms ± 3.80ms -0.23%

timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 14, 2023
@Brooooooklyn
Upgrade turbopack (#45861)
e3843c9 
The `experimental.turbotrace.memoryLimit` is not actually working, we
need to use `turbo_malloc` as the global allocator to make it work.

~~Block by:~~
- swc-project/swc#6940
- vercel/turbo#3772

## This PR also upgrades `turbopack-230213.2` to `turbopack-230214.1`

- vercel/turbo#3767
- vercel/turbo#3772
- vercel/turbo#3762
- vercel/turbo#3741
- vercel/turbo#3796
wbinnssmith added a commit that referenced this pull request Feb 14, 2023
@wbinnssmith
Revert "Revert "Issue Reporters (#3707)" (#3796)"
53841c4 
This reverts commit 6d5fee7.
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@Brooooooklyn
Revert "Issue Reporters (vercel/turbo#3707)" (vercel/turbo#3796)
8dead92 
This reverts commit a8612abf5edbde3013d6fcf8845976f422cb2ffc.

This commit makes the `turbotrace` hanging, x-ref:
https://vercel.slack.com/archives/C02UJN0A1UL/p1676369060652879
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@Brooooooklyn
Revert "Issue Reporters (vercel/turbo#3707)" (vercel/turbo#3796)
c881b16 
This reverts commit a8612abf5edbde3013d6fcf8845976f422cb2ffc.

This commit makes the `turbotrace` hanging, x-ref:
https://vercel.slack.com/archives/C02UJN0A1UL/p1676369060652879
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond was automatically assigned from vercel/turbo-oss

@arlyon arlyon Awaiting requested review from arlyon arlyon was automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Brooooooklyn @sokra