Separate tabs for Errors and Warnings in error overlay #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
🟢 CI successful 🟢Thanks |
sokra
approved these changes
Feb 28, 2023
| [TabId.TurbopackWarnings]: turbopackWarnings.length > 0, | ||
| [TabId.RuntimeErrors]: hasErrors, | ||
| }[tabId]) | ||
| )[0] ?? TabId.RuntimeErrors; |
There was a problem hiding this comment.
Suggested change
| )[0] ?? TabId.RuntimeErrors; | |
| )[0]; |
There was a problem hiding this comment.
didn't want it to be nullable
Comment on lines
+215
to
+216
| if (defaultTab === TabId.TurbopackErrors) { | ||
| setSelectedTab(TabId.TurbopackErrors); |
There was a problem hiding this comment.
Suggested change
| if (defaultTab === TabId.TurbopackErrors) { | |
| setSelectedTab(TabId.TurbopackErrors); | |
| if (defaultTab) { | |
| setSelectedTab(defaultTab ); |
There was a problem hiding this comment.
This is here to switch to the turbopack error tab if those appear later on, but I'm not sure if it's a good idea to have
ForsakenHarmony
force-pushed
the
hrmny/web-509-errors-warnings-tabs-error-overlay
branch
from
9491ff5
to
d789050
Compare
ForsakenHarmony
force-pushed
the
hrmny/web-509-errors-warnings-tabs-error-overlay
branch
from
d789050
to
362b867
Compare
ForsakenHarmony
force-pushed
the
hrmny/web-509-errors-warnings-tabs-error-overlay
branch
from
223b93d
to
c6f75f4
Compare
ForsakenHarmony
force-pushed
the
hrmny/web-509-errors-warnings-tabs-error-overlay
branch
from
c6f75f4
to
893502d
Compare
ForsakenHarmony
deleted the
hrmny/web-509-errors-warnings-tabs-error-overlay
branch
Benchmark for 6a263b6
Click to view full benchmark
|
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 8, 2023
## Bugfixes - vercel/turbo#3526 - vercel/turbo#4084 - vercel/turbo#4083 - vercel/turbo#4067 - vercel/turbo#3959 - vercel/turbo#4060 - vercel/turbo#4081 - vercel/turbo#4103 - vercel/turbo#4100 - vercel/turbo#4108 - vercel/turbo#4101 - vercel/turbo#4112 - vercel/turbo#3956 - vercel/turbo#4118 - vercel/turbo#4117 ## Feature - vercel/turbo#4058 - vercel/turbo#4013 - vercel/turbo#4005 - vercel/turbo#4001 - vercel/turbo#3839 - vercel/turbo#4017 - vercel/turbo#4086 - vercel/turbo#4067 ## Performance - vercel/turbo#4040 - vercel/turbo#4110 ## Refactor - vercel/turbo#4098
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.